OC_Defaults - Code Metrics - Inspection of "Merge pull request #30993 from owncloud/trashbin-f..." - owncloud/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b08fce...a46b5e )

by Phil

created 2018-06-08 15:09 UTC

OC_Defaults B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	276
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	7

Importance

Changes

Metric	Value
dl	0
loc	276
rs	8.2608
c	0
b	0
f	0
wmc	40
lcom	2
cbo	7

20 Methods

Rating	Name	Size	Complexity
B	__construct()	32	3
A	themeExist()	6	3
A	getBaseUrl()	7	2
A	getSyncClientUrl()	7	2
A	getiOSClientUrl()	7	2
A	getiTunesAppId()	7	2
A	getAndroidClientUrl()	7	2
A	getDocBaseUrl()	7	2
A	getTitle()	7	2
A	getName()	7	2
A	getHTMLName()	7	2
A	getEntity()	7	2
A	getSlogan()	7	2
A	getLogoClaim()	7	2
A	getShortFooter()	11	2
A	getLongFooter()	9	2
A	buildDocLinkToKey()	6	2
A	getMailHeaderColor()	7	2
A	getImprintUrl()	3	1
A	getPrivacyPolicyUrl()	3	1

How to fix Complexity

<?php
/**
 * @author Björn Schießle <[email protected]>
 * @author Jan-Christoph Borchardt <[email protected]>
 * @author Joas Schilling <[email protected]>
 * @author Jörn Friedrich Dreyer <[email protected]>
 * @author Lukas Reschke <[email protected]>
 * @author Morris Jobke <[email protected]>
 * @author Pascal de Bruijn <[email protected]>
 * @author Philipp Schaffrath <[email protected]>
 * @author Robin Appelman <[email protected]>
 * @author Robin McCorkell <[email protected]>
 * @author scolebrook <[email protected]>
 * @author Thomas Müller <[email protected]>
 * @author Volkan Gezer <[email protected]>
 *
 * @copyright Copyright (c) 2018, ownCloud GmbH
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */
class OC_Defaults {
	private $theme;
	private $l;

	private $defaultEntity;
	private $defaultName;
	private $defaultTitle;
	private $defaultBaseUrl;
	private $defaultSyncClientUrl;
	private $defaultiOSClientUrl;
	private $defaultiTunesAppId;
	private $defaultAndroidClientUrl;
	private $defaultDocBaseUrl;
	private $defaultDocVersion;
	private $defaultSlogan;
	private $defaultLogoClaim;
	/**
	 * @var \OCP\IConfig
	 */
	private $config;

	public function __construct() {
		$this->l = \OC::$server->getL10N('lib');
		$this->config = \OC::$server->getConfig();
		$version = \OCP\Util::getVersion();

		$this->defaultEntity = 'ownCloud'; /* e.g. company name, used for footers and copyright notices */
		$this->defaultName = 'ownCloud'; /* short name, used when referring to the software */
		$this->defaultTitle = 'ownCloud'; /* can be a longer name, for titles */
		$this->defaultBaseUrl = 'https://owncloud.org';
		$this->defaultSyncClientUrl = 'https://owncloud.org/install/#install-clients';
		$this->defaultiOSClientUrl = 'https://itunes.apple.com/us/app/owncloud/id543672169?mt=8';
		$this->defaultiTunesAppId = '543672169';
		$this->defaultAndroidClientUrl = 'https://play.google.com/store/apps/details?id=com.owncloud.android';
		$this->defaultDocBaseUrl = 'https://doc.owncloud.org';
		$this->defaultDocVersion = $version[0] . '.' . $version[1]; // used to generate doc links
		$this->defaultSlogan = $this->l->t('A safe home for all your data');
		$this->defaultLogoClaim = '';
		$this->defaultMailHeaderColor = '#1d2d44'; /* header color of mail notifications */
class MyClass { }

$x = new MyClass();
$x->foo = true;

		$themePath = OC_Util::getTheme()->getDirectory();

		$defaultsPath = OC::$SERVERROOT . '/' . $themePath . '/defaults.php';
		if (\file_exists($defaultsPath)) {
			// prevent defaults.php from printing output
			\ob_start();
			require_once $defaultsPath;
			\ob_end_clean();
			if (\class_exists('OC_Theme')) {
				$this->theme = new OC_Theme();
			}
		}
	}

	/**
	 * @param string $method
	 */
	private function themeExist($method) {
		if (isset($this->theme) && \method_exists($this->theme, $method)) {
			return true;
		}
		return false;
	}

	/**
	 * Returns the base URL
	 * @return string URL
	 */
	public function getBaseUrl() {
		if ($this->themeExist('getBaseUrl')) {
			return $this->theme->getBaseUrl();
		} else {
			return $this->defaultBaseUrl;
		}
	}

	/**
	 * Returns the URL where the sync clients are listed
	 * @return string URL
	 */
	public function getSyncClientUrl() {
		if ($this->themeExist('getSyncClientUrl')) {
			return $this->theme->getSyncClientUrl();
		} else {
			return $this->defaultSyncClientUrl;
		}
	}

	/**
	 * Returns the URL to the App Store for the iOS Client
	 * @return string URL
	 */
	public function getiOSClientUrl() {
		if ($this->themeExist('getiOSClientUrl')) {
			return $this->theme->getiOSClientUrl();
		} else {
			return $this->defaultiOSClientUrl;
		}
	}

	/**
	 * Returns the AppId for the App Store for the iOS Client
	 * @return string AppId
	 */
	public function getiTunesAppId() {
		if ($this->themeExist('getiTunesAppId')) {
			return $this->theme->getiTunesAppId();
		} else {
			return $this->defaultiTunesAppId;
		}
	}

	/**
	 * Returns the URL to Google Play for the Android Client
	 * @return string URL
	 */
	public function getAndroidClientUrl() {
		if ($this->themeExist('getAndroidClientUrl')) {
			return $this->theme->getAndroidClientUrl();
		} else {
			return $this->defaultAndroidClientUrl;
		}
	}

	/**
	 * Returns the documentation URL
	 * @return string URL
	 */
	public function getDocBaseUrl() {
		if ($this->themeExist('getDocBaseUrl')) {
			return $this->theme->getDocBaseUrl();
		} else {
			return $this->defaultDocBaseUrl;
		}
	}

	/**
	 * Returns the title
	 * @return string title
	 */
	public function getTitle() {
		if ($this->themeExist('getTitle')) {
			return $this->theme->getTitle();
		} else {
			return $this->defaultTitle;
		}
	}

	/**
	 * Returns the short name of the software
	 * @return string title
	 */
	public function getName() {
		if ($this->themeExist('getName')) {
			return $this->theme->getName();
		} else {
			return $this->defaultName;
		}
	}

	/**
	 * Returns the short name of the software containing HTML strings
	 * @return string title
	 */
	public function getHTMLName() {
		if ($this->themeExist('getHTMLName')) {
			return $this->theme->getHTMLName();
		} else {
			return $this->defaultName;
		}
	}

	/**
	 * Returns entity (e.g. company name) - used for footer, copyright
	 * @return string entity name
	 */
	public function getEntity() {
		if ($this->themeExist('getEntity')) {
			return $this->theme->getEntity();
		} else {
			return $this->defaultEntity;
		}
	}

	/**
	 * Returns slogan
	 * @return string slogan
	 */
	public function getSlogan() {
		if ($this->themeExist('getSlogan')) {
			return $this->theme->getSlogan();
		} else {
			return $this->defaultSlogan;
		}
	}

	/**
	 * Returns logo claim
	 * @return string logo claim
	 */
	public function getLogoClaim() {
		if ($this->themeExist('getLogoClaim')) {
			return $this->theme->getLogoClaim();
		} else {
			return $this->defaultLogoClaim;
		}
	}

	/**
	 * Returns short version of the footer
	 * @return string short footer
	 */
	public function getShortFooter() {
		if ($this->themeExist('getShortFooter')) {
			$footer = $this->theme->getShortFooter();
		} else {
			$footer = '<a href="'. $this->getBaseUrl() . '" target="_blank"' .
				' rel="noreferrer">' .$this->getEntity() . '</a>'.
				' – ' . $this->getSlogan();
		}

		return $footer;
	}

	/**
	 * Returns long version of the footer
	 * @return string long footer
	 */
	public function getLongFooter() {
		if ($this->themeExist('getLongFooter')) {
			$footer = $this->theme->getLongFooter();
		} else {
			$footer = $this->getShortFooter();
		}

		return $footer;
	}

	/**
	 * @param string $key
	 */
	public function buildDocLinkToKey($key) {
		if ($this->themeExist('buildDocLinkToKey')) {
			return $this->theme->buildDocLinkToKey($key);
		}
		return $this->getDocBaseUrl() . '/server/' . $this->defaultDocVersion . '/go.php?to=' . $key;
	}

	/**
	 * Returns mail header color
	 * @return string
	 */
	public function getMailHeaderColor() {
		if ($this->themeExist('getMailHeaderColor')) {
			return $this->theme->getMailHeaderColor();
		} else {
			return $this->defaultMailHeaderColor;
		}
	}

	/**
	 * Returns URL to imprint
	 * @return string
	 */
	public function getImprintUrl() {
		return $this->config->getAppValue('core', 'legal.imprint_url', '');
	}

	/**
	 * Returns URL to Privacy Policy
	 * @return string
	 */
	public function getPrivacyPolicyUrl() {
		return $this->config->getAppValue('core', 'legal.privacy_policy_url', '');
	}
}


1			<?php
2			/**
3			* @author Björn Schießle <[email protected]>
4			* @author Jan-Christoph Borchardt <[email protected]>
5			* @author Joas Schilling <[email protected]>
6			* @author Jörn Friedrich Dreyer <[email protected]>
7			* @author Lukas Reschke <[email protected]>
8			* @author Morris Jobke <[email protected]>
9			* @author Pascal de Bruijn <[email protected]>
10			* @author Philipp Schaffrath <[email protected]>
11			* @author Robin Appelman <[email protected]>
12			* @author Robin McCorkell <[email protected]>
13			* @author scolebrook <[email protected]>
14			* @author Thomas Müller <[email protected]>
15			* @author Volkan Gezer <[email protected]>
16			*
17			* @copyright Copyright (c) 2018, ownCloud GmbH
18			* @license AGPL-3.0
19			*
20			* This code is free software: you can redistribute it and/or modify
21			* it under the terms of the GNU Affero General Public License, version 3,
22			* as published by the Free Software Foundation.
23			*
24			* This program is distributed in the hope that it will be useful,
25			* but WITHOUT ANY WARRANTY; without even the implied warranty of
26			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
27			* GNU Affero General Public License for more details.
28			*
29			* You should have received a copy of the GNU Affero General Public License, version 3,
30			* along with this program. If not, see <http://www.gnu.org/licenses/>
31			*
32			*/
33			class OC_Defaults {
34			private $theme;
35			private $l;
36
37			private $defaultEntity;
38			private $defaultName;
39			private $defaultTitle;
40			private $defaultBaseUrl;
41			private $defaultSyncClientUrl;
42			private $defaultiOSClientUrl;
43			private $defaultiTunesAppId;
44			private $defaultAndroidClientUrl;
45			private $defaultDocBaseUrl;
46			private $defaultDocVersion;
47			private $defaultSlogan;
48			private $defaultLogoClaim;
49			/**
50			* @var \OCP\IConfig
51			*/
52			private $config;
53
54			public function __construct() {
55			$this->l = \OC::$server->getL10N('lib');
56			$this->config = \OC::$server->getConfig();
57			$version = \OCP\Util::getVersion();
58
59			$this->defaultEntity = 'ownCloud'; /* e.g. company name, used for footers and copyright notices */
60			$this->defaultName = 'ownCloud'; /* short name, used when referring to the software */
61			$this->defaultTitle = 'ownCloud'; /* can be a longer name, for titles */
62			$this->defaultBaseUrl = 'https://owncloud.org';
63			$this->defaultSyncClientUrl = 'https://owncloud.org/install/#install-clients';
64			$this->defaultiOSClientUrl = 'https://itunes.apple.com/us/app/owncloud/id543672169?mt=8';
65			$this->defaultiTunesAppId = '543672169';
66			$this->defaultAndroidClientUrl = 'https://play.google.com/store/apps/details?id=com.owncloud.android';
67			$this->defaultDocBaseUrl = 'https://doc.owncloud.org';
68			$this->defaultDocVersion = $version[0] . '.' . $version[1]; // used to generate doc links
69			$this->defaultSlogan = $this->l->t('A safe home for all your data');
70			$this->defaultLogoClaim = '';
71			$this->defaultMailHeaderColor = '#1d2d44'; /* header color of mail notifications */
			0 ignored issues – show Bug introduced 2018-06-07 17:57 UTC by Report Bug Copy Issue Report The property `defaultMailHeaderColor` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
72
73			$themePath = OC_Util::getTheme()->getDirectory();
74
75			$defaultsPath = OC::$SERVERROOT . '/' . $themePath . '/defaults.php';
76			if (\file_exists($defaultsPath)) {
77			// prevent defaults.php from printing output
78			\ob_start();
79			require_once $defaultsPath;
80			\ob_end_clean();
81			if (\class_exists('OC_Theme')) {
82			$this->theme = new OC_Theme();
83			}
84			}
85			}
86
87			/**
88			* @param string $method
89			*/
90			private function themeExist($method) {
91			if (isset($this->theme) && \method_exists($this->theme, $method)) {
92			return true;
93			}
94			return false;
95			}
96
97			/**
98			* Returns the base URL
99			* @return string URL
100			*/
101			public function getBaseUrl() {
102			if ($this->themeExist('getBaseUrl')) {
103			return $this->theme->getBaseUrl();
104			} else {
105			return $this->defaultBaseUrl;
106			}
107			}
108
109			/**
110			* Returns the URL where the sync clients are listed
111			* @return string URL
112			*/
113			public function getSyncClientUrl() {
114			if ($this->themeExist('getSyncClientUrl')) {
115			return $this->theme->getSyncClientUrl();
116			} else {
117			return $this->defaultSyncClientUrl;
118			}
119			}
120
121			/**
122			* Returns the URL to the App Store for the iOS Client
123			* @return string URL
124			*/
125			public function getiOSClientUrl() {
126			if ($this->themeExist('getiOSClientUrl')) {
127			return $this->theme->getiOSClientUrl();
128			} else {
129			return $this->defaultiOSClientUrl;
130			}
131			}
132
133			/**
134			* Returns the AppId for the App Store for the iOS Client
135			* @return string AppId
136			*/
137			public function getiTunesAppId() {
138			if ($this->themeExist('getiTunesAppId')) {
139			return $this->theme->getiTunesAppId();
140			} else {
141			return $this->defaultiTunesAppId;
142			}
143			}
144
145			/**
146			* Returns the URL to Google Play for the Android Client
147			* @return string URL
148			*/
149			public function getAndroidClientUrl() {
150			if ($this->themeExist('getAndroidClientUrl')) {
151			return $this->theme->getAndroidClientUrl();
152			} else {
153			return $this->defaultAndroidClientUrl;
154			}
155			}
156
157			/**
158			* Returns the documentation URL
159			* @return string URL
160			*/
161			public function getDocBaseUrl() {
162			if ($this->themeExist('getDocBaseUrl')) {
163			return $this->theme->getDocBaseUrl();
164			} else {
165			return $this->defaultDocBaseUrl;
166			}
167			}
168
169			/**
170			* Returns the title
171			* @return string title
172			*/
173			public function getTitle() {
174			if ($this->themeExist('getTitle')) {
175			return $this->theme->getTitle();
176			} else {
177			return $this->defaultTitle;
178			}
179			}
180
181			/**
182			* Returns the short name of the software
183			* @return string title
184			*/
185			public function getName() {
186			if ($this->themeExist('getName')) {
187			return $this->theme->getName();
188			} else {
189			return $this->defaultName;
190			}
191			}
192
193			/**
194			* Returns the short name of the software containing HTML strings
195			* @return string title
196			*/
197			public function getHTMLName() {
198			if ($this->themeExist('getHTMLName')) {
199			return $this->theme->getHTMLName();
200			} else {
201			return $this->defaultName;
202			}
203			}
204
205			/**
206			* Returns entity (e.g. company name) - used for footer, copyright
207			* @return string entity name
208			*/
209			public function getEntity() {
210			if ($this->themeExist('getEntity')) {
211			return $this->theme->getEntity();
212			} else {
213			return $this->defaultEntity;
214			}
215			}
216
217			/**
218			* Returns slogan
219			* @return string slogan
220			*/
221			public function getSlogan() {
222			if ($this->themeExist('getSlogan')) {
223			return $this->theme->getSlogan();
224			} else {
225			return $this->defaultSlogan;
226			}
227			}
228
229			/**
230			* Returns logo claim
231			* @return string logo claim
232			*/
233			public function getLogoClaim() {
234			if ($this->themeExist('getLogoClaim')) {
235			return $this->theme->getLogoClaim();
236			} else {
237			return $this->defaultLogoClaim;
238			}
239			}
240
241			/**
242			* Returns short version of the footer
243			* @return string short footer
244			*/
245			public function getShortFooter() {
246			if ($this->themeExist('getShortFooter')) {
247			$footer = $this->theme->getShortFooter();
248			} else {
249			$footer = '<a href="'. $this->getBaseUrl() . '" target="_blank"' .
250			' rel="noreferrer">' .$this->getEntity() . '</a>'.
251			' – ' . $this->getSlogan();
252			}
253
254			return $footer;
255			}
256
257			/**
258			* Returns long version of the footer
259			* @return string long footer
260			*/
261			public function getLongFooter() {
262			if ($this->themeExist('getLongFooter')) {
263			$footer = $this->theme->getLongFooter();
264			} else {
265			$footer = $this->getShortFooter();
266			}
267
268			return $footer;
269			}
270
271			/**
272			* @param string $key
273			*/
274			public function buildDocLinkToKey($key) {
275			if ($this->themeExist('buildDocLinkToKey')) {
276			return $this->theme->buildDocLinkToKey($key);
277			}
278			return $this->getDocBaseUrl() . '/server/' . $this->defaultDocVersion . '/go.php?to=' . $key;
279			}
280
281			/**
282			* Returns mail header color
283			* @return string
284			*/
285			public function getMailHeaderColor() {
286			if ($this->themeExist('getMailHeaderColor')) {
287			return $this->theme->getMailHeaderColor();
288			} else {
289			return $this->defaultMailHeaderColor;
290			}
291			}
292
293			/**
294			* Returns URL to imprint
295			* @return string
296			*/
297			public function getImprintUrl() {
298			return $this->config->getAppValue('core', 'legal.imprint_url', '');
299			}
300
301			/**
302			* Returns URL to Privacy Policy
303			* @return string
304			*/
305			public function getPrivacyPolicyUrl() {
306			return $this->config->getAppValue('core', 'legal.privacy_policy_url', '');
307			}
308			}
309

owncloud / core

Push — master ( b08fce...a46b5e )

OC_Defaults B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

20 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like