OC\Setup\OCI::setupDatabase()

Complexity

Conditions	15
Paths	220

Size

Total Lines

117

Duplication

Lines	20
Ratio	17.09 %

Importance

Changes

0

<?php
	public function setupDatabase($username) {
		$e_host = \addslashes($this->dbHost);
		$e_dbname = \addslashes($this->dbName);
		//check if the database user has admin right
		if ($e_host == '') {

This code seems to be duplicated across your project.

			$easy_connect_string = $e_dbname; // use dbname as easy connect name
		} else {
			$easy_connect_string = '//'.$e_host.'/'.$e_dbname;
		}
		$this->logger->debug('connect string: ' . $easy_connect_string, ['app' => 'setup.oci']);
		$connection = @\oci_connect($this->dbUser, $this->dbPassword, $easy_connect_string);
		if (!$connection) {
			$errorMessage = $this->getLastError();
			if ($errorMessage) {
				throw new \OC\DatabaseSetupException($this->trans->t('Oracle connection could not be established'),
				$errorMessage.' Check environment: ORACLE_HOME='.\getenv('ORACLE_HOME')
							.' ORACLE_SID='.\getenv('ORACLE_SID')
							.' LD_LIBRARY_PATH='.\getenv('LD_LIBRARY_PATH')
							.' NLS_LANG='.\getenv('NLS_LANG')
							.' tnsnames.ora is '.(\is_readable(\getenv('ORACLE_HOME').'/network/admin/tnsnames.ora')?'':'not ').'readable');
			}
			throw new \OC\DatabaseSetupException($this->trans->t('Oracle username and/or password not valid'),
					'Check environment: ORACLE_HOME='.\getenv('ORACLE_HOME')
							.' ORACLE_SID='.\getenv('ORACLE_SID')
							.' LD_LIBRARY_PATH='.\getenv('LD_LIBRARY_PATH')
							.' NLS_LANG='.\getenv('NLS_LANG')
							.' tnsnames.ora is '.(\is_readable(\getenv('ORACLE_HOME').'/network/admin/tnsnames.ora')?'':'not ').'readable');
		}
		//check for roles creation rights in oracle

		$query="SELECT CASE WHEN (count(*) = 6) THEN 1 ELSE 0 END AS all_privileges
		        FROM user_role_privs a1
		        INNER JOIN role_sys_privs a2 ON a1.granted_role = a2.role
		        WHERE ( a2.privilege IN ('CREATE USER', 'ALTER USER') )
		            OR ( a2.privilege IN (
		                'CREATE SESSION',
		                'CREATE TABLE',
		                'CREATE SEQUENCE',
		                'CREATE TRIGGER'
		                ) AND a2.admin_option = 'YES')";
		$stmt = \oci_parse($connection, $query);
		if (!$stmt) {

This code seems to be duplicated across your project.

			$entry = $this->trans->t('DB Error: "%s"', [$this->getLastError($connection)]) . '<br />';
			$entry .= $this->trans->t('Offending command was: "%s"', [$query]) . '<br />';
			$this->logger->warning($entry, ['app' => 'setup.oci']);
		}
		$result = \oci_execute($stmt);
		if ($result) {
			$row = \oci_fetch_row($stmt);

			if ($row[0] > 0) {
				//use the admin login data for the new database user

				//add prefix to the oracle user name to prevent collisions
				$this->dbUser='oc_'.$username;
				//create a new password so we don't need to store the admin config in the config file
				$this->dbPassword = \OC::$server->getSecureRandom()->generate(30, \OCP\Security\ISecureRandom::CHAR_LOWER.\OCP\Security\ISecureRandom::CHAR_DIGITS);

				//oracle passwords are treated as identifiers:
				//  must start with alphanumeric char
				//  needs to be shortened to 30 bytes, as the two " needed to escape the identifier count towards the identifier length.
				$this->dbPassword=\substr($this->dbPassword, 0, 30);

				$this->createDBUser($connection);
			}
		}

		$this->config->setSystemValues([
			'dbuser'		=> $this->dbUser,
			'dbname'		=> $this->dbName,
			'dbpassword'	=> $this->dbPassword,
		]);

		//create the database not necessary, oracle implies user = schema
		//$this->createDatabase($this->dbname, $this->dbuser, $connection);

		//FIXME check tablespace exists: select * from user_tablespaces

		// the connection to dbname=oracle is not needed anymore
		\oci_close($connection);

		// connect to the oracle database (schema=$this->dbuser) an check if the schema needs to be filled
		$this->dbUser = $this->config->getSystemValue('dbuser');
		//$this->dbname = \OC_Config::getValue('dbname');
		$this->dbPassword = $this->config->getSystemValue('dbpassword');

		$e_host = \addslashes($this->dbHost);
		$e_dbname = \addslashes($this->dbName);

		if ($e_host == '') {

This code seems to be duplicated across your project.

			$easy_connect_string = $e_dbname; // use dbname as easy connect name
		} else {
			$easy_connect_string = '//'.$e_host.'/'.$e_dbname;
		}
		$connection = @\oci_connect($this->dbUser, $this->dbPassword, $easy_connect_string);
		if (!$connection) {
			throw new \OC\DatabaseSetupException($this->trans->t('Oracle username and/or password not valid'),
					$this->trans->t('You need to enter either an existing account or the administrator.'));
		}
		$query = "SELECT count(*) FROM user_tables WHERE table_name = :un";
		$stmt = \oci_parse($connection, $query);
		$un = $this->tablePrefix.'users';
		\oci_bind_by_name($stmt, ':un', $un);
		if (!$stmt) {

This code seems to be duplicated across your project.

			$entry = $this->trans->t('DB Error: "%s"', [$this->getLastError($connection)]) . '<br />';
			$entry .= $this->trans->t('Offending command was: "%s"', [$query]) . '<br />';
			$this->logger->warning($entry, ['app' => 'setup.oci']);
		}
		$result = \oci_execute($stmt);

		if ($result) {
			$row = \oci_fetch_row($stmt);
		}
		if (!$result or $row[0]==0) {

The variable $row does not seem to be defined for all execution paths leading up to this point.

			\OC_DB::createDbFromStructure($this->dbDefinitionFile);
		}
	}