Completed
Pull Request — master (#24439)
by Roeland
11:59
created
lib/private/legacy/helper.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -197,6 +197,9 @@  discard block
 block discarded – undo
197 197
 		return self::linkToRoute( 'core_ajax_preview', array('x' => 32, 'y' => 32, 'file' => $path ));
198 198
 	}
199 199
 
200
+	/**
201
+	 * @param string $path
202
+	 */
200 203
 	public static function publicPreviewIcon( $path, $token ) {
201 204
 		return self::linkToRoute( 'core_ajax_public_preview', array('x' => 32, 'y' => 32, 'file' => $path, 't' => $token));
202 205
 	}
@@ -827,7 +830,7 @@  discard block
 block discarded – undo
827 830
 	 *
828 831
 	 * @param string $path
829 832
 	 * @param \OCP\Files\FileInfo $rootInfo (optional)
830
-	 * @return array
833
+	 * @return string
831 834
 	 * @throws \OCP\Files\NotFoundException
832 835
 	 */
833 836
 	public static function getStorageInfo($path, $rootInfo = null) {
Please login to merge, or discard this patch.
lib/private/legacy/util.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1434,7 +1434,7 @@
 block discarded – undo
1434 1434
 	 * Normalize a unicode string
1435 1435
 	 *
1436 1436
 	 * @param string $value a not normalized string
1437
-	 * @return bool|string
1437
+	 * @return string
1438 1438
 	 */
1439 1439
 	public static function normalizeUnicode($value) {
1440 1440
 		if(Normalizer::isNormalized($value)) {
Please login to merge, or discard this patch.
lib/private/Group/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@
 block discarded – undo
152 152
 
153 153
 	/**
154 154
 	 * @param string $gid
155
-	 * @return \OCP\IGroup
155
+	 * @return null|Group
156 156
 	 */
157 157
 	protected function getGroupObject($gid) {
158 158
 		$backends = array();
Please login to merge, or discard this patch.
lib/private/Installer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -476,7 +476,7 @@
 block discarded – undo
476 476
 
477 477
 	/**
478 478
 	 * Removes an app
479
-	 * @param string $name name of the application to remove
479
+	 * @param string $appId
480 480
 	 * @return boolean
481 481
 	 *
482 482
 	 *
Please login to merge, or discard this patch.
lib/private/legacy/user.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@
 block discarded – undo
152 152
 	 *
153 153
 	 * @param string $loginname The login name of the user to log in
154 154
 	 * @param string $password The password of the user
155
-	 * @return boolean|null
155
+	 * @return boolean
156 156
 	 *
157 157
 	 * Log in a user and regenerate a new session - if the password is ok
158 158
 	 */
Please login to merge, or discard this patch.
apps/dav/appinfo/application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@
 block discarded – undo
25 25
 use OCA\DAV\CalDAV\CalDavBackend;
26 26
 use OCA\DAV\CardDAV\CardDavBackend;
27 27
 use OCA\DAV\CardDAV\ContactsManager;
28
-use OCA\DAV\CardDAV\SyncJob;
29 28
 use OCA\DAV\CardDAV\SyncService;
30 29
 use OCA\DAV\Connector\Sabre\Principal;
31 30
 use OCA\DAV\DAV\GroupPrincipalBackend;
Please login to merge, or discard this patch.