View GitHub Repository core

Schedule Inspection
Subscribe
Completed
Pull Request — master (#24728)
by Joas
30:57
created
Status
Category
Toggle Patches
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -78,7 +78,7 @@
 
 block discarded – undo
78 78 
 	 * the next element.
79 79 
 	 *
80 80 
 	 * @param Reader $reader
81 
-	 * @return mixed
81 
+	 * @return TagList
82 82 
 	 */
83 83 
 	static function xmlDeserialize(Reader $reader) {
84 84 
 		$tags = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagsPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -46,7 +46,7 @@
 
 block discarded – undo
46 46 
 	private $tree;
47 47
48 48 
 	/**
49 
-	 * @param \Sabre\DAV\Tree $tree tree
49 
+	 * @param ObjectTree $tree tree
50 50 
 	 */
51 51 
 	public function __construct(Tree $tree) {
52 52 
 		$this->tree = $tree;
Please login to merge, or discard this patch.
apps/dav/lib/DAV/Sharing/Plugin.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -25,7 +25,6 @@
 
 block discarded – undo
25 25 
 use OCA\DAV\Connector\Sabre\Auth;
26 26 
 use OCA\DAV\DAV\Sharing\Xml\Invite;
27 27 
 use OCP\IRequest;
28 
-use Sabre\DAV\Exception\BadRequest;
29 28 
 use Sabre\DAV\Exception\NotFound;
30 29 
 use Sabre\DAV\INode;
31 30 
 use Sabre\DAV\PropFind;
Please login to merge, or discard this patch.
apps/dav/lib/DAV/SystemPrincipalBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -136,7 +136,7 @@
 
 block discarded – undo
136 136 
 	 * Returns the list of members for a group-principal
137 137 
 	 *
138 138 
 	 * @param string $principal
139 
-	 * @return array
139 
+	 * @return string[]
140 140 
 	 */
141 141 
 	function getGroupMemberSet($principal) {
142 142 
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Files/BrowserErrorPagePlugin.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch 
@@ -86,8 +86,6 @@
 
 block discarded – undo
86 86
87 87 
 	/**
88 88 
 	 * @codeCoverageIgnore
89 
-	 * @param \Exception $ex
90 
-	 * @param int $httpCode
91 89 
 	 * @return bool|string
92 90 
 	 */
93 91 
 	public function generateBody(\Exception $exception) {
Please login to merge, or discard this patch.
apps/dav/lib/Server.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -23,7 +23,6 @@
 
 block discarded – undo
23 23 
 namespace OCA\DAV;
24 24
25 25 
 use OCA\DAV\CalDAV\Schedule\IMipPlugin;
26 
-use OCA\DAV\Connector\FedAuth;
27 26 
 use OCA\DAV\Connector\Sabre\Auth;
28 27 
 use OCA\DAV\Connector\Sabre\BlockLegacyClientPlugin;
29 28 
 use OCA\DAV\Files\CustomPropertiesBackend;
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsByIdCollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -27,7 +27,6 @@
 
 block discarded – undo
27 27 
 use OCP\IUser;
28 28 
 use OCP\ILogger;
29 29 
 use OCP\Files\Folder;
30 
-
31 30 
 use OC\Share20\Exception\ShareNotFound;
32 31
33 32 
 /**
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsObjectMappingCollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -27,7 +27,6 @@
 
 block discarded – undo
27 27 
 use OCP\IUser;
28 28 
 use OCP\ILogger;
29 29 
 use OCP\Files\Folder;
30 
-
31 30 
 use OC\Share20\Exception\ShareNotFound;
32 31
33 32 
 /**
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsObjectTypeCollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -27,7 +27,6 @@
 
 block discarded – undo
27 27 
 use OCP\IUser;
28 28 
 use OCP\ILogger;
29 29 
 use OCP\Files\Folder;
30 
-
31 30 
 use OC\Share20\Exception\ShareNotFound;
32 31
33 32 
 /**
Please login to merge, or discard this patch.