Completed
Pull Request — master (#29925)
by Martin
09:21
created
lib/private/Files/Storage/Wrapper/Encryption.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -672,7 +672,7 @@  discard block
 block discarded – undo
672 672
 	 * Set the flag to true, so that the file would be
673 673
 	 * in the decrypted state.
674 674
 	 *
675
-	 * @param $isDisabled bool
675
+	 * @param boolean $isDisabled bool
676 676
 	 */
677 677
 	public static function setDisableWriteEncryption($isDisabled) {
678 678
 		self::$disableWriteEncryption = $isDisabled;
@@ -929,7 +929,7 @@  discard block
 block discarded – undo
929 929
 	/**
930 930
 	 * return header size of given file
931 931
 	 *
932
-	 * @param string|resource $path
932
+	 * @param string $path
933 933
 	 * @return int
934 934
 	 */
935 935
 	protected function getHeaderSize($path) {
@@ -980,7 +980,7 @@  discard block
 block discarded – undo
980 980
 	/**
981 981
 	 * read header from file
982 982
 	 *
983
-	 * @param string|resource $path
983
+	 * @param string $path
984 984
 	 * @return array
985 985
 	 */
986 986
 	protected function getHeader($path) {
@@ -1076,7 +1076,7 @@  discard block
 block discarded – undo
1076 1076
 	/**
1077 1077
 	 * check if path points to a files version
1078 1078
 	 *
1079
-	 * @param $path
1079
+	 * @param string $path
1080 1080
 	 * @return bool
1081 1081
 	 */
1082 1082
 	protected function isVersion($path) {
Please login to merge, or discard this patch.
lib/private/AllConfig.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -449,7 +449,7 @@
 block discarded – undo
449 449
 	 * In some environments the system config file is readonly. Find out if this
450 450
 	 * is the case.
451 451
 	 *
452
-	 * @return boolean
452
+	 * @return false|string
453 453
 	 * @since 10.0.3
454 454
 	 */
455 455
 	public function isSystemConfigReadOnly() {
Please login to merge, or discard this patch.
lib/private/DB/MySqlSchemaColumnDefinitionListener.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 namespace OC\DB;
23 23
 
24 24
 use Doctrine\DBAL\DBALException;
25
-use Doctrine\DBAL\Driver\ServerInfoAwareConnection;
26 25
 use Doctrine\DBAL\Event\SchemaColumnDefinitionEventArgs;
27 26
 use Doctrine\DBAL\Platforms\MySqlPlatform;
28 27
 use Doctrine\DBAL\Schema\Column;
Please login to merge, or discard this patch.
lib/private/Files/Storage/Common.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -699,7 +699,7 @@
 block discarded – undo
699 699
 	}
700 700
 
701 701
 	/**
702
-	 * @param $internalPath
702
+	 * @param string $internalPath
703 703
 	 * @return array
704 704
 	 */
705 705
 	private function convertInternalPathToGlobalPath($internalPath) {
Please login to merge, or discard this patch.
apps/files_versions/lib/Storage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -310,6 +310,9 @@
 block discarded – undo
310 310
 	}
311 311
 
312 312
 
313
+	/**
314
+	 * @param string $revision
315
+	 */
313 316
 	public static function restoreVersion($uid, $filename, $fileToRestore, $revision) {
314 317
 		if(\OCP\Config::getSystemValue('files_versions', Storage::DEFAULTENABLED) !== true) {
315 318
 			return false;
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/CorsPlugin.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 	 * This method should set up the required event subscriptions.
63 63
 	 *
64 64
 	 * @param \Sabre\DAV\Server $server
65
-	 * @return void
65
+	 * @return false|null
66 66
 	 */
67 67
 	public function initialize(\Sabre\DAV\Server $server) {
68 68
 		$this->server = $server;
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	 * @param RequestInterface $request
97 97
 	 * @param ResponseInterface $response
98 98
 	 *
99
-	 * @return false
99
+	 * @return false|null
100 100
 	 */
101 101
 	public function setOptionsRequestHeaders(RequestInterface $request, ResponseInterface $response) {
102 102
 		$authorization = $request->getHeader('Authorization');
Please login to merge, or discard this patch.
lib/private/legacy/response.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 	 * @param string $domain
276 276
 	 * @param Sabre\HTTP\ResponseInterface $response
277 277
 	 * @param \OCP\IConfig $config
278
-	 * @param Array $headers
278
+	 * @param string[] $headers
279 279
 	 *
280 280
 	 * Format of $headers:
281 281
 	 * Array [
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
 	 * This function adds the CORS headers for all domains
315 315
 	 *
316 316
 	 * @param Sabre\HTTP\ResponseInterface $response
317
-	 * @param Array $headers
317
+	 * @param string[] $headers
318 318
 	 *
319 319
 	 * Format of $headers:
320 320
 	 * Array [
Please login to merge, or discard this patch.
lib/private/App/AppManager.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	/**
123 123
 	 * List all installed apps
124 124
 	 *
125
-	 * @return string[]
125
+	 * @return integer[]
126 126
 	 */
127 127
 	public function getInstalledApps() {
128 128
 		return array_keys($this->getInstalledAppsValues());
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 	/**
232 232
 	 * Do not allow more than one active app-theme
233 233
 	 *
234
-	 * @param $appId
234
+	 * @param string $appId
235 235
 	 * @throws AppManagerException
236 236
 	 */
237 237
 	protected function canEnableTheme($appId) {
@@ -390,6 +390,9 @@  discard block
 block discarded – undo
390 390
 		return in_array($appId, $this->shippedApps);
391 391
 	}
392 392
 
393
+	/**
394
+	 * @param string $appId
395
+	 */
393 396
 	private function isAlwaysEnabled($appId) {
394 397
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
395 398
 		return in_array($appId, $alwaysEnabled);
@@ -418,7 +421,7 @@  discard block
 block discarded – undo
418 421
 	/**
419 422
 	 * @param string $package package path
420 423
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
421
-	 * @return string|false app id or false in case of error
424
+	 * @return integer app id or false in case of error
422 425
 	 * @since 10.0
423 426
 	 */
424 427
 	public function installApp($package, $skipMigrations = false) {
@@ -431,7 +434,7 @@  discard block
 block discarded – undo
431 434
 
432 435
 	/**
433 436
 	 * @param string $package
434
-	 * @return mixed
437
+	 * @return boolean
435 438
 	 * @since 10.0
436 439
 	 */
437 440
 	public function updateApp($package) {
Please login to merge, or discard this patch.
core/Command/App/Enable.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@
 block discarded – undo
25 25
 namespace OC\Core\Command\App;
26 26
 
27 27
 use OCP\App\IAppManager;
28
-use OCP\ILogger;
29 28
 use Symfony\Component\Console\Command\Command;
30 29
 use Symfony\Component\Console\Input\InputArgument;
31 30
 use Symfony\Component\Console\Input\InputInterface;
Please login to merge, or discard this patch.