owncloud /
core
| Conditions | 23 |
| Paths | 181 |
| Total Lines | 92 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 94 | public function createUser($username, $password, array $groups= [], $email='') { |
||
| 95 | if ($email !== '' && !$this->mailer->validateMailAddress($email)) { |
||
| 96 | throw new InvalidEmailException("Invalid mail address"); |
||
| 97 | } |
||
| 98 | |||
| 99 | $currentUser = $this->userSession->getUser(); |
||
| 100 | |||
| 101 | if (!$this->isAdmin()) { |
||
| 102 | if (!empty($groups)) { |
||
| 103 | foreach ($groups as $key => $group) { |
||
| 104 | $groupObject = $this->groupManager->get($group); |
||
| 105 | if ($groupObject === null) { |
||
| 106 | unset($groups[$key]); |
||
| 107 | continue; |
||
| 108 | } |
||
| 109 | |||
| 110 | if (!$this->groupManager->getSubAdmin()->isSubAdminofGroup($currentUser, $groupObject)) { |
||
|
|
|||
| 111 | unset($groups[$key]); |
||
| 112 | } |
||
| 113 | } |
||
| 114 | } |
||
| 115 | |||
| 116 | if (empty($groups)) { |
||
| 117 | $groups = $this->groupManager->getSubAdmin()->getSubAdminsGroups($currentUser); |
||
| 118 | // New class returns IGroup[] so convert back |
||
| 119 | $gids = []; |
||
| 120 | foreach ($groups as $group) { |
||
| 121 | $gids[] = $group->getGID(); |
||
| 122 | } |
||
| 123 | $groups = $gids; |
||
| 124 | } |
||
| 125 | } |
||
| 126 | |||
| 127 | if ($this->userManager->userExists($username)) { |
||
| 128 | throw new UserAlreadyExistsException('A user with that name already exists.'); |
||
| 129 | } |
||
| 130 | |||
| 131 | try { |
||
| 132 | if (($password === '') && ($email !== '')) { |
||
| 133 | /** |
||
| 134 | * Generate a random password as we are going to have this |
||
| 135 | * use one time. The new user has to reset it using the link |
||
| 136 | * from email. |
||
| 137 | */ |
||
| 138 | $passwordCreateEvent = new UserPasswordCreateEvent(UserPasswordCreateEvent::CREATE_PASSWORD, []); |
||
| 139 | $this->eventDispatcher->dispatch( |
||
| 140 | UserPasswordCreateEvent::CREATE_PASSWORD, $passwordCreateEvent); |
||
| 141 | $password = $passwordCreateEvent->getPassword(); |
||
| 142 | if ($password === false) { |
||
| 143 | $password = $this->secureRandom->generate(20); |
||
| 144 | } |
||
| 145 | } |
||
| 146 | $user = $this->userManager->createUser($username, $password); |
||
| 147 | } catch (\Exception $exception) { |
||
| 148 | $message = $exception->getMessage(); |
||
| 149 | if (!$message) { |
||
| 150 | $message = 'Unable to create user.'; |
||
| 151 | } |
||
| 152 | throw new CannotCreateUserException($message); |
||
| 153 | } |
||
| 154 | |||
| 155 | if ($user === null) { |
||
| 156 | throw new CannotCreateUserException('Unable to create user.'); |
||
| 157 | } |
||
| 158 | |||
| 159 | if ($groups !== null) { |
||
| 160 | foreach ($groups as $groupName) { |
||
| 161 | if ($groupName !== null) { |
||
| 162 | $group = $this->groupManager->get($groupName); |
||
| 163 | |||
| 164 | if (empty($group)) { |
||
| 165 | $group = $this->groupManager->createGroup($groupName); |
||
| 166 | } |
||
| 167 | $group->addUser($user); |
||
| 168 | $this->logger->info('Added userid ' . $user->getUID() . ' to group ' . $group->getGID()); |
||
| 169 | } |
||
| 170 | } |
||
| 171 | } |
||
| 172 | /** |
||
| 173 | * Send new user mail only if a mail is set |
||
| 174 | */ |
||
| 175 | if ($email !== '') { |
||
| 176 | $user->setEMailAddress($email); |
||
| 177 | try { |
||
| 178 | $this->userSendMail->generateTokenAndSendMail($username, $email); |
||
| 179 | } catch (\Exception $e) { |
||
| 180 | $this->logger->error("Can't send new user mail to $email: " . $e->getMessage(), ['app' => 'settings']); |
||
| 181 | } |
||
| 182 | } |
||
| 183 | |||
| 184 | return $user; |
||
| 185 | } |
||
| 186 | |||
| 201 | } |
Loading history...
Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: