Completed
Pull Request — master (#30188)
by Jörn Friedrich
29:05 queued 15:17
created
lib/private/Files/Cache/Wrapper/CacheJail.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 
75 75
 	/**
76 76
 	 * @param array $entry
77
-	 * @return array
77
+	 * @return string
78 78
 	 */
79 79
 	protected function formatCacheEntry($entry) {
80 80
 		if (isset($entry['path'])) {
@@ -193,6 +193,9 @@  discard block
 block discarded – undo
193 193
 		return $this->cache->getStatus($this->getSourcePath($file));
194 194
 	}
195 195
 
196
+	/**
197
+	 * @param \OCP\Files\Cache\ICacheEntry[] $results
198
+	 */
196 199
 	private function formatSearchResults($results) {
197 200
 		$results = \array_filter($results, [$this, 'filterCacheEntry']);
198 201
 		$results = \array_values($results);
Please login to merge, or discard this patch.
lib/private/Files/Node/Root.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 	 * @param string $path
176 176
 	 * @throws \OCP\Files\NotFoundException
177 177
 	 * @throws \OCP\Files\NotPermittedException
178
-	 * @return File|Folder
178
+	 * @return string
179 179
 	 */
180 180
 	public function get($path) {
181 181
 		$path = $this->normalizePath($path);
@@ -374,6 +374,9 @@  discard block
 block discarded – undo
374 374
 
375 375
 	}
376 376
 
377
+	/**
378
+	 * @param string $fullPath
379
+	 */
377 380
 	private function resolveVirtualNode($fullPath) {
378 381
 		$pieces = \explode('/', $fullPath);
379 382
 		if ($pieces[1] !== 'meta') {
Please login to merge, or discard this patch.
lib/private/Files/Stream/StaticStream.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -145,6 +145,9 @@
 block discarded – undo
145 145
 		return true;
146 146
 	}
147 147
 
148
+	/**
149
+	 * @param string $path
150
+	 */
148 151
 	public function url_stat($path) {
149 152
 		if (isset(self::$data[$path])) {
150 153
 			$size = \strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/Tags.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -742,11 +742,19 @@  discard block
 block discarded – undo
742 742
 	}
743 743
 
744 744
 	// case-insensitive array_search
745
+
746
+	/**
747
+	 * @param string $needle
748
+	 */
745 749
 	protected function array_searchi($needle, $haystack, $mem='getName') {
746 750
 		if(!\is_array($haystack)) {
747 751
 			return false;
748 752
 		}
749 753
 		return \array_search(\strtolower($needle), \array_map(
754
+
755
+			/**
756
+			 * @param string $tag
757
+			 */
750 758
 			function($tag) use($mem) {
751 759
 				return \strtolower(\call_user_func([$tag, $mem]));
752 760
 			}, $haystack)
@@ -771,7 +779,7 @@  discard block
 block discarded – undo
771 779
 	* Get a tag by its name.
772 780
 	*
773 781
 	* @param string $name The tag name.
774
-	* @return integer|bool The tag object's offset within the $this->tags
782
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
775 783
 	*                      array or false if it doesn't exist.
776 784
 	*/
777 785
 	private function getTagByName($name) {
@@ -782,7 +790,7 @@  discard block
 block discarded – undo
782 790
 	* Get a tag by its ID.
783 791
 	*
784 792
 	* @param string $id The tag ID to look for.
785
-	* @return integer|bool The tag object's offset within the $this->tags
793
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
786 794
 	*                      array or false if it doesn't exist.
787 795
 	*/
788 796
 	private function getTagById($id) {
Please login to merge, or discard this patch.
lib/private/Files/Utils/Scanner.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -170,7 +170,7 @@
 block discarded – undo
170 170
 	/**
171 171
 	 * Returns whether the given mount point should be scanned
172 172
 	 *
173
-	 * @param $mount mount point
173
+	 * @param \OC\Files\Mount\MountPoint|null $mount mount point
174 174
 	 * @return bool true to scan, false to skip
175 175
 	 */
176 176
 	private function shouldScan($mount) {
Please login to merge, or discard this patch.
lib/private/App/AppManager.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	/**
146 146
 	 * List all installed apps
147 147
 	 *
148
-	 * @return string[]
148
+	 * @return integer[]
149 149
 	 * @throws \Exception
150 150
 	 */
151 151
 	public function getInstalledApps() {
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 	/**
258 258
 	 * Do not allow more than one active app-theme
259 259
 	 *
260
-	 * @param $appId
260
+	 * @param string $appId
261 261
 	 * @throws AppNotFoundException
262 262
 	 * @throws \InvalidArgumentException
263 263
 	 * @throws \Exception
@@ -542,7 +542,7 @@  discard block
 block discarded – undo
542 542
 	}
543 543
 
544 544
 	/**
545
-	 * @param $appId
545
+	 * @param string $appId
546 546
 	 * @return bool
547 547
 	 * @throws \Exception
548 548
 	 */
@@ -578,7 +578,7 @@  discard block
 block discarded – undo
578 578
 	/**
579 579
 	 * @param string $package package path
580 580
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
581
-	 * @return string|false app id or false in case of error
581
+	 * @return integer app id or false in case of error
582 582
 	 * @since 10.0
583 583
 	 * @throws \Exception
584 584
 	 */
@@ -592,7 +592,7 @@  discard block
 block discarded – undo
592 592
 
593 593
 	/**
594 594
 	 * @param string $package
595
-	 * @return mixed
595
+	 * @return boolean
596 596
 	 * @since 10.0
597 597
 	 * @throws \Exception
598 598
 	 */
Please login to merge, or discard this patch.
lib/private/Share/MailNotifications.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -189,10 +189,10 @@
 block discarded – undo
189 189
 	 * inform recipient about public link share
190 190
 	 *
191 191
 	 * @param string $recipient recipient email address
192
-	 * @param string $filename the shared file
193
-	 * @param string $link the public link
194 192
 	 * @param array $options allows ['cc'] and ['bcc'] recipients
195
-	 * @param int $expiration expiration date (timestamp)
193
+	 * @param string $subject
194
+	 * @param boolean|string $htmlBody
195
+	 * @param boolean|string $textBody
196 196
 	 * @return string[] $result of failed recipients
197 197
 	 */
198 198
 	public function sendLinkShareMailFromBody($recipient, $subject, $htmlBody, $textBody, $options = []) {
Please login to merge, or discard this patch.
lib/private/legacy/template.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -322,6 +322,7 @@
 block discarded – undo
322 322
 		* @param string $error_msg The error message to show
323 323
 		* @param string $hint An optional hint message - needs to be properly escaped
324 324
 		* @param int HTTP Status Code
325
+		* @param integer $httpStatusCode
325 326
 		*/
326 327
 	public static function printErrorPage($error_msg, $hint = '', $httpStatusCode = null) {
327 328
 		if ($error_msg === $hint) {
Please login to merge, or discard this patch.
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -190,6 +190,7 @@
 block discarded – undo
190 190
 
191 191
 /**
192 192
  * @param string $path
193
+ * @param string $token
193 194
  */
194 195
 function publicPreview_icon ($path, $token) {
195 196
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_public_preview', ['x' => 32, 'y' => 32, 'file' => $path, 't' => $token]);
Please login to merge, or discard this patch.