Completed
Pull Request — master (#29513)
by Semih Serhat
14:42 queued 06:09
created
lib/private/Encryption/Util.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use OC\Files\Filesystem;
32 32
 use OC\Files\View;
33 33
 use OCP\Encryption\IEncryptionModule;
34
-use OCP\Files\Storage;
35 34
 use OCP\IConfig;
36 35
 use OCP\IUser;
37 36
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/SharesPlugin.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,6 @@
 block discarded – undo
68 68
 	/**
69 69
 	 * @param \Sabre\DAV\Tree $tree tree
70 70
 	 * @param IUserSession $userSession user session
71
-	 * @param \OCP\Files\Folder $userFolder user home folder
72 71
 	 * @param \OCP\Share\IManager $shareManager share manager
73 72
 	 */
74 73
 	public function __construct(
Please login to merge, or discard this patch.
apps/files_sharing/lib/Controller/ShareesController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
 	 * split user and remote from federated cloud id
359 359
 	 *
360 360
 	 * @param string $address federated share address
361
-	 * @return array [user, remoteURL]
361
+	 * @return string[] [user, remoteURL]
362 362
 	 * @throws \Exception
363 363
 	 */
364 364
 	public function splitUserRemote($address) {
@@ -567,7 +567,7 @@  discard block
 block discarded – undo
567 567
 	 * trusted domain entries
568 568
 	 *
569 569
 	 * @param string $target target
570
-	 * @return true if one match was found, false otherwise
570
+	 * @return boolean if one match was found, false otherwise
571 571
 	 */
572 572
 	protected function isInstanceDomain($target) {
573 573
 		if (strpos($target, '/') !== false) {
Please login to merge, or discard this patch.
lib/private/User/RemoteUser.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 namespace OC\User;
24 24
 
25 25
 
26
-use OCP\IImage;
27 26
 use OCP\IUser;
28 27
 
29 28
 /**
Please login to merge, or discard this patch.
apps/dav/lib/Avatars/RootCollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace OCA\DAV\Avatars;
4 4
 
5 5
 use Sabre\DAVACL\AbstractPrincipalCollection;
6
-use Sabre\DAVACL\IPrincipal;
7 6
 
8 7
 class RootCollection extends AbstractPrincipalCollection {
9 8
 
Please login to merge, or discard this patch.
lib/private/User/Manager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -381,6 +381,9 @@
 block discarded – undo
381 381
 		return $account;
382 382
 	}
383 383
 
384
+	/**
385
+	 * @param string $backendClass
386
+	 */
384 387
 	public function getBackend($backendClass) {
385 388
 		if (isset($this->backends[$backendClass])) {
386 389
 			return $this->backends[$backendClass];
Please login to merge, or discard this patch.
lib/private/DB/Migrator.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -235,6 +235,10 @@
 block discarded – undo
235 235
 		return '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
236 236
 	}
237 237
 
238
+	/**
239
+	 * @param integer $step
240
+	 * @param integer $max
241
+	 */
238 242
 	protected function emit($sql, $step, $max) {
239 243
 		if ($this->noEmit) {
240 244
 			return;
Please login to merge, or discard this patch.
lib/private/Share20/DefaultShareProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1051,7 +1051,7 @@
 block discarded – undo
1051 1051
 	/**
1052 1052
 	 * Check whether the share object fits the expectations of this provider
1053 1053
 	 *
1054
-	 * @param IShare $share share
1054
+	 * @param \OCP\Share\IShare $share share
1055 1055
 	 *
1056 1056
 	 * @throws InvalidArgumentException if the share validation failed
1057 1057
 	 */
Please login to merge, or discard this patch.
lib/private/Files/Stream/Checksum.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
 
65 65
 
66 66
 	/**
67
-	 * @param $source
68
-	 * @param $path
67
+	 * @param resource $source
68
+	 * @param string $path
69 69
 	 * @return resource
70 70
 	 */
71 71
 	public static function wrap($source, $path) {
@@ -126,6 +126,9 @@  discard block
 block discarded – undo
126 126
 		return parent::stream_write($data);
127 127
 	}
128 128
 
129
+	/**
130
+	 * @param string $data
131
+	 */
129 132
 	private function updateHashingContexts($data) {
130 133
 		foreach ($this->hashingContexts as $ctx) {
131 134
 			hash_update($ctx, $data);
@@ -194,7 +197,7 @@  discard block
 block discarded – undo
194 197
 	}
195 198
 
196 199
 	/**
197
-	 * @return mixed
200
+	 * @return string
198 201
 	 * @return string
199 202
 	 */
200 203
 	private function getPathFromStreamContext() {
Please login to merge, or discard this patch.