owncloud / core

lib/private/Lock/Persistent/Lock.php

Doc Comments +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
 	/**
 	 * Unix timestamp when lock was created
 	 *
-	 * @return mixed
+	 * @return integer
 	 * @since 11.0.0
 	 */
 	public function getCreatedAt(): int {

core/Controller/LostController.php

Doc Comments +2 added lines, -2 removed lines

@@ -181,7 +181,7 @@ 
 	}
 
 	/**
-	 * @param $message
+	 * @param string $message
 	 * @param array $additional
 	 * @return array
 	 */
@@ -281,7 +281,7 @@ 
 
 	/**
 	 * @param string $userId
-	 * @return array
+	 * @return string[]
 	 */
 	public function generateTokenAndLink($userId) {
 		$token = $this->secureRandom->generate(21,

lib/private/Files/Filesystem.php

Doc Comments +26 added lines, -2 removed lines

@@ -359,6 +359,10 @@ 
 		}
 	}
 
+	/**
+	 * @param string|boolean $user
+	 * @param string $root
+	 */
 	public static function init($user, $root) {
 		if (self::$defaultInstance) {
 			return false;
@@ -517,7 +521,7 @@ 
 	/**
 	 * mount an \OC\Files\Storage\Storage in our virtual filesystem
 	 *
-	 * @param \OC\Files\Storage\Storage|string $class
+	 * @param string $class
 	 * @param array $arguments
 	 * @param string $mountpoint
 	 */
@@ -690,6 +694,9 @@ 
 		return self::$defaultInstance->is_dir($path);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function is_file($path) {
 		return self::$defaultInstance->is_file($path);
 	}
@@ -702,6 +709,9 @@ 
 		return self::$defaultInstance->filetype($path);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function filesize($path) {
 		return self::$defaultInstance->filesize($path);
 	}
@@ -714,6 +724,9 @@ 
 		return self::$defaultInstance->isCreatable($path);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function isReadable($path) {
 		return self::$defaultInstance->isReadable($path);
 	}
@@ -743,6 +756,7 @@ 
 	}
 
 	/**
+	 * @param string $path
 	 * @return string
 	 */
 	public static function file_get_contents($path) {
@@ -765,6 +779,10 @@ 
 		return self::$defaultInstance->copy($path1, $path2);
 	}
 
+	/**
+	 * @param string $path
+	 * @param string $mode
+	 */
 	public static function fopen($path, $mode) {
 		return self::$defaultInstance->fopen($path, $mode);
 	}
@@ -780,6 +798,9 @@ 
 		return self::$defaultInstance->fromTmpFile($tmpFile, $path);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function getMimeType($path) {
 		return self::$defaultInstance->getMimeType($path);
 	}
@@ -792,6 +813,9 @@ 
 		return self::$defaultInstance->free_space($path);
 	}
 
+	/**
+	 * @param string $query
+	 */
 	public static function search($query) {
 		return self::$defaultInstance->search($query);
 	}
@@ -901,7 +925,7 @@ 
 	 * @param string $path
 	 * @param boolean $includeMountPoints whether to add mountpoint sizes,
 	 * defaults to true
-	 * @return \OC\Files\FileInfo|bool False if file does not exist
+	 * @return \OCP\Files\FileInfo|null False if file does not exist
 	 */
 	public static function getFileInfo($path, $includeMountPoints = true) {
 		return self::$defaultInstance->getFileInfo($path, $includeMountPoints);

lib/public/Util.php

Doc Comments +1 added lines, -1 removed lines

@@ -657,7 +657,7 @@
 	/**
 	 * Determine if the string is, strictly-speaking, empty or not
 	 *
-	 * @param $value
+	 * @param string $value
 	 * @return bool
 	 * @since 10.0.1
 	 */

apps/dav/lib/CardDAV/CardDavBackend.php

Doc Comments +7 added lines, -2 removed lines

@@ -223,7 +223,8 @@ 
 	}
 
 	/**
-	 * @param $addressBookUri
+	 * @param string $addressBookUri
+	 * @param string $principal
 	 * @return array|null
 	 */
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -912,6 +913,7 @@ 
 	 *   * readOnly - boolean
 	 *   * summary - Optional, a description for the share
 	 *
+	 * @param integer $addressBookId
 	 * @return array
 	 */
 	public function getShares($addressBookId) {
@@ -1017,7 +1019,7 @@ 
 
 	/**
 	 * For shared address books the sharee is set in the ACL of the address book
-	 * @param $addressBookId
+	 * @param integer $addressBookId
 	 * @param $acl
 	 * @return array
 	 */
@@ -1025,6 +1027,9 @@ 
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2 = null) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = \Sabre\Uri\split($principalUri);

core/Command/Db/Migrations/GenerateCommand.php

Doc Comments +3 added lines

@@ -146,6 +146,9 @@
 		return $path;
 	}
 
+	/**
+	 * @param string $kind
+	 */
 	private function getTemplate($kind) {
 		if ($kind === 'simple') {
 			return self::$_templateSimple;

core/Command/Encryption/ChangeKeyStorageRoot.php

Doc Comments +1 added lines, -1 removed lines

@@ -246,7 +246,7 @@
 	/**
 	 * check if target already exists
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 * @throws \Exception
 	 */

core/Command/User/ResetPassword.php

Unused Use Statements -5 removed lines

@@ -32,12 +32,7 @@
 use OC\Helper\EnvironmentHelper;
 use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\IConfig;
-use OCP\IL10N;
-use OCP\IURLGenerator;
 use OCP\IUserManager;
-use OCP\Mail\IMailer;
-use OCP\Security\ISecureRandom;
-use OCP\Util;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputArgument;

lib/private/AppFramework/DependencyInjection/DIContainer.php

Unused Use Statements -1 removed lines

@@ -31,7 +31,6 @@
 namespace OC\AppFramework\DependencyInjection;
 
 use OC;
-use OC\AppFramework\Core\API;
 use OC\AppFramework\Http;
 use OC\AppFramework\Http\Dispatcher;
 use OC\AppFramework\Http\Output;