Completed
Pull Request — master (#24661)
by Joas
49:47
created
apps/dav/lib/DAV/SystemPrincipalBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Files/BrowserErrorPagePlugin.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -86,8 +86,6 @@
 block discarded – undo
86 86
 
87 87
 	/**
88 88
 	 * @codeCoverageIgnore
89
-	 * @param \Exception $ex
90
-	 * @param int $httpCode
91 89
 	 * @return bool|string
92 90
 	 */
93 91
 	public function generateBody(\Exception $exception) {
Please login to merge, or discard this patch.
apps/dav/lib/Server.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 namespace OCA\DAV;
24 24
 
25 25
 use OCA\DAV\CalDAV\Schedule\IMipPlugin;
26
-use OCA\DAV\Connector\FedAuth;
27 26
 use OCA\DAV\Connector\Sabre\Auth;
28 27
 use OCA\DAV\Connector\Sabre\BlockLegacyClientPlugin;
29 28
 use OCA\DAV\Files\CustomPropertiesBackend;
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsByIdCollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsObjectMappingCollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsObjectTypeCollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
apps/dav/lib/Upload/AssemblyStream.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
 	/**
102 102
 	 * @param string $data
103
-	 * @return int
103
+	 * @return boolean
104 104
 	 */
105 105
 	public function stream_write($data) {
106 106
 		return false;
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	}
207 207
 
208 208
 	/**
209
-	 * @param $pos
209
+	 * @param integer $pos
210 210
 	 * @return IFile | null
211 211
 	 */
212 212
 	private function getNodeForPosition($pos) {
Please login to merge, or discard this patch.
lib/private/User/Session.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 	/**
190 190
 	 * get the current active user
191 191
 	 *
192
-	 * @return IUser|null Current user, otherwise null
192
+	 * @return null|User Current user, otherwise null
193 193
 	 */
194 194
 	public function getUser() {
195 195
 		// FIXME: This is a quick'n dirty work-around for the incognito mode as
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
 	 *
295 295
 	 * @param string $uid
296 296
 	 * @param string $password
297
-	 * @return boolean|null
297
+	 * @return boolean
298 298
 	 * @throws LoginException
299 299
 	 */
300 300
 	public function login($uid, $password) {
@@ -368,6 +368,9 @@  discard block
 block discarded – undo
368 368
 		return false;
369 369
 	}
370 370
 
371
+	/**
372
+	 * @param string $uid
373
+	 */
371 374
 	private function loginWithToken($uid) {
372 375
 		// TODO: $this->manager->emit('\OC\User', 'preTokenLogin', array($uid));
373 376
 		$user = $this->manager->get($uid);
Please login to merge, or discard this patch.
apps/files_trashbin/lib/BackgroundJob/ExpireTrash.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  */
21 21
 
22 22
 use OC\Share\MailNotifications;
23
-use OCP\IConfig;
24 23
 use OCP\IL10N;
25 24
 use OCP\IUser;
26 25
 use OCP\Mail\IMailer;
Please login to merge, or discard this patch.