Completed
Pull Request — master (#32767)
by Sujith
11:23
created
core/Controller/LostController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 	}
182 182
 
183 183
 	/**
184
-	 * @param $message
184
+	 * @param string $message
185 185
 	 * @param array $additional
186 186
 	 * @return array
187 187
 	 */
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
 
282 282
 	/**
283 283
 	 * @param string $userId
284
-	 * @return array
284
+	 * @return string[]
285 285
 	 */
286 286
 	public function generateTokenAndLink($userId) {
287 287
 		$token = $this->secureRandom->generate(21,
Please login to merge, or discard this patch.
lib/private/Files/Filesystem.php 1 patch
Doc Comments   +26 added lines, -2 removed lines patch added patch discarded remove patch
@@ -359,6 +359,10 @@  discard block
 block discarded – undo
359 359
 		}
360 360
 	}
361 361
 
362
+	/**
363
+	 * @param string|boolean $user
364
+	 * @param string $root
365
+	 */
362 366
 	public static function init($user, $root) {
363 367
 		if (self::$defaultInstance) {
364 368
 			return false;
@@ -517,7 +521,7 @@  discard block
 block discarded – undo
517 521
 	/**
518 522
 	 * mount an \OC\Files\Storage\Storage in our virtual filesystem
519 523
 	 *
520
-	 * @param \OC\Files\Storage\Storage|string $class
524
+	 * @param string $class
521 525
 	 * @param array $arguments
522 526
 	 * @param string $mountpoint
523 527
 	 */
@@ -690,6 +694,9 @@  discard block
 block discarded – undo
690 694
 		return self::$defaultInstance->is_dir($path);
691 695
 	}
692 696
 
697
+	/**
698
+	 * @param string $path
699
+	 */
693 700
 	public static function is_file($path) {
694 701
 		return self::$defaultInstance->is_file($path);
695 702
 	}
@@ -702,6 +709,9 @@  discard block
 block discarded – undo
702 709
 		return self::$defaultInstance->filetype($path);
703 710
 	}
704 711
 
712
+	/**
713
+	 * @param string $path
714
+	 */
705 715
 	public static function filesize($path) {
706 716
 		return self::$defaultInstance->filesize($path);
707 717
 	}
@@ -714,6 +724,9 @@  discard block
 block discarded – undo
714 724
 		return self::$defaultInstance->isCreatable($path);
715 725
 	}
716 726
 
727
+	/**
728
+	 * @param string $path
729
+	 */
717 730
 	public static function isReadable($path) {
718 731
 		return self::$defaultInstance->isReadable($path);
719 732
 	}
@@ -743,6 +756,7 @@  discard block
 block discarded – undo
743 756
 	}
744 757
 
745 758
 	/**
759
+	 * @param string $path
746 760
 	 * @return string
747 761
 	 */
748 762
 	public static function file_get_contents($path) {
@@ -765,6 +779,10 @@  discard block
 block discarded – undo
765 779
 		return self::$defaultInstance->copy($path1, $path2);
766 780
 	}
767 781
 
782
+	/**
783
+	 * @param string $path
784
+	 * @param string $mode
785
+	 */
768 786
 	public static function fopen($path, $mode) {
769 787
 		return self::$defaultInstance->fopen($path, $mode);
770 788
 	}
@@ -780,6 +798,9 @@  discard block
 block discarded – undo
780 798
 		return self::$defaultInstance->fromTmpFile($tmpFile, $path);
781 799
 	}
782 800
 
801
+	/**
802
+	 * @param string $path
803
+	 */
783 804
 	public static function getMimeType($path) {
784 805
 		return self::$defaultInstance->getMimeType($path);
785 806
 	}
@@ -792,6 +813,9 @@  discard block
 block discarded – undo
792 813
 		return self::$defaultInstance->free_space($path);
793 814
 	}
794 815
 
816
+	/**
817
+	 * @param string $query
818
+	 */
795 819
 	public static function search($query) {
796 820
 		return self::$defaultInstance->search($query);
797 821
 	}
@@ -901,7 +925,7 @@  discard block
 block discarded – undo
901 925
 	 * @param string $path
902 926
 	 * @param boolean $includeMountPoints whether to add mountpoint sizes,
903 927
 	 * defaults to true
904
-	 * @return \OC\Files\FileInfo|bool False if file does not exist
928
+	 * @return \OCP\Files\FileInfo|null False if file does not exist
905 929
 	 */
906 930
 	public static function getFileInfo($path, $includeMountPoints = true) {
907 931
 		return self::$defaultInstance->getFileInfo($path, $includeMountPoints);
Please login to merge, or discard this patch.
lib/public/Util.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -657,7 +657,7 @@
 block discarded – undo
657 657
 	/**
658 658
 	 * Determine if the string is, strictly-speaking, empty or not
659 659
 	 *
660
-	 * @param $value
660
+	 * @param string $value
661 661
 	 * @return bool
662 662
 	 * @since 10.0.1
663 663
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,7 +223,8 @@  discard block
 block discarded – undo
223 223
 	}
224 224
 
225 225
 	/**
226
-	 * @param $addressBookUri
226
+	 * @param string $addressBookUri
227
+	 * @param string $principal
227 228
 	 * @return array|null
228 229
 	 */
229 230
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -912,6 +913,7 @@  discard block
 block discarded – undo
912 913
 	 *   * readOnly - boolean
913 914
 	 *   * summary - Optional, a description for the share
914 915
 	 *
916
+	 * @param integer $addressBookId
915 917
 	 * @return array
916 918
 	 */
917 919
 	public function getShares($addressBookId) {
@@ -1017,7 +1019,7 @@  discard block
 block discarded – undo
1017 1019
 
1018 1020
 	/**
1019 1021
 	 * For shared address books the sharee is set in the ACL of the address book
1020
-	 * @param $addressBookId
1022
+	 * @param integer $addressBookId
1021 1023
 	 * @param $acl
1022 1024
 	 * @return array
1023 1025
 	 */
@@ -1025,6 +1027,9 @@  discard block
 block discarded – undo
1025 1027
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
1026 1028
 	}
1027 1029
 
1030
+	/**
1031
+	 * @param boolean $toV2
1032
+	 */
1028 1033
 	private function convertPrincipal($principalUri, $toV2 = null) {
1029 1034
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1030 1035
 			list(, $name) = \Sabre\Uri\split($principalUri);
Please login to merge, or discard this patch.
core/Command/Db/Migrations/GenerateCommand.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -146,6 +146,9 @@
 block discarded – undo
146 146
 		return $path;
147 147
 	}
148 148
 
149
+	/**
150
+	 * @param string $kind
151
+	 */
149 152
 	private function getTemplate($kind) {
150 153
 		if ($kind === 'simple') {
151 154
 			return self::$_templateSimple;
Please login to merge, or discard this patch.
core/Command/Encryption/ChangeKeyStorageRoot.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@
 block discarded – undo
246 246
 	/**
247 247
 	 * check if target already exists
248 248
 	 *
249
-	 * @param $path
249
+	 * @param string $path
250 250
 	 * @return bool
251 251
 	 * @throws \Exception
252 252
 	 */
Please login to merge, or discard this patch.
core/Command/User/ResetPassword.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -32,12 +32,7 @@
 block discarded – undo
32 32
 use OC\Helper\EnvironmentHelper;
33 33
 use OCP\AppFramework\Utility\ITimeFactory;
34 34
 use OCP\IConfig;
35
-use OCP\IL10N;
36
-use OCP\IURLGenerator;
37 35
 use OCP\IUserManager;
38
-use OCP\Mail\IMailer;
39
-use OCP\Security\ISecureRandom;
40
-use OCP\Util;
41 36
 use Symfony\Component\Console\Command\Command;
42 37
 use Symfony\Component\Console\Input\InputInterface;
43 38
 use Symfony\Component\Console\Input\InputArgument;
Please login to merge, or discard this patch.
lib/private/AppFramework/DependencyInjection/DIContainer.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 namespace OC\AppFramework\DependencyInjection;
32 32
 
33 33
 use OC;
34
-use OC\AppFramework\Core\API;
35 34
 use OC\AppFramework\Http;
36 35
 use OC\AppFramework\Http\Dispatcher;
37 36
 use OC\AppFramework\Http\Output;
Please login to merge, or discard this patch.
lib/private/Share/Share.php 1 patch
Unused Use Statements   -7 removed lines patch added patch discarded remove patch
@@ -42,14 +42,7 @@
 block discarded – undo
42 42
 namespace OC\Share;
43 43
 
44 44
 use OC\Files\Filesystem;
45
-use OC\Group\Group;
46
-use OCA\FederatedFileSharing\DiscoveryManager;
47
-use OCP\DB\QueryBuilder\IQueryBuilder;
48 45
 use OCP\IUser;
49
-use OCP\IUserSession;
50
-use OCP\IDBConnection;
51
-use OCP\IConfig;
52
-use Symfony\Component\EventDispatcher\GenericEvent;
53 46
 
54 47
 /**
55 48
  * This class provides the ability for apps to share their content between users.
Please login to merge, or discard this patch.