Completed
Pull Request — master (#32767)
by Sujith
11:23
created
apps/dav/lib/Connector/Sabre/LockPlugin.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use OCP\Lock\LockedException;
31 31
 use Sabre\DAV\Exception\Forbidden;
32 32
 use Sabre\DAV\Exception\NotFound;
33
-use Sabre\DAV\Exception\NotImplemented;
34 33
 use Sabre\DAV\Locks\LockInfo;
35 34
 use Sabre\DAV\ServerPlugin;
36 35
 use Sabre\HTTP\RequestInterface;
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/AutorenamePlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 	/**
60 60
 	 * @param RequestInterface $request
61 61
 	 * @param ResponseInterface $response
62
-	 * @return bool|void
62
+	 * @return null|false
63 63
 	 * @throws \Sabre\DAV\Exception\BadRequest
64 64
 	 * @throws \Sabre\DAV\Exception\Conflict
65 65
 	 * @throws \Sabre\DAV\Exception\NotFound
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -259,6 +259,9 @@  discard block
 block discarded – undo
259 259
 
260 260
 	/**
261 261
 	 *
262
+	 * @param string $targetFilename
263
+	 * @param string $targetLocation
264
+	 * @param integer $timestamp
262 265
 	 */
263 266
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
264 267
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -784,7 +787,7 @@  discard block
 block discarded – undo
784 787
 	 * if the size limit for the trash bin is reached, we delete the oldest
785 788
 	 * files in the trash bin until we meet the limit again
786 789
 	 *
787
-	 * @param array $files
790
+	 * @param \OCP\Files\FileInfo[] $files
788 791
 	 * @param string $user
789 792
 	 * @param int $availableSpace available disc space
790 793
 	 * @return int size of deleted files
@@ -818,7 +821,7 @@  discard block
 block discarded – undo
818 821
 	/**
819 822
 	 * delete files older then max storage time
820 823
 	 *
821
-	 * @param array $files list of files sorted by mtime
824
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
822 825
 	 * @param string $user
823 826
 	 * @return integer[] size of deleted files and number of deleted files
824 827
 	 */
@@ -888,6 +891,7 @@  discard block
 block discarded – undo
888 891
 	 *
889 892
 	 * @param string $filename name of the file which should be restored
890 893
 	 * @param int $timestamp timestamp when the file was deleted
894
+	 * @param string|boolean $user
891 895
 	 * @return array
892 896
 	 */
893 897
 	private static function getVersionsFromTrash($filename, $timestamp, $user) {
Please login to merge, or discard this patch.
lib/private/Files/Storage/Common.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -708,7 +708,7 @@
 block discarded – undo
708 708
 	}
709 709
 
710 710
 	/**
711
-	 * @param $internalPath
711
+	 * @param string $internalPath
712 712
 	 * @return array
713 713
 	 */
714 714
 	public function convertInternalPathToGlobalPath($internalPath) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/Auth.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -255,7 +255,7 @@
 block discarded – undo
255 255
 	}
256 256
 
257 257
 	/**
258
-	 * @param $user
258
+	 * @param \OCP\IUser|null $user
259 259
 	 * @throws ServiceUnavailable
260 260
 	 */
261 261
 	private function checkAccountModule($user) {
Please login to merge, or discard this patch.
apps/files_versions/lib/Storage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -315,6 +315,9 @@
 block discarded – undo
315 315
 		}
316 316
 	}
317 317
 
318
+	/**
319
+	 * @param string $revision
320
+	 */
318 321
 	public static function restoreVersion($uid, $filename, $fileToRestore, $revision) {
319 322
 		if (\OC::$server->getConfig()->getSystemValue('files_versions', Storage::DEFAULTENABLED) !== true) {
320 323
 			return false;
Please login to merge, or discard this patch.
lib/private/Files/Storage/FailedStorage.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 namespace OC\Files\Storage;
25 25
 
26 26
 use OC\Files\Cache\FailedCache;
27
-use OCP\Files\Storage\IStorage;
28 27
 use \OCP\Lock\ILockingProvider;
29 28
 use \OCP\Files\StorageNotAvailableException;
30 29
 
Please login to merge, or discard this patch.
lib/private/Files/Storage/Local.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,6 @@
 block discarded – undo
37 37
 namespace OC\Files\Storage;
38 38
 
39 39
 use OCP\Files\ForbiddenException;
40
-use OCP\Files\Storage\IStorage;
41 40
 
42 41
 /**
43 42
  * for local filestore, we only have to map the paths
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/FederatedShareProvider.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
 	/**
395 395
 	 * store remote ID in federated reShare table
396 396
 	 *
397
-	 * @param $shareId
397
+	 * @param integer $shareId
398 398
 	 * @param $remoteId
399 399
 	 */
400 400
 	public function storeRemoteId($shareId, $remoteId) {
@@ -801,7 +801,7 @@  discard block
 block discarded – undo
801 801
 	/**
802 802
 	 * get database row of a give share
803 803
 	 *
804
-	 * @param $id
804
+	 * @param integer $id
805 805
 	 * @return array
806 806
 	 * @throws ShareNotFound
807 807
 	 */
@@ -1001,12 +1001,12 @@  discard block
 block discarded – undo
1001 1001
 	}
1002 1002
 
1003 1003
 	/**
1004
-	 * @param $remote
1005
-	 * @param $token
1006
-	 * @param $name
1007
-	 * @param $owner
1008
-	 * @param $shareWith
1009
-	 * @param $remoteId
1004
+	 * @param string $remote
1005
+	 * @param string $token
1006
+	 * @param string $name
1007
+	 * @param string $owner
1008
+	 * @param string $shareWith
1009
+	 * @param integer $remoteId
1010 1010
 	 *
1011 1011
 	 * @return int
1012 1012
 	 */
Please login to merge, or discard this patch.