Completed
Pull Request — master (#28166)
by Jörn Friedrich
12:44
created
lib/private/App/AppManager.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	/**
123 123
 	 * List all installed apps
124 124
 	 *
125
-	 * @return string[]
125
+	 * @return integer[]
126 126
 	 */
127 127
 	public function getInstalledApps() {
128 128
 		return array_keys($this->getInstalledAppsValues());
@@ -355,6 +355,9 @@  discard block
 block discarded – undo
355 355
 		return in_array($appId, $this->shippedApps);
356 356
 	}
357 357
 
358
+	/**
359
+	 * @param string $appId
360
+	 */
358 361
 	private function isAlwaysEnabled($appId) {
359 362
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
360 363
 		return in_array($appId, $alwaysEnabled);
@@ -383,7 +386,7 @@  discard block
 block discarded – undo
383 386
 	/**
384 387
 	 * @param string $package package path
385 388
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
386
-	 * @return string|false app id or false in case of error
389
+	 * @return integer app id or false in case of error
387 390
 	 * @since 10.0
388 391
 	 */
389 392
 	public function installApp($package, $skipMigrations = false) {
@@ -400,7 +403,7 @@  discard block
 block discarded – undo
400 403
 
401 404
 	/**
402 405
 	 * @param string $package
403
-	 * @return mixed
406
+	 * @return boolean
404 407
 	 * @since 10.0
405 408
 	 */
406 409
 	public function updateApp($package) {
Please login to merge, or discard this patch.
lib/private/Files/Cache/Scanner.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -391,6 +391,13 @@  discard block
 block discarded – undo
391 391
 		return $size;
392 392
 	}
393 393
 
394
+	/**
395
+	 * @param string $path
396
+	 * @param boolean $recursive
397
+	 * @param integer $reuse
398
+	 * @param boolean $lock
399
+	 * @param integer $size
400
+	 */
394 401
 	private function handleChildren($path, $recursive, $reuse, $folderId, $lock, &$size) {
395 402
 		// we put this in it's own function so it cleans up the memory before we start recursing
396 403
 		$existingChildren = $this->getExistingChildren($folderId);
@@ -490,6 +497,9 @@  discard block
 block discarded – undo
490 497
 		}
491 498
 	}
492 499
 
500
+	/**
501
+	 * @param string|boolean $path
502
+	 */
493 503
 	private function runBackgroundScanJob(callable $callback, $path) {
494 504
 		try {
495 505
 			$callback();
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	 *
73 73
 	 * @param Account $account
74 74
 	 * @param AccountMapper $mapper
75
-	 * @param null $emitter
75
+	 * @param Manager $emitter
76 76
 	 * @param IConfig|null $config
77 77
 	 * @param null $urlGenerator
78 78
 	 * @param EventDispatcher|null $eventDispatcher
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 	/**
98 98
 	 * get the user id
99 99
 	 *
100
-	 * @return string
100
+	 * @return integer
101 101
 	 */
102 102
 	public function getUID() {
103 103
 		return $this->account->getUserId();
@@ -433,6 +433,10 @@  discard block
 block discarded – undo
433 433
 		return $url;
434 434
 	}
435 435
 
436
+	/**
437
+	 * @param string $feature
438
+	 * @param string $value
439
+	 */
436 440
 	public function triggerChange($feature, $value = null) {
437 441
 		if ($this->emitter && in_array($feature, $this->account->getUpdatedFields())) {
438 442
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);
Please login to merge, or discard this patch.
lib/private/Files/Type/Loader.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 use OC\Files\Cache\Cache;
25 25
 use OCP\Files\IMimeTypeLoader;
26 26
 use OCP\IDBConnection;
27
-
28 27
 use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
29 28
 
30 29
 /**
Please login to merge, or discard this patch.