owncloud / core

settings/Application.php

Unused Use Statements -2 removed lines

@@ -31,10 +31,8 @@
 
 namespace OC\Settings;
 
-use OC\Files\View;
 use OC\Server;
 use OC\AppFramework\Utility\TimeFactory;
-use OC\Settings\Controller\CorsController;
 use OC\Settings\Controller\SettingsPageController;
 use OC\Settings\Controller\AppSettingsController;
 use OC\Settings\Controller\AuthSettingsController;

settings/Controller/CorsController.php

Doc Comments -1 removed lines

@@ -131,7 +131,6 @@
 	/**
 	 * Removes a WhiteListed Domain
 	 *
-	 * @param string $domain Domain to remove
 	 * @return RedirectResponse Redirection to the settings page.
 	 */
 	public function removeDomain($id) {

apps/dav/lib/Connector/Sabre/CorsPlugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
 	 * @param RequestInterface $request
 	 * @param ResponseInterface $response
 	 *
-	 * @return false
+	 * @return false|null
 	 */
 	public function setOptionsRequestHeaders(RequestInterface $request, ResponseInterface $response) {
 		$authorization = $request->getHeader('Authorization');

apps/files_sharing/lib/API/Remote.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 namespace OCA\Files_Sharing\API;
 
 use OC\Files\Filesystem;
-use OCA\FederatedFileSharing\DiscoveryManager;
 use OCA\Files_Sharing\External\Manager;
 use Symfony\Component\EventDispatcher\GenericEvent;
 

lib/private/AppFramework/Middleware/Security/CORSMiddleware.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 
 use OC\AppFramework\Middleware\Security\Exceptions\SecurityException;
 use OC\AppFramework\Utility\ControllerMethodReflector;
-use OC\Authentication\Exceptions\PasswordLoginForbiddenException;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\JSONResponse;

apps/files_trashbin/lib/Trashbin.php

Doc Comments +6 added lines, -2 removed lines

@@ -218,6 +218,9 @@ 
 
 	/**
 	 *
+	 * @param string $targetFilename
+	 * @param string $targetLocation
+	 * @param integer $timestamp
 	 */
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -330,6 +333,7 @@ 
 	 * @param string $ownerPath path relative to the owner's home storage
 	 * @param integer $timestamp when the file was deleted
 	 * @param bool $forceCopy true to only make a copy of the versions into the trashbin
+	 * @param \OC\Files\Storage\Storage $sourceStorage
 	 */
 	private static function retainVersions($filename, $owner, $ownerPath, $timestamp, $sourceStorage = null, $forceCopy = false) {
 		if (\OCP\App::isEnabled('files_versions') && !empty($ownerPath)) {
@@ -780,7 +784,7 @@ 
 	 * if the size limit for the trash bin is reached, we delete the oldest
 	 * files in the trash bin until we meet the limit again
 	 *
-	 * @param array $files
+	 * @param \OCP\Files\FileInfo[] $files
 	 * @param string $user
 	 * @param int $availableSpace available disc space
 	 * @return int size of deleted files
@@ -808,7 +812,7 @@ 
 	/**
 	 * delete files older then max storage time
 	 *
-	 * @param array $files list of files sorted by mtime
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
 	 * @param string $user
 	 * @return integer[] size of deleted files and number of deleted files
 	 */

core/Command/Security/ListRoutes.php

Doc Comments +3 added lines

@@ -122,6 +122,9 @@
 		}
 	}
 
+	/**
+	 * @param integer $name
+	 */
 	private function buildController($name) {
 		$parts = explode('.', $name);
 		if (count($parts) === 4 && $parts[0] === 'ocs') {

lib/private/Repair/RepairMismatchFileCachePath.php

Doc Comments +14 added lines, -1 removed lines

@@ -97,7 +97,7 @@ 
 	 * @param string $wrongPath wrong path of the entry to fix
 	 * @param int $correctStorageNumericId numeric idea of the correct storage
 	 * @param string $correctPath value to which to set the path of the entry 
-	 * @return bool true for success
+	 * @return boolean|null true for success
 	 */
 	private function fixEntryPath(IOutput $out, $fileId, $wrongPath, $correctStorageNumericId, $correctPath) {
 		// delete target if exists
@@ -122,6 +122,9 @@ 
 		$out->advance(1, $text);
 	}
 
+	/**
+	 * @param IQueryBuilder $qb
+	 */
 	private function addQueryConditionsParentIdWrongPath($qb) {
 		// thanks, VicDeo!
 		if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
@@ -161,6 +164,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IQueryBuilder $qb
+	 */
 	private function addQueryConditionsNonExistingParentIdEntry($qb, $storageNumericId = null) {
 		// Subquery for parent existence
 		$qbe = $this->connection->getQueryBuilder();
@@ -190,6 +196,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessParentIdWrongPath($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -200,6 +209,9 @@ 
 		return $count;
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessNonExistingParentIdEntry($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -350,6 +362,7 @@ 
 	 *
 	 * @param int $storageId storage id
 	 * @param string $path path for which to create the parent entry
+	 * @param integer $reuseFileId
 	 * @return int file id of the newly created parent
 	 */
 	private function getOrCreateEntry($storageId, $path, $reuseFileId = null) {

Unused Use Statements -2 removed lines

@@ -21,8 +21,6 @@
 
 namespace OC\Repair;
 
-use Doctrine\DBAL\Platforms\PostgreSqlPlatform;
-use OCP\DB\QueryBuilder\IQueryBuilder;
 use OCP\Migration\IOutput;
 use OCP\Migration\IRepairStep;
 use Doctrine\DBAL\Platforms\MySqlPlatform;

lib/private/Files/Storage/Wrapper/Encryption.php

Doc Comments +2 added lines, -2 removed lines

@@ -651,7 +651,7 @@ 
 	 * Set the flag to true, so that the file would be
 	 * in the decrypted state.
 	 *
-	 * @param $isDisabled bool
+	 * @param boolean $isDisabled bool
 	 */
 	public static function setDisableWriteEncryption($isDisabled) {
 		self::$disableWriteEncryption = $isDisabled;
@@ -1043,7 +1043,7 @@ 
 	/**
 	 * check if path points to a files version
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function isVersion($path) {