owncloud / core

lib/private/Share20/Manager.php

Unused Use Statements -2 removed lines

@@ -25,7 +25,6 @@ 
 use OCP\IUserManager;
 use OCP\Share\IManager;
 use OCP\Share\IProviderFactory;
-use OC\Share20\Exception\BackendError;
 use OCP\IConfig;
 use OCP\IL10N;
 use OCP\ILogger;
@@ -35,7 +34,6 @@ 
 use OCP\IGroupManager;
 use OCP\Files\File;
 use OCP\Files\Folder;
-
 use OCP\Share\Exceptions\ShareNotFound;
 use OCP\Share\Exceptions\GenericShareException;
 

apps/dav/lib/files/browsererrorpageplugin.php

Doc Comments -2 removed lines

@@ -86,8 +86,6 @@
 
 	/**
 	 * @codeCoverageIgnore
-	 * @param \Exception $ex
-	 * @param int $httpCode
 	 * @return bool|string
 	 */
 	public function generateBody(\Exception $exception) {

lib/public/appframework/db/mapper.php

Doc Comments +2 added lines, -1 removed lines

@@ -308,6 +308,7 @@ 
 	 * @param array $params the parameters of the sql query
 	 * @param int $limit the maximum number of rows
 	 * @param int $offset from which row we want to start
+	 * @param string $msg
 	 * @return string formatted error message string
 	 * @since 9.1.0
 	 */
@@ -360,7 +361,7 @@ 
 	 * Returns an db result and throws exceptions when there are more or less
 	 * results
 	 * @param string $sql the sql query
-	 * @param array $params the parameters of the sql query
+	 * @param string[] $params the parameters of the sql query
 	 * @param int $limit the maximum number of rows
 	 * @param int $offset from which row we want to start
 	 * @throws DoesNotExistException if the item does not exist

core/Command/Security/ListCertificates.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ListCertificates extends Base {

core/Controller/LostController.php

Doc Comments +1 added lines, -1 removed lines

@@ -131,7 +131,7 @@
 	}
 
 	/**
-	 * @param $message
+	 * @param string $message
 	 * @param array $additional
 	 * @return array
 	 */

settings/Controller/AppSettingsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
 	}
 
 	/**
-	 * @param string|int $category
+	 * @param string $category
 	 * @return int
 	 */
 	protected function getCategory($category) {

settings/Controller/CertificateController.php

Doc Comments +3 added lines, -3 removed lines

@@ -70,7 +70,7 @@ 
 	 *
 	 * @NoAdminRequired
 	 * @NoSubadminRequired
-	 * @return array
+	 * @return DataResponse
 	 */
 	public function addPersonalRootCertificate() {
 		return $this->addCertificate($this->userCertificateManager);
@@ -80,7 +80,7 @@ 
 	 * Add a new root certificate to a trust store
 	 *
 	 * @param ICertificateManager $certificateManager
-	 * @return array
+	 * @return DataResponse
 	 */
 	private function addCertificate(ICertificateManager $certificateManager) {
 		$headers = [];
@@ -158,7 +158,7 @@ 
 	/**
 	 * Add a new personal root certificate to the system's trust store
 	 *
-	 * @return array
+	 * @return DataResponse
 	 */
 	public function addSystemRootCertificate() {
 		return $this->addCertificate($this->systemCertificateManager);

settings/Controller/CheckSetupController.php

Doc Comments +1 added lines, -1 removed lines

@@ -268,7 +268,7 @@
 
 	/**
 	 * @NoCSRFRequired
-	 * @return DataResponse
+	 * @return DataDisplayResponse
 	 */
 	public function getFailedIntegrityCheckFiles() {
 		$completeResults = $this->checker->getResults();

lib/private/App/AppManager.php

Doc Comments +5 added lines, -2 removed lines

@@ -88,7 +88,7 @@ 
 	/**
 	 * List all installed apps
 	 *
-	 * @return string[]
+	 * @return integer[]
 	 */
 	public function getInstalledApps() {
 		return array_keys($this->getInstalledAppsValues());
@@ -216,7 +216,7 @@ 
 	/**
 	 * Returns a list of apps that need upgrade
 	 *
-	 * @param array $version ownCloud version as array of version components
+	 * @param array $ocVersion ownCloud version as array of version components
 	 * @return array list of app info from apps that need an upgrade
 	 *
 	 * @internal
@@ -289,6 +289,9 @@ 
 		return in_array($appId, $this->shippedApps);
 	}
 
+	/**
+	 * @param string $appId
+	 */
 	private function isAlwaysEnabled($appId) {
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
 		return in_array($appId, $alwaysEnabled);