Completed
Pull Request — master (#28250)
by Thomas
10:37
created
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
 	 *
362 362
 	 * @param string $column
363 363
 	 * @param mixed $type One of IQueryBuilder::PARAM_*
364
-	 * @return string
364
+	 * @return QueryFunction
365 365
 	 */
366 366
 	public function castColumn($column, $type) {
367 367
 		return new QueryFunction(
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
 	/**
373 373
 	 * Returns a query function to find the number of characters in a string column
374 374
 	 * @param string $column
375
-	 * @return string
375
+	 * @return QueryFunction
376 376
 	 */
377 377
 	public function length($column) {
378 378
 		$column = $this->helper->quoteColumnName($column);
Please login to merge, or discard this patch.
apps/provisioning_api/lib/Users.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -449,7 +449,7 @@
 block discarded – undo
449 449
 	 * @param IUser $user user to check access
450 450
 	 * @param IGroup|null $group group to check or null
451 451
 	 *
452
-	 * @return true if the user can manage the group
452
+	 * @return boolean if the user can manage the group
453 453
 	 */
454 454
 	private function canUserManageGroup($user, $group) {
455 455
 		if ($this->groupManager->isAdmin($user->getUID())) {
Please login to merge, or discard this patch.
lib/private/Files/ObjectStore/Swift.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 namespace OC\Files\ObjectStore;
25 25
 
26 26
 use Guzzle\Http\Exception\ClientErrorResponseException;
27
-use OCP\Files\Cache\ICacheEntry;
28 27
 use OCP\Files\ObjectStore\IObjectStore;
29 28
 use OpenCloud\OpenStack;
30 29
 use OpenCloud\Rackspace;
Please login to merge, or discard this patch.
lib/public/Files/ObjectStore/IObjectStore.php 2 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,6 +49,7 @@  discard block
 block discarded – undo
49 49
 	 * @param resource $stream stream with the data to write
50 50
 	 * @throws \Exception when something goes wrong, message will be logged
51 51
 	 * @since 7.0.0
52
+	 * @return void
52 53
 	 */
53 54
 	function writeObject($urn, $stream);
54 55
 
@@ -61,7 +62,7 @@  discard block
 block discarded – undo
61 62
 	function deleteObject($urn);
62 63
 
63 64
 	/**
64
-	 * @param string $path
65
+	 * @param string|null $urn
65 66
 	 * @return string mixed
66 67
 	 * @since 10.1.0
67 68
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  *
21 21
  */
22 22
 namespace OCP\Files\ObjectStore;
23
-use OCP\Files\Cache\ICacheEntry;
24 23
 
25 24
 /**
26 25
  * Interface IObjectStore
Please login to merge, or discard this patch.
lib/private/Preview/Movie.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -81,8 +81,8 @@  discard block
 block discarded – undo
81 81
 	}
82 82
 
83 83
 	/**
84
-	 * @param $absPath
85
-	 * @return bool|string
84
+	 * @param string $absPath
85
+	 * @return false|string
86 86
 	 */
87 87
 	private function extractMp4CoverArtwork($absPath) {
88 88
 		if (isset($this->noArtworkIndex[$absPath])) {
@@ -118,9 +118,9 @@  discard block
 block discarded – undo
118 118
 	}
119 119
 
120 120
 	/**
121
-	 * @param $absPath
122
-	 * @param $second
123
-	 * @return bool|string
121
+	 * @param string $absPath
122
+	 * @param integer $second
123
+	 * @return string|false
124 124
 	 */
125 125
 	private function generateFromMovie($absPath, $second) {
126 126
 		$tmpPath = \OC::$server->getTempManager()->getTemporaryFile();
Please login to merge, or discard this patch.
lib/private/DB/MigrationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@
 block discarded – undo
361 361
 
362 362
 	/**
363 363
 	 * @param string $version
364
-	 * @return mixed
364
+	 * @return \Doctrine\DBAL\Schema\Schema
365 365
 	 * @throws \Exception
366 366
 	 */
367 367
 	protected function createInstance($version) {
Please login to merge, or discard this patch.
lib/private/legacy/template.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -319,6 +319,7 @@
 block discarded – undo
319 319
 		* @param string $error_msg The error message to show
320 320
 		* @param string $hint An optional hint message - needs to be properly escaped
321 321
 		* @param int HTTP Status Code
322
+		* @param integer $httpStatusCode
322 323
 		*/
323 324
 	public static function printErrorPage( $error_msg, $hint = '', $httpStatusCode = null ) {
324 325
 		if ($error_msg === $hint) {
Please login to merge, or discard this patch.
apps/dav/lib/Upload/ChunkingPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 	 *
91 91
 	 * @param string $path source path
92 92
 	 * @param string $destination destination path
93
-	 * @return bool|void false to stop handling, void to skip this handler
93
+	 * @return null|false false to stop handling, void to skip this handler
94 94
 	 */
95 95
 	public function performMove($path, $destination) {
96 96
 		if (!$this->server->tree->nodeExists($destination)) {
Please login to merge, or discard this patch.
lib/private/L10N/L10N.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
 	 * Returns an associative array with all translations
172 172
 	 *
173 173
 	 * Called by String
174
-	 * @return array
174
+	 * @return string[]
175 175
 	 */
176 176
 	public function getTranslations() {
177 177
 		return $this->translations;
Please login to merge, or discard this patch.