owncloud / core

apps/dav/lib/CardDAV/CardDavBackend.php

Doc Comments +8 added lines, -3 removed lines

@@ -189,7 +189,8 @@ 
 	}
 
 	/**
-	 * @param $addressBookUri
+	 * @param string $addressBookUri
+	 * @param string $principal
 	 * @return array|null
 	 */
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -871,6 +872,7 @@ 
 	 *   * readOnly - boolean
 	 *   * summary - Optional, a description for the share
 	 *
+	 * @param integer $addressBookId
 	 * @return array
 	 */
 	public function getShares($addressBookId) {
@@ -924,7 +926,7 @@ 
 	 * read vCard data into a vCard object
 	 *
 	 * @param string $cardData
-	 * @return VCard
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
 	 */
 	protected function readCard($cardData) {
 		return  Reader::read($cardData);
@@ -970,7 +972,7 @@ 
 
 	/**
 	 * For shared address books the sharee is set in the ACL of the address book
-	 * @param $addressBookId
+	 * @param integer $addressBookId
 	 * @param $acl
 	 * @return array
 	 */
@@ -978,6 +980,9 @@ 
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

apps/files_sharing/lib/Controller/ShareesController.php

Doc Comments +1 added lines, -1 removed lines

@@ -327,7 +327,7 @@
 	 * split user and remote from federated cloud id
 	 *
 	 * @param string $address federated share address
-	 * @return array [user, remoteURL]
+	 * @return string[] [user, remoteURL]
 	 * @throws \Exception
 	 */
 	public function splitUserRemote($address) {

apps/federation/lib/Controller/OCSAuthAPIController.php

Doc Comments +4 added lines

@@ -164,6 +164,10 @@
 			'data' => ['sharedSecret' => $sharedSecret]];
 	}
 
+	/**
+	 * @param string $url
+	 * @param string $token
+	 */
 	protected function isValidToken($url, $token) {
 		$storedToken = $this->dbHandler->getToken($url);
 		return hash_equals($storedToken, $token);

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +7 added lines, -1 removed lines

@@ -262,6 +262,9 @@ 
 		return array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = array_values($this->propertyMap);
@@ -1254,7 +1257,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
 
@@ -1657,6 +1660,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

lib/private/AvatarManager.php

Doc Comments +3 added lines

@@ -99,6 +99,9 @@
 		}
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	private function buildAvatarPath($userId) {
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
 		return explode('/', $avatar);

apps/dav/lib/CardDAV/ImageExportPlugin.php

Doc Comments +3 added lines

@@ -136,6 +136,9 @@
 		return false;
 	}
 
+	/**
+	 * @param string $cardData
+	 */
 	private function readCard($cardData) {
 		return Reader::read($cardData);
 	}

lib/private/L10N/Factory.php

Doc Comments +5 added lines

@@ -278,6 +278,11 @@
 	 */
 	// FIXME This method is only public, until \OCP\IL10N does not need it anymore,
 	// FIXME This is also the reason, why it is not in the public interface
+
+	/**
+	 * @param string $app
+	 * @param string $lang
+	 */
 	public function getL10nFilesForApp($app, $lang) {
 		$languageFiles = [];
 

apps/dav/lib/Connector/Sabre/FilesReportPlugin.php

Doc Comments +3 added lines, -2 removed lines

@@ -148,7 +148,7 @@ 
 	 * This will be used in the {DAV:}supported-report-set property.
 	 *
 	 * @param string $uri
-	 * @return array
+	 * @return string[]
 	 */
 	public function getSupportedReportSet($uri) {
 		return [self::REPORT_NAME];
@@ -160,7 +160,7 @@ 
 	 * @param string $reportName
 	 * @param $report
 	 * @param string $uri
-	 * @return bool
+	 * @return null|false
 	 * @throws BadRequest
 	 * @throws PreconditionFailed
 	 * @internal param $ [] $report
@@ -333,6 +333,7 @@ 
 	 * with a leading slash but no trailing slash
 	 * @param string[] $requestedProps requested properties
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
+	 * @param Node[] $nodes
 	 * @return Response[]
 	 */
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {

apps/files_external/lib/Lib/Backend/Dropbox.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 namespace OCA\Files_External\Lib\Backend;
 
 use OCP\IL10N;
-use OCP\Files\External\DefinitionParameter;
 use OCP\Files\External\Auth\AuthMechanism;
 use OCP\Files\External\Backend\Backend;
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;