Completed
Pull Request — master (#30412)
by Tom
50:40 queued 38:47
created
lib/private/User/Session.php 1 patch
Doc Comments   +8 added lines, -2 removed lines patch added patch discarded remove patch
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
 	 * @param IRequest $request
304 304
 	 * @throws LoginException
305 305
 	 * @throws PasswordLoginForbiddenException
306
-	 * @return boolean
306
+	 * @return boolean|null
307 307
 	 */
308 308
 	public function logClientIn($user, $password, IRequest $request) {
309 309
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -346,6 +346,9 @@  discard block
 block discarded – undo
346 346
 		return $this->config->getSystemValue('token_auth_enforced', false);
347 347
 	}
348 348
 
349
+	/**
350
+	 * @param string $username
351
+	 */
349 352
 	protected function isTwoFactorEnforced($username) {
350 353
 		Util::emitHook(
351 354
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -857,6 +860,9 @@  discard block
 block discarded – undo
857 860
 		}
858 861
 	}
859 862
 
863
+	/**
864
+	 * @param IRequest $request
865
+	 */
860 866
 	public function verifyAuthHeaders($request) {
861 867
 		foreach ($this->getAuthModules(true) as $module) {
862 868
 			$user = $module->auth($request);
@@ -876,7 +882,7 @@  discard block
 block discarded – undo
876 882
 	}
877 883
 
878 884
 	/**
879
-	 * @param $includeBuiltIn
885
+	 * @param boolean $includeBuiltIn
880 886
 	 * @return \Generator | IAuthModule[]
881 887
 	 * @throws Exception
882 888
 	 */
Please login to merge, or discard this patch.
settings/Controller/CorsController.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,6 @@
 block discarded – undo
131 131
 	/**
132 132
 	 * Removes a WhiteListed Domain
133 133
 	 *
134
-	 * @param string $domain Domain to remove
135 134
 	 * @return RedirectResponse Redirection to the settings page.
136 135
 	 */
137 136
 	public function removeDomain($id) {
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -218,6 +218,9 @@  discard block
 block discarded – undo
218 218
 
219 219
 	/**
220 220
 	 *
221
+	 * @param string $targetFilename
222
+	 * @param string $targetLocation
223
+	 * @param integer $timestamp
221 224
 	 */
222 225
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
223 226
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -330,6 +333,7 @@  discard block
 block discarded – undo
330 333
 	 * @param string $ownerPath path relative to the owner's home storage
331 334
 	 * @param integer $timestamp when the file was deleted
332 335
 	 * @param bool $forceCopy true to only make a copy of the versions into the trashbin
336
+	 * @param \OC\Files\Storage\Storage $sourceStorage
333 337
 	 */
334 338
 	private static function retainVersions($filename, $owner, $ownerPath, $timestamp, $sourceStorage = null, $forceCopy = false) {
335 339
 		if (\OCP\App::isEnabled('files_versions') && !empty($ownerPath)) {
@@ -780,7 +784,7 @@  discard block
 block discarded – undo
780 784
 	 * if the size limit for the trash bin is reached, we delete the oldest
781 785
 	 * files in the trash bin until we meet the limit again
782 786
 	 *
783
-	 * @param array $files
787
+	 * @param \OCP\Files\FileInfo[] $files
784 788
 	 * @param string $user
785 789
 	 * @param int $availableSpace available disc space
786 790
 	 * @return int size of deleted files
@@ -808,7 +812,7 @@  discard block
 block discarded – undo
808 812
 	/**
809 813
 	 * delete files older then max storage time
810 814
 	 *
811
-	 * @param array $files list of files sorted by mtime
815
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
812 816
 	 * @param string $user
813 817
 	 * @return integer[] size of deleted files and number of deleted files
814 818
 	 */
Please login to merge, or discard this patch.
core/Command/Security/ListRoutes.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -122,6 +122,9 @@
 block discarded – undo
122 122
 		}
123 123
 	}
124 124
 
125
+	/**
126
+	 * @param integer $name
127
+	 */
125 128
 	private function buildController($name) {
126 129
 		$parts = explode('.', $name);
127 130
 		if (count($parts) === 4 && $parts[0] === 'ocs') {
Please login to merge, or discard this patch.
lib/private/Files/Storage/CacheableFlysystem.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -50,6 +50,9 @@
 block discarded – undo
50 50
 		return $location;
51 51
 	}
52 52
 
53
+	/**
54
+	 * @param string $path
55
+	 */
53 56
 	public function buildPath($path) {
54 57
 		$location = parent::buildPath($path);
55 58
 		if ($this->isCaseInsensitiveStorage) {
Please login to merge, or discard this patch.
apps/dav/lib/DAV/FileCustomPropertiesBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -204,7 +204,7 @@
 block discarded – undo
204 204
 
205 205
 	/**
206 206
 	 * @param string $path
207
-	 * @return INode|null
207
+	 * @return null|Node
208 208
 	 */
209 209
 	protected function getNodeForPath($path){
210 210
 		$node = parent::getNodeForPath($path);
Please login to merge, or discard this patch.
lib/private/Files/Node/Root.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 	 * @param string $path
175 175
 	 * @throws \OCP\Files\NotFoundException
176 176
 	 * @throws \OCP\Files\NotPermittedException
177
-	 * @return File|Folder
177
+	 * @return string
178 178
 	 */
179 179
 	public function get($path) {
180 180
 		$path = $this->normalizePath($path);
@@ -371,6 +371,9 @@  discard block
 block discarded – undo
371 371
 
372 372
 	}
373 373
 
374
+	/**
375
+	 * @param string $fullPath
376
+	 */
374 377
 	private function resolveVirtualNode($fullPath) {
375 378
 		$pieces = explode('/', $fullPath);
376 379
 		if ($pieces[1] !== 'meta') {
Please login to merge, or discard this patch.
lib/private/Preview.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -920,7 +920,7 @@  discard block
 block discarded – undo
920 920
 	 * @param int $previewWidth
921 921
 	 * @param int $previewHeight
922 922
 	 *
923
-	 * @return int[]
923
+	 * @return double[]
924 924
 	 */
925 925
 	private function scale($image, $askedWidth, $askedHeight, $previewWidth, $previewHeight) {
926 926
 		$scalingUp = $this->getScalingUp();
@@ -1083,6 +1083,7 @@  discard block
 block discarded – undo
1083 1083
 	/**
1084 1084
 	 * Returns the path to the folder where the previews are stored, identified by the fileId
1085 1085
 	 *
1086
+	 * @param integer $fileId
1086 1087
 	 * @return string
1087 1088
 	 */
1088 1089
 	private function getPreviewPath($fileId = null) {
Please login to merge, or discard this patch.
lib/private/DB/Adapter.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
 	/**
49 49
 	 * @param string $table name
50
-	 * @return int id of last insert statement
50
+	 * @return string id of last insert statement
51 51
 	 */
52 52
 	public function lastInsertId($table) {
53 53
 		return $this->conn->realLastInsertId($table);
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 
119 119
 	/**
120 120
 	 * Inserts, or updates a row into the database. Returns the inserted or updated rows
121
-	 * @param $table string table name including **PREFIX**
121
+	 * @param string $table string table name including **PREFIX**
122 122
 	 * @param $input array the key=>value pairs to insert into the db row
123 123
 	 * @param $compare array columns that should be compared to look for existing arrays
124 124
 	 * @return int the number of rows affected by the operation
Please login to merge, or discard this patch.