Completed
Pull Request — master (#30412)
by Tom
50:40 queued 38:47
created
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +8 added lines, -3 removed lines patch added patch discarded remove patch
@@ -214,7 +214,8 @@  discard block
 block discarded – undo
214 214
 	}
215 215
 
216 216
 	/**
217
-	 * @param $addressBookUri
217
+	 * @param string $addressBookUri
218
+	 * @param string $principal
218 219
 	 * @return array|null
219 220
 	 */
220 221
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -896,6 +897,7 @@  discard block
 block discarded – undo
896 897
 	 *   * readOnly - boolean
897 898
 	 *   * summary - Optional, a description for the share
898 899
 	 *
900
+	 * @param integer $addressBookId
899 901
 	 * @return array
900 902
 	 */
901 903
 	public function getShares($addressBookId) {
@@ -949,7 +951,7 @@  discard block
 block discarded – undo
949 951
 	 * read vCard data into a vCard object
950 952
 	 *
951 953
 	 * @param string $cardData
952
-	 * @return VCard
954
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
953 955
 	 */
954 956
 	protected function readCard($cardData) {
955 957
 		return  Reader::read($cardData);
@@ -995,7 +997,7 @@  discard block
 block discarded – undo
995 997
 
996 998
 	/**
997 999
 	 * For shared address books the sharee is set in the ACL of the address book
998
-	 * @param $addressBookId
1000
+	 * @param integer $addressBookId
999 1001
 	 * @param $acl
1000 1002
 	 * @return array
1001 1003
 	 */
@@ -1003,6 +1005,9 @@  discard block
 block discarded – undo
1003 1005
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
1004 1006
 	}
1005 1007
 
1008
+	/**
1009
+	 * @param boolean $toV2
1010
+	 */
1006 1011
 	private function convertPrincipal($principalUri, $toV2 = null) {
1007 1012
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1008 1013
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
lib/private/User/AccountMapper.php 1 patch
Doc Comments   +13 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 
43 43
 	/**
44 44
 	 * Delegate to term mapper to avoid needing to inject term mapper
45
-	 * @param $account_id
45
+	 * @param integer $account_id
46 46
 	 * @param array $terms
47 47
 	 */
48 48
 	public function setTermsForAccount($account_id, array $terms) {
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
 	/**
53 53
 	 * Delegate to term mapper to avoid needing to inject term mapper
54
-	 * @param $account_id
54
+	 * @param integer $account_id
55 55
 	 * @return AccountTerm[] $terms
56 56
 	 */
57 57
 	public function findByAccountId($account_id) {
@@ -164,6 +164,9 @@  discard block
 block discarded – undo
164 164
 		return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
165 165
 	}
166 166
 
167
+	/**
168
+	 * @param boolean $hasLoggedIn
169
+	 */
167 170
 	public function getUserCountPerBackend($hasLoggedIn) {
168 171
 		$qb = $this->db->getQueryBuilder();
169 172
 		$qb->select(['backend', $qb->createFunction('count(*) as `count`')])
@@ -186,6 +189,9 @@  discard block
 block discarded – undo
186 189
 		return $return;
187 190
 	}
188 191
 
192
+	/**
193
+	 * @param boolean $hasLoggedIn
194
+	 */
189 195
 	public function getUserCount($hasLoggedIn) {
190 196
 		$qb = $this->db->getQueryBuilder();
191 197
 		$qb->select([$qb->createFunction('count(*) as `count`')])
@@ -202,6 +208,11 @@  discard block
 block discarded – undo
202 208
 		return (int) $data['count'];
203 209
 	}
204 210
 
211
+	/**
212
+	 * @param \Closure $callback
213
+	 * @param string $search
214
+	 * @param boolean $onlySeen
215
+	 */
205 216
 	public function callForAllUsers($callback, $search, $onlySeen) {
206 217
 		$qb = $this->db->getQueryBuilder();
207 218
 		$qb->select(['*'])
Please login to merge, or discard this patch.
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
 	 *
362 362
 	 * @param string $column
363 363
 	 * @param mixed $type One of IQueryBuilder::PARAM_*
364
-	 * @return string
364
+	 * @return QueryFunction
365 365
 	 */
366 366
 	public function castColumn($column, $type) {
367 367
 		return new QueryFunction(
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
 	/**
373 373
 	 * Returns a query function to find the number of characters in a string column
374 374
 	 * @param string $column
375
-	 * @return string
375
+	 * @return QueryFunction
376 376
 	 */
377 377
 	public function length($column) {
378 378
 		$column = $this->helper->quoteColumnName($column);
Please login to merge, or discard this patch.
apps/provisioning_api/lib/Users.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -449,7 +449,7 @@
 block discarded – undo
449 449
 	 * @param IUser $user user to check access
450 450
 	 * @param IGroup|null $group group to check or null
451 451
 	 *
452
-	 * @return true if the user can manage the group
452
+	 * @return boolean if the user can manage the group
453 453
 	 */
454 454
 	private function canUserManageGroup($user, $group) {
455 455
 		if ($this->groupManager->isAdmin($user->getUID())) {
Please login to merge, or discard this patch.
lib/private/Preview/Movie.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -81,8 +81,8 @@  discard block
 block discarded – undo
81 81
 	}
82 82
 
83 83
 	/**
84
-	 * @param $absPath
85
-	 * @return bool|string
84
+	 * @param string $absPath
85
+	 * @return false|string
86 86
 	 */
87 87
 	private function extractMp4CoverArtwork($absPath) {
88 88
 		if (isset($this->noArtworkIndex[$absPath])) {
@@ -118,9 +118,9 @@  discard block
 block discarded – undo
118 118
 	}
119 119
 
120 120
 	/**
121
-	 * @param $absPath
122
-	 * @param $second
123
-	 * @return bool|string
121
+	 * @param string $absPath
122
+	 * @param integer $second
123
+	 * @return string|false
124 124
 	 */
125 125
 	private function generateFromMovie($absPath, $second) {
126 126
 		$tmpPath = \OC::$server->getTempManager()->getTemporaryFile();
Please login to merge, or discard this patch.
lib/private/DB/MigrationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@
 block discarded – undo
361 361
 
362 362
 	/**
363 363
 	 * @param string $version
364
-	 * @return mixed
364
+	 * @return \Doctrine\DBAL\Schema\Schema
365 365
 	 * @throws \Exception
366 366
 	 */
367 367
 	protected function createInstance($version) {
Please login to merge, or discard this patch.
lib/private/legacy/template.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -319,6 +319,7 @@
 block discarded – undo
319 319
 		* @param string $error_msg The error message to show
320 320
 		* @param string $hint An optional hint message - needs to be properly escaped
321 321
 		* @param int HTTP Status Code
322
+		* @param integer $httpStatusCode
322 323
 		*/
323 324
 	public static function printErrorPage( $error_msg, $hint = '', $httpStatusCode = null ) {
324 325
 		if ($error_msg === $hint) {
Please login to merge, or discard this patch.
apps/dav/lib/Upload/ChunkingPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 	 *
91 91
 	 * @param string $path source path
92 92
 	 * @param string $destination destination path
93
-	 * @return bool|void false to stop handling, void to skip this handler
93
+	 * @return null|false false to stop handling, void to skip this handler
94 94
 	 */
95 95
 	public function performMove($path, $destination) {
96 96
 		if (!$this->server->tree->nodeExists($destination)) {
Please login to merge, or discard this patch.
lib/private/L10N/L10N.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
 	 * Returns an associative array with all translations
172 172
 	 *
173 173
 	 * Called by String
174
-	 * @return array
174
+	 * @return string[]
175 175
 	 */
176 176
 	public function getTranslations() {
177 177
 		return $this->translations;
Please login to merge, or discard this patch.