owncloud / core

apps/federation/lib/Controller/OCSAuthAPIController.php

Doc Comments +4 added lines

@@ -164,6 +164,10 @@
 			'data' => ['sharedSecret' => $sharedSecret]];
 	}
 
+	/**
+	 * @param string $url
+	 * @param string $token
+	 */
 	protected function isValidToken($url, $token) {
 		$storedToken = $this->dbHandler->getToken($url);
 		return hash_equals($storedToken, $token);

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +7 added lines, -1 removed lines

@@ -262,6 +262,9 @@ 
 		return array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = array_values($this->propertyMap);
@@ -1254,7 +1257,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
 
@@ -1657,6 +1660,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

lib/private/AvatarManager.php

Doc Comments +3 added lines

@@ -99,6 +99,9 @@
 		}
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	private function buildAvatarPath($userId) {
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
 		return explode('/', $avatar);

apps/dav/lib/CardDAV/ImageExportPlugin.php

Doc Comments +3 added lines

@@ -136,6 +136,9 @@
 		return false;
 	}
 
+	/**
+	 * @param string $cardData
+	 */
 	private function readCard($cardData) {
 		return Reader::read($cardData);
 	}

apps/dav/lib/Files/Xml/FilterRequest.php

Doc Comments +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
 	 * the next element.
 	 *
 	 * @param Reader $reader
-	 * @return mixed
+	 * @return FilterRequest
 	 */
 	static function xmlDeserialize(Reader $reader) {
 		$elems = (array)$reader->parseInnerTree([

lib/private/L10N/Factory.php

Doc Comments +5 added lines

@@ -278,6 +278,11 @@
 	 */
 	// FIXME This method is only public, until \OCP\IL10N does not need it anymore,
 	// FIXME This is also the reason, why it is not in the public interface
+
+	/**
+	 * @param string $app
+	 * @param string $lang
+	 */
 	public function getL10nFilesForApp($app, $lang) {
 		$languageFiles = [];
 

apps/files_external/lib/Lib/Backend/Dropbox.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 namespace OCA\Files_External\Lib\Backend;
 
 use OCP\IL10N;
-use OCP\Files\External\DefinitionParameter;
 use OCP\Files\External\Auth\AuthMechanism;
 use OCP\Files\External\Backend\Backend;
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;

apps/updatenotification/lib/Notification/BackgroundJob.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 
 
 use OC\BackgroundJob\TimedJob;
-use OC\Installer;
 use OC\Updater\VersionCheck;
 use OCP\App\IAppManager;
 use OCP\Http\Client\IClientService;

apps/files_sharing/lib/SharedMount.php

Doc Comments +2 added lines, -2 removed lines

@@ -110,7 +110,7 @@ 
 	 *
 	 * @param string $newPath
 	 * @param \OCP\Share\IShare $share
-	 * @return bool
+	 * @return boolean|null
 	 */
 	private function updateFileTarget($newPath, &$share) {
 		$share->setTarget($newPath);
@@ -126,7 +126,7 @@ 
 	 * @param string $path
 	 * @param View $view
 	 * @param SharedMount[] $mountpoints
-	 * @return mixed
+	 * @return string
 	 */
 	private function generateUniqueTarget($path, $view, array $mountpoints) {
 		$pathinfo = pathinfo($path);