Completed
Pull Request — master (#31651)
by Thomas
16:24
created
settings/ChangePassword/Controller.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -67,6 +67,9 @@
 block discarded – undo
67 67
 		}
68 68
 	}
69 69
 
70
+	/**
71
+	 * @param string|boolean $username
72
+	 */
70 73
 	private static function sendNotificationMail($username) {
71 74
 		$userObject = \OC::$server->getUserManager()->get($username);
72 75
 		$email = $userObject->getEMailAddress();
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -245,7 +245,7 @@
 block discarded – undo
245 245
 	}
246 246
 
247 247
 	/**
248
-	 * @return array|null
248
+	 * @return string
249 249
 	 */
250 250
 	public function getLocalSystemAddressBook() {
251 251
 		if ($this->localSystemAddressBook === null) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/Hooks.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use OCP\Share\IShare;
34 34
 use Symfony\Component\EventDispatcher\GenericEvent;
35 35
 use OCA\Files_Sharing\Service\NotificationPublisher;
36
-use OCP\Share\Exceptions\ShareNotFound;
37 36
 
38 37
 class Hooks {
39 38
 	/**
Please login to merge, or discard this patch.
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -138,6 +138,10 @@
 block discarded – undo
138 138
 		);
139 139
 	}
140 140
 
141
+	/**
142
+	 * @param IShare[] $shares
143
+	 * @param string $fileId
144
+	 */
141 145
 	private function filterSharesByFileId($shares, $fileId) {
142 146
 		return \array_filter($shares, function (IShare $share) use ($fileId) {
143 147
 			return \strval($share->getNodeId()) === \strval($fileId);
Please login to merge, or discard this patch.
settings/Application.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -39,12 +39,9 @@
 block discarded – undo
39 39
 use OC\Settings\Controller\AuthSettingsController;
40 40
 use OC\Settings\Controller\CertificateController;
41 41
 use OC\Settings\Controller\CheckSetupController;
42
-use OC\Settings\Controller\GroupsController;
43 42
 use OC\Settings\Controller\LegalSettingsController;
44 43
 use OC\Settings\Controller\LogSettingsController;
45 44
 use OC\Settings\Controller\MailSettingsController;
46
-use OC\Settings\Controller\UsersController;
47
-use OC\Settings\Middleware\SubadminMiddleware;
48 45
 use OCP\AppFramework\App;
49 46
 use OCP\IContainer;
50 47
 use OCP\Util;
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/Node.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,6 @@
 block discarded – undo
39 39
 use OCA\DAV\Connector\Sabre\Exception\Forbidden;
40 40
 use OCA\DAV\Connector\Sabre\Exception\InvalidPath;
41 41
 use OCP\Files\ForbiddenException;
42
-use OCP\Files\Storage\IPersistentLockingStorage;
43 42
 use OCP\Share\Exceptions\ShareNotFound;
44 43
 use OCP\Share\IManager;
45 44
 
Please login to merge, or discard this patch.
apps/dav/lib/Files/FileLocksBackend.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -34,6 +34,9 @@
 block discarded – undo
34 34
 	/** @var Tree */
35 35
 	private $tree;
36 36
 
37
+	/**
38
+	 * @param Tree $tree
39
+	 */
37 40
 	public function __construct($tree) {
38 41
 		$this->tree = $tree;
39 42
 	}
Please login to merge, or discard this patch.
lib/private/Lock/Persistent/LockMapper.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -30,6 +30,11 @@  discard block
 block discarded – undo
30 30
 		parent::__construct($db, 'persistent_locks', null);
31 31
 	}
32 32
 
33
+	/**
34
+	 * @param integer $storageId
35
+	 * @param string $internalPath
36
+	 * @param boolean $returnChildLocks
37
+	 */
33 38
 	public function getLocksByPath($storageId, $internalPath, $returnChildLocks) {
34 39
 		$query = $this->db->getQueryBuilder();
35 40
 		$pathPattern = $this->db->escapeLikeParameter($internalPath) . '%';
@@ -56,6 +61,9 @@  discard block
 block discarded – undo
56 61
 		// TODO: insert or update
57 62
 	}
58 63
 
64
+	/**
65
+	 * @param integer $fileId
66
+	 */
59 67
 	public function unlock($fileId, $token) {
60 68
 		$query = $this->db->getQueryBuilder();
61 69
 
Please login to merge, or discard this patch.