owncloud / core

lib/private/group/dummy.php

Doc Comments +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
 	 * Removes a user from a group
 	 * @param string $uid Name of the user to remove from group
 	 * @param string $gid Name of the group from which remove the user
-	 * @return bool
+	 * @return null|false
 	 *
 	 * removes the user from a group.
 	 */

lib/private/group/manager.php

Doc Comments +3 added lines

@@ -144,6 +144,9 @@
 		return $this->getGroupObject($gid);
 	}
 
+	/**
+	 * @param string $gid
+	 */
 	protected function getGroupObject($gid) {
 		$backends = array();
 		foreach ($this->backends as $backend) {

lib/private/image.php

Doc Comments +3 added lines, -2 removed lines

@@ -299,7 +299,7 @@ 
 	}
 
 	/**
-	 * @return resource Returns the image resource in any.
+	 * @return boolean Returns the image resource in any.
 	 */
 	public function resource() {
 		return $this->resource;
@@ -474,7 +474,7 @@ 
 	 * It is the responsibility of the caller to position the pointer at the correct place and to close the handle again.
 	 *
 	 * @param resource $handle
-	 * @return resource|false An image resource or false on error
+	 * @return boolean An image resource or false on error
 	 */
 	public function loadFromFileHandle($handle) {
 		$contents = stream_get_contents($handle);
@@ -1023,6 +1023,7 @@ 
 	 * @param string $fileName [optional] <p>The path to save the file to.</p>
 	 * @param int $bit [optional] <p>Bit depth, (default is 24).</p>
 	 * @param int $compression [optional]
+	 * @param boolean $im
 	 * @return bool <b>TRUE</b> on success or <b>FALSE</b> on failure.
 	 */
 	function imagebmp($im, $fileName = '', $bit = 24, $compression = 0) {

lib/private/route/router.php

Doc Comments +1 added lines

@@ -127,6 +127,7 @@
 
 	/**
 	 * loads the api routes
+	 * @param string $app
 	 * @return void
 	 */
 	public function loadRoutes($app = null) {

lib/private/server.php

Doc Comments +1 added lines, -1 removed lines

@@ -856,7 +856,7 @@
 	 * Get the certificate manager for the user
 	 *
 	 * @param string $userId (optional) if not specified the current loggedin user is used
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
 	 */
 	public function getCertificateManager($userId = null) {
 		if (is_null($userId)) {

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use OC\Diagnostics\NullQueryLogger;
 use OC\Diagnostics\EventLogger;
 use OC\Diagnostics\QueryLogger;
-use OC\Files\Config\StorageManager;
 use OC\Security\CertificateManager;
 use OC\Files\Node\Root;
 use OC\Files\View;

lib/private/setup/abstractdatabase.php

Doc Comments +3 added lines

@@ -91,5 +91,8 @@
 		$this->tablePrefix = $dbTablePrefix;
 	}
 
+	/**
+	 * @param string $userName
+	 */
 	abstract public function setupDatabase($userName);
 }

lib/private/tags.php

Doc Comments +10 added lines, -2 removed lines

@@ -741,11 +741,19 @@ 
 	}
 
 	// case-insensitive array_search
+
+	/**
+	 * @param string $needle
+	 */
 	protected function array_searchi($needle, $haystack, $mem='getName') {
 		if(!is_array($haystack)) {
 			return false;
 		}
 		return array_search(strtolower($needle), array_map(
+
+			/**
+			 * @param string $tag
+			 */
 			function($tag) use($mem) {
 				return strtolower(call_user_func(array($tag, $mem)));
 			}, $haystack)
@@ -770,7 +778,7 @@ 
 	* Get a tag by its name.
 	*
 	* @param string $name The tag name.
-	* @return integer|bool The tag object's offset within the $this->tags
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
 	*                      array or false if it doesn't exist.
 	*/
 	private function getTagByName($name) {
@@ -781,7 +789,7 @@ 
 	* Get a tag by its ID.
 	*
 	* @param string $id The tag ID to look for.
-	* @return integer|bool The tag object's offset within the $this->tags
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
 	*                      array or false if it doesn't exist.
 	*/
 	private function getTagById($id) {

lib/private/template/base.php

Doc Comments +2 added lines, -1 removed lines

@@ -36,6 +36,7 @@ 
 	 * @param string $template
 	 * @param \OC_L10N $l10n
 	 * @param \OC_Defaults $theme
+	 * @param string $requesttoken
 	 */
 	public function __construct( $template, $requesttoken, $l10n, $theme ) {
 		$this->vars = array();
@@ -95,7 +96,7 @@ 
 	/**
 	 * Appends a variable
 	 * @param string $key key
-	 * @param mixed $value value
+	 * @param string $value value
 	 * @return boolean|null
 	 *
 	 * This function assigns a variable in an array context. If the key already

lib/private/updater.php

Doc Comments +1 added lines, -1 removed lines

@@ -277,7 +277,7 @@
 	 * @param string $installedVersion previous version from which to upgrade from
 	 *
 	 * @throws \Exception
-	 * @return bool true if the operation succeeded, false otherwise
+	 * @return boolean|null true if the operation succeeded, false otherwise
 	 */
 	private function doUpgrade($currentVersion, $installedVersion) {
 		// Stop update if the update is over several major versions

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 
 namespace OC;
 
-use OC\Core\Command\Log\Manage;
 use OC\Hooks\BasicEmitter;
 use OC_App;
 use OC_Installer;