Completed
Pull Request — master (#25918)
by Thomas
08:57
created
apps/files_external/lib/Lib/Storage/SMB.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -260,6 +260,9 @@  discard block
 block discarded – undo
260 260
 		return $this->leave(__FUNCTION__, $result);
261 261
 	}
262 262
 
263
+	/**
264
+	 * @param string $path
265
+	 */
263 266
 	private function removeFromCache($path) {
264 267
 		$path = trim($path, '/');
265 268
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -632,7 +635,7 @@  discard block
 block discarded – undo
632 635
 	 * if wnd.logging.enable is set to true in the config will log a leave line
633 636
 	 * with the given function, the return value or the exception
634 637
 	 *
635
-	 * @param $function
638
+	 * @param string $function
636 639
 	 * @param mixed $result an exception will be logged and then returned
637 640
 	 * @return mixed
638 641
 	 */
@@ -659,6 +662,9 @@  discard block
 block discarded – undo
659 662
 		return $result;
660 663
 	}
661 664
 
665
+	/**
666
+	 * @param string $function
667
+	 */
662 668
 	private function swallow($function, \Exception $exception) {
663 669
 		if (\OC::$server->getConfig()->getSystemValue('wnd.logging.enable', false) === true) {
664 670
 			Util::writeLog('wnd', "$function swallowing ".get_class($exception)
Please login to merge, or discard this patch.
lib/private/AppFramework/Http/Request.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@
 block discarded – undo
448 448
 
449 449
 	/**
450 450
 	 * Checks if the CSRF check was correct
451
-	 * @return bool true if CSRF check passed
451
+	 * @return null|boolean true if CSRF check passed
452 452
 	 */
453 453
 	public function passesCSRFCheck() {
454 454
 		if($this->csrfTokenManager === null) {
Please login to merge, or discard this patch.
core/Controller/OccController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -131,8 +131,8 @@
 block discarded – undo
131 131
 
132 132
 	/**
133 133
 	 * Check if command is allowed and has a valid security token
134
-	 * @param $command
135
-	 * @param $token
134
+	 * @param string $command
135
+	 * @param string $token
136 136
 	 */
137 137
 	protected function validateRequest($command, $token){
138 138
 		$allowedHosts = ['::1', '127.0.0.1', 'localhost'];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 	 * @param ITagManager $fileTagger manager for private tags
105 105
 	 * @param IUserSession $userSession
106 106
 	 * @param IGroupManager $groupManager
107
-	 * @param Folder $userfolder
107
+	 * @param Folder $userFolder
108 108
 	 */
109 109
 	public function __construct(Tree $tree,
110 110
 								View $view,
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 	 * This will be used in the {DAV:}supported-report-set property.
151 151
 	 *
152 152
 	 * @param string $uri
153
-	 * @return array
153
+	 * @return string[]
154 154
 	 */
155 155
 	public function getSupportedReportSet($uri) {
156 156
 		return [self::REPORT_NAME];
@@ -307,6 +307,7 @@  discard block
 block discarded – undo
307 307
 	 *
308 308
 	 * @param string[] $requestedProps requested properties
309 309
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
310
+	 * @param Node[] $nodes
310 311
 	 * @return Response[]
311 312
 	 */
312 313
 	public function prepareResponses($requestedProps, $nodes) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ShareTypeList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
 	 * The deserialize method is called during xml parsing.
61 61
 	 *
62 62
 	 * @param Reader $reader
63
-	 * @return mixed
63
+	 * @return null|ShareTypeList
64 64
 	 */
65 65
 	static function xmlDeserialize(Reader $reader) {
66 66
 		$shareTypes = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 	 * the next element.
80 80
 	 *
81 81
 	 * @param Reader $reader
82
-	 * @return mixed
82
+	 * @return null|TagList
83 83
 	 */
84 84
 	static function xmlDeserialize(Reader $reader) {
85 85
 		$tags = [];
Please login to merge, or discard this patch.
core/Application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,6 @@
 block discarded – undo
32 32
 use OC\Core\Controller\AvatarController;
33 33
 use OC\Core\Controller\LoginController;
34 34
 use OC\Core\Controller\LostController;
35
-use OC\Core\Controller\OccController;
36 35
 use OC\Core\Controller\TokenController;
37 36
 use OC\Core\Controller\TwoFactorChallengeController;
38 37
 use OC\Core\Controller\UserController;
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -262,6 +262,9 @@  discard block
 block discarded – undo
262 262
 		return array_values($calendars);
263 263
 	}
264 264
 
265
+	/**
266
+	 * @param string $principalUri
267
+	 */
265 268
 	public function getUsersOwnCalendars($principalUri) {
266 269
 		$principalUri = $this->convertPrincipal($principalUri, true);
267 270
 		$fields = array_values($this->propertyMap);
@@ -1254,7 +1257,7 @@  discard block
 block discarded – undo
1254 1257
 	 * @param string $principalUri
1255 1258
 	 * @param string $uri
1256 1259
 	 * @param array $properties
1257
-	 * @return mixed
1260
+	 * @return integer
1258 1261
 	 */
1259 1262
 	function createSubscription($principalUri, $uri, array $properties) {
1260 1263
 
@@ -1657,6 +1660,9 @@  discard block
 block discarded – undo
1657 1660
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1658 1661
 	}
1659 1662
 
1663
+	/**
1664
+	 * @param boolean $toV2
1665
+	 */
1660 1666
 	private function convertPrincipal($principalUri, $toV2) {
1661 1667
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1662 1668
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.