Completed
Pull Request — master (#25918)
by Thomas
08:57
created
lib/private/IntegrityCheck/Helpers/FileAccessHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 	 * Wrapper around file_put_contents($filename, $data)
53 53
 	 *
54 54
 	 * @param string $filename
55
-	 * @param $data
55
+	 * @param string $data
56 56
 	 * @return int|false
57 57
 	 */
58 58
 	public function file_put_contents($filename, $data) {
Please login to merge, or discard this patch.
lib/private/legacy/db.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,6 @@
 block discarded – undo
150 150
 	/**
151 151
 	 * saves database schema to xml file
152 152
 	 * @param string $file name of file
153
-	 * @param int $mode
154 153
 	 * @return bool
155 154
 	 *
156 155
 	 * TODO: write more documentation
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -412,6 +412,10 @@
 block discarded – undo
412 412
 		return $url;
413 413
 	}
414 414
 
415
+	/**
416
+	 * @param string $feature
417
+	 * @param string $value
418
+	 */
415 419
 	public function triggerChange($feature, $value = null) {
416 420
 		if ($this->emitter) {
417 421
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value));
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Publishing/PublishPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@
 block discarded – undo
122 122
 	 * @param RequestInterface $request
123 123
 	 * @param ResponseInterface $response
124 124
 	 *
125
-	 * @return null|bool
125
+	 * @return null|false
126 126
 	 */
127 127
 	public function httpPost(RequestInterface $request, ResponseInterface $response)
128 128
 	{
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/PublicCalendarRoot.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 namespace OCA\DAV\Tests\Unit\Sabre\Connector;
23 23
 
24 24
 use OCA\DAV\Connector\Sabre\FilesReportPlugin as FilesReportPluginImplementation;
25
-use Sabre\DAV\Exception\NotFound;
26 25
 use OCP\SystemTag\ISystemTagObjectMapper;
27 26
 use OC\Files\View;
28 27
 use OCP\Files\Folder;
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagPlugin.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
lib/private/Files/Config/LazyStorageMountInfo.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -21,10 +21,7 @@
 block discarded – undo
21 21
 
22 22
 namespace OC\Files\Config;
23 23
 
24
-use OC\Files\Filesystem;
25
-use OCP\Files\Config\ICachedMountInfo;
26 24
 use OCP\Files\Mount\IMountPoint;
27
-use OCP\Files\Node;
28 25
 use OCP\IUser;
29 26
 
30 27
 class LazyStorageMountInfo extends CachedMountInfo {
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/ImageExportPlugin.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,13 +130,16 @@
 block discarded – undo
130 130
 		return false;
131 131
 	}
132 132
 
133
+	/**
134
+	 * @param string $cardData
135
+	 */
133 136
 	private function readCard($cardData) {
134 137
 		return Reader::read($cardData);
135 138
 	}
136 139
 
137 140
 	/**
138 141
 	 * @param Binary $photo
139
-	 * @return Parameter
142
+	 * @return string|null
140 143
 	 */
141 144
 	private function getType($photo) {
142 145
 		$params = $photo->parameters();
Please login to merge, or discard this patch.
lib/private/App/CodeChecker/NodeVisitor.php 1 patch
Doc Comments   +15 added lines patch added patch discarded remove patch
@@ -241,6 +241,9 @@  discard block
 block discarded – undo
241 241
 		}
242 242
 	}
243 243
 
244
+	/**
245
+	 * @param string $name
246
+	 */
244 247
 	private function checkBlackList($name, $errorCode, Node $node) {
245 248
 		$lowerName = strtolower($name);
246 249
 
@@ -254,6 +257,9 @@  discard block
 block discarded – undo
254 257
 		}
255 258
 	}
256 259
 
260
+	/**
261
+	 * @param string $constantName
262
+	 */
257 263
 	private function checkBlackListConstant($class, $constantName, Node $node) {
258 264
 		$name = $class . '::' . $constantName;
259 265
 		$lowerName = strtolower($name);
@@ -268,6 +274,9 @@  discard block
 block discarded – undo
268 274
 		}
269 275
 	}
270 276
 
277
+	/**
278
+	 * @param string $class
279
+	 */
271 280
 	private function checkBlackListFunction($class, $functionName, Node $node) {
272 281
 		$name = $class . '::' . $functionName;
273 282
 		$lowerName = strtolower($name);
@@ -282,6 +291,9 @@  discard block
 block discarded – undo
282 291
 		}
283 292
 	}
284 293
 
294
+	/**
295
+	 * @param string $class
296
+	 */
285 297
 	private function checkBlackListMethod($class, $functionName, Node $node) {
286 298
 		$name = $class . '::' . $functionName;
287 299
 		$lowerName = strtolower($name);
@@ -296,6 +308,9 @@  discard block
 block discarded – undo
296 308
 		}
297 309
 	}
298 310
 
311
+	/**
312
+	 * @param string $name
313
+	 */
299 314
 	private function buildReason($name, $errorCode) {
300 315
 		if (isset($this->errorMessages[$errorCode])) {
301 316
 			$desc = $this->list->getDescription($errorCode, $name);
Please login to merge, or discard this patch.