owncloud / core

apps/dav/lib/CalDAV/CalDavBackend.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use OCA\DAV\DAV\Sharing\Backend;
 use OCA\DAV\DAV\Sharing\IShareable;
 use OCP\DB\QueryBuilder\IQueryBuilder;
-use OCP\IConfig;
 use OCP\IDBConnection;
 use OCP\Security\ISecureRandom;
 use Sabre\CalDAV\Backend\AbstractBackend;

Doc Comments +11 added lines, -5 removed lines

@@ -267,6 +267,9 @@ 
 		return \array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = \array_values($this->propertyMap);
@@ -717,9 +720,9 @@ 
 	 *
 	 * This method must return null if the object did not exist.
 	 *
-	 * @param mixed $calendarId
+	 * @param integer $calendarId
 	 * @param string $objectUri
-	 * @return array|null
+	 * @return \Sabre\VObject\Component\VCalendar
 	 */
 	public function getCalendarObject($calendarId, $objectUri) {
 		$query = $this->db->getQueryBuilder();
@@ -809,7 +812,7 @@ 
 	 * calendar-data. If the result of a subsequent GET to this object is not
 	 * the exact same as this request body, you should omit the ETag.
 	 *
-	 * @param mixed $calendarId
+	 * @param integer $calendarId
 	 * @param string $objectUri
 	 * @param string $calendarData
 	 * @return string
@@ -855,7 +858,7 @@ 
 	 * calendar-data. If the result of a subsequent GET to this object is not
 	 * the exact same as this request body, you should omit the ETag.
 	 *
-	 * @param mixed $calendarId
+	 * @param integer $calendarId
 	 * @param string $objectUri
 	 * @param string $calendarData
 	 * @return string
@@ -1260,7 +1263,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 * @throws Forbidden
 	 */
 	public function createSubscription($principalUri, $uri, array $properties) {
@@ -1658,6 +1661,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2 = null) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

apps/comments/lib/Dav/EntityCollection.php

Doc Comments +1 added lines, -1 removed lines

@@ -116,7 +116,7 @@
 	/**
 	 * Returns an array with all the child nodes
 	 *
-	 * @return \Sabre\DAV\INode[]
+	 * @return CommentNode[]
 	 */
 	public function getChildren() {
 		return $this->findChildren();

apps/dav/lib/Connector/Sabre/ShareTypeList.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 	 * The deserialize method is called during xml parsing.
 	 *
 	 * @param Reader $reader
-	 * @return mixed
+	 * @return null|ShareTypeList
 	 */
 	public static function xmlDeserialize(Reader $reader) {
 		$shareTypes = [];

apps/dav/lib/Connector/Sabre/TagList.php

Doc Comments +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
 	 * the next element.
 	 *
 	 * @param Reader $reader
-	 * @return mixed
+	 * @return null|TagList
 	 */
 	public static function xmlDeserialize(Reader $reader) {
 		$tags = [];

apps/dav/lib/DAV/FileCustomPropertiesBackend.php

Doc Comments +1 added lines, -1 removed lines

@@ -223,7 +223,7 @@
 
 	/**
 	 * @param string $path
-	 * @return INode|null
+	 * @return null|Node
 	 */
 	protected function getNodeForPath($path) {
 		$node = parent::getNodeForPath($path);

apps/dav/lib/DAV/SystemPrincipalBackend.php

Doc Comments +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
 	 * Returns the list of members for a group-principal
 	 *
 	 * @param string $principal
-	 * @return array
+	 * @return string[]
 	 */
 	public function getGroupMemberSet($principal) {
 		// TODO: for now the group principal has only one member, the user itself

apps/dav/lib/Upload/AssemblyStreamZsync.php

Doc Comments +5 added lines, -2 removed lines

@@ -183,7 +183,7 @@ 
 	/**
 	 * @param IFile[] $nodes
 	 * @param IFile $backingFile
-	 * @param $fileLength
+	 * @param string $fileLength
 	 * @return resource
 	 *
 	 * @throws \BadMethodCallException
@@ -207,6 +207,9 @@ 
 		return $wrapped;
 	}
 
+	/**
+	 * @param integer $current
+	 */
 	protected function getNextNodeStart($current) {
 		foreach ($this->sortedNodes as $node) {
 			if ($current >= $node['start'] && $current < $node['end']) {
@@ -220,7 +223,7 @@ 
 	}
 
 	/**
-	 * @param $pos
+	 * @param integer $pos
 	 */
 	protected function getNodeForPosition($pos) {
 		foreach ($this->sortedNodes as $node) {

apps/dav/lib/Upload/ChunkingPluginZsync.php

Doc Comments +1 added lines

@@ -107,6 +107,7 @@
 	 *
 	 * @param string &$zsyncMetadata actual metadata
 	 * @param string $destination destination path
+	 * @param string|null $zsyncMetadata
 	 */
 	private function postMoveZsync(&$zsyncMetadata, $destination) {
 		if (!$zsyncMetadata) {

apps/files_sharing/lib/External/Manager.php

Doc Comments +3 added lines

@@ -308,6 +308,9 @@
 		return $result;
 	}
 
+	/**
+	 * @param string $mountPoint
+	 */
 	public function removeShare($mountPoint) {
 		$mountPointObj = $this->mountManager->find($mountPoint);
 		$id = $mountPointObj->getStorage()->getCache()->getId('');