Completed
Push — master ( 0de15a...be9b68 )
by Jan-Christoph
09:52
created
lib/private/integritycheck/helpers/fileaccesshelper.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 	 * Wrapper around file_get_contents($filename, $data)
33 33
 	 *
34 34
 	 * @param string $filename
35
-	 * @return string|false
35
+	 * @return string
36 36
 	 */
37 37
 	public function file_get_contents($filename) {
38 38
 		return file_get_contents($filename);
@@ -52,8 +52,8 @@  discard block
 block discarded – undo
52 52
 	 * Wrapper around file_put_contents($filename, $data)
53 53
 	 *
54 54
 	 * @param string $filename
55
-	 * @param $data
56
-	 * @return int|false
55
+	 * @param string $data
56
+	 * @return integer
57 57
 	 */
58 58
 	public function file_put_contents($filename, $data) {
59 59
 		return file_put_contents($filename, $data);
Please login to merge, or discard this patch.
lib/private/files/storage/storage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,7 @@  discard block
 block discarded – undo
99 99
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
100 100
 	 * @param \OCP\Lock\ILockingProvider $provider
101 101
 	 * @throws \OCP\Lock\LockedException
102
+	 * @return void
102 103
 	 */
103 104
 	public function acquireLock($path, $type, ILockingProvider $provider);
104 105
 
@@ -106,6 +107,7 @@  discard block
 block discarded – undo
106 107
 	 * @param string $path The path of the file to release the lock for
107 108
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
108 109
 	 * @param \OCP\Lock\ILockingProvider $provider
110
+	 * @return void
109 111
 	 */
110 112
 	public function releaseLock($path, $type, ILockingProvider $provider);
111 113
 
@@ -114,6 +116,7 @@  discard block
 block discarded – undo
114 116
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
115 117
 	 * @param \OCP\Lock\ILockingProvider $provider
116 118
 	 * @throws \OCP\Lock\LockedException
119
+	 * @return void
117 120
 	 */
118 121
 	public function changeLock($path, $type, ILockingProvider $provider);
119 122
 }
Please login to merge, or discard this patch.
lib/private/files/view.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 	 * and does not take the chroot into account )
196 196
 	 *
197 197
 	 * @param string $path
198
-	 * @return \OCP\Files\Mount\IMountPoint
198
+	 * @return Mount\MountPoint|null
199 199
 	 */
200 200
 	public function getMount($path) {
201 201
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -906,7 +906,7 @@  discard block
 block discarded – undo
906 906
 
907 907
 	/**
908 908
 	 * @param string $path
909
-	 * @return bool|string
909
+	 * @return string|false
910 910
 	 * @throws \OCP\Files\InvalidPathException
911 911
 	 */
912 912
 	public function toTmpFile($path) {
@@ -2029,7 +2029,7 @@  discard block
 block discarded – undo
2029 2029
 
2030 2030
 	/**
2031 2031
 	 * @param string $filename
2032
-	 * @return array
2032
+	 * @return string[]
2033 2033
 	 * @throws \OC\User\NoUserException
2034 2034
 	 * @throws NotFoundException
2035 2035
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/carddav/syncservice.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@
 block discarded – undo
227 227
 	}
228 228
 
229 229
 	/**
230
-	 * @return array|null
230
+	 * @return string
231 231
 	 */
232 232
 	public function getLocalSystemAddressBook() {
233 233
 		if (is_null($this->localSystemAddressBook)) {
Please login to merge, or discard this patch.
lib/private/db/querybuilder/compositeexpression.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 	/**
53 53
 	 * Adds an expression to composite expression.
54 54
 	 *
55
-	 * @param mixed $part
55
+	 * @param string $part
56 56
 	 *
57 57
 	 * @return \OCP\DB\QueryBuilder\ICompositeExpression
58 58
 	 */
Please login to merge, or discard this patch.
lib/private/files/filesystem.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,6 @@
 block discarded – undo
62 62
 use OC\Files\Mount\MountPoint;
63 63
 use OC\Files\Storage\StorageFactory;
64 64
 use OCP\Files\Config\IMountProvider;
65
-use OCP\Files\Mount\IMountPoint;
66 65
 use OCP\Files\NotFoundException;
67 66
 use OCP\IUserManager;
68 67
 
Please login to merge, or discard this patch.
Doc Comments   +29 added lines, -2 removed lines patch added patch discarded remove patch
@@ -337,6 +337,9 @@  discard block
 block discarded – undo
337 337
 		}
338 338
 	}
339 339
 
340
+	/**
341
+	 * @param string $root
342
+	 */
340 343
 	static public function init($user, $root) {
341 344
 		if (self::$defaultInstance) {
342 345
 			return false;
@@ -517,7 +520,7 @@  discard block
 block discarded – undo
517 520
 	/**
518 521
 	 * mount an \OC\Files\Storage\Storage in our virtual filesystem
519 522
 	 *
520
-	 * @param \OC\Files\Storage\Storage|string $class
523
+	 * @param string $class
521 524
 	 * @param array $arguments
522 525
 	 * @param string $mountpoint
523 526
 	 */
@@ -628,6 +631,7 @@  discard block
 block discarded – undo
628 631
 
629 632
 	/**
630 633
 	 * following functions are equivalent to their php builtin equivalents for arguments/return values.
634
+	 * @param string $path
631 635
 	 */
632 636
 	static public function mkdir($path) {
633 637
 		return self::$defaultInstance->mkdir($path);
@@ -649,6 +653,9 @@  discard block
 block discarded – undo
649 653
 		return self::$defaultInstance->is_dir($path);
650 654
 	}
651 655
 
656
+	/**
657
+	 * @param string $path
658
+	 */
652 659
 	static public function is_file($path) {
653 660
 		return self::$defaultInstance->is_file($path);
654 661
 	}
@@ -661,6 +668,9 @@  discard block
 block discarded – undo
661 668
 		return self::$defaultInstance->filetype($path);
662 669
 	}
663 670
 
671
+	/**
672
+	 * @param string $path
673
+	 */
664 674
 	static public function filesize($path) {
665 675
 		return self::$defaultInstance->filesize($path);
666 676
 	}
@@ -673,6 +683,9 @@  discard block
 block discarded – undo
673 683
 		return self::$defaultInstance->isCreatable($path);
674 684
 	}
675 685
 
686
+	/**
687
+	 * @param string $path
688
+	 */
676 689
 	static public function isReadable($path) {
677 690
 		return self::$defaultInstance->isReadable($path);
678 691
 	}
@@ -685,6 +698,9 @@  discard block
 block discarded – undo
685 698
 		return self::$defaultInstance->isDeletable($path);
686 699
 	}
687 700
 
701
+	/**
702
+	 * @param string $path
703
+	 */
688 704
 	static public function isSharable($path) {
689 705
 		return self::$defaultInstance->isSharable($path);
690 706
 	}
@@ -702,6 +718,7 @@  discard block
 block discarded – undo
702 718
 	}
703 719
 
704 720
 	/**
721
+	 * @param string $path
705 722
 	 * @return string
706 723
 	 */
707 724
 	static public function file_get_contents($path) {
@@ -724,6 +741,10 @@  discard block
 block discarded – undo
724 741
 		return self::$defaultInstance->copy($path1, $path2);
725 742
 	}
726 743
 
744
+	/**
745
+	 * @param string $path
746
+	 * @param string $mode
747
+	 */
727 748
 	static public function fopen($path, $mode) {
728 749
 		return self::$defaultInstance->fopen($path, $mode);
729 750
 	}
@@ -739,6 +760,9 @@  discard block
 block discarded – undo
739 760
 		return self::$defaultInstance->fromTmpFile($tmpFile, $path);
740 761
 	}
741 762
 
763
+	/**
764
+	 * @param string $path
765
+	 */
742 766
 	static public function getMimeType($path) {
743 767
 		return self::$defaultInstance->getMimeType($path);
744 768
 	}
@@ -751,6 +775,9 @@  discard block
 block discarded – undo
751 775
 		return self::$defaultInstance->free_space($path);
752 776
 	}
753 777
 
778
+	/**
779
+	 * @param string $query
780
+	 */
754 781
 	static public function search($query) {
755 782
 		return self::$defaultInstance->search($query);
756 783
 	}
@@ -860,7 +887,7 @@  discard block
 block discarded – undo
860 887
 	 * @param string $path
861 888
 	 * @param boolean $includeMountPoints whether to add mountpoint sizes,
862 889
 	 * defaults to true
863
-	 * @return \OC\Files\FileInfo|bool False if file does not exist
890
+	 * @return \OCP\Files\FileInfo|null False if file does not exist
864 891
 	 */
865 892
 	public static function getFileInfo($path, $includeMountPoints = true) {
866 893
 		return self::$defaultInstance->getFileInfo($path, $includeMountPoints);
Please login to merge, or discard this patch.
lib/private/security/credentialsmanager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  */
21 21
 
22 22
 use OC\Share\MailNotifications;
23
-use OCP\IConfig;
24 23
 use OCP\IL10N;
25 24
 use OCP\IUser;
26 25
 use OCP\Mail\IMailer;
Please login to merge, or discard this patch.
apps/dav/lib/comments/entitycollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 	/**
107 107
 	 * Returns an array with all the child nodes
108 108
 	 *
109
-	 * @return \Sabre\DAV\INode[]
109
+	 * @return CommentNode[]
110 110
 	 */
111 111
 	function getChildren() {
112 112
 		return $this->findChildren();
Please login to merge, or discard this patch.
apps/dav/lib/comments/rootcollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@
 block discarded – undo
145 145
 	/**
146 146
 	 * Returns an array with all the child nodes
147 147
 	 *
148
-	 * @return \Sabre\DAV\INode[]
148
+	 * @return EntityTypeCollection[]
149 149
 	 */
150 150
 	function getChildren() {
151 151
 		$this->initCollections();
Please login to merge, or discard this patch.