Completed
Pull Request — master (#31159)
by Martin
12:03
created
apps/files_sharing/lib/Migration.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,6 @@
 block discarded – undo
128 128
 	/**
129 129
 	 * Get $n re-shares from the database
130 130
 	 *
131
-	 * @param int $n The max number of shares to fetch
132 131
 	 * @return \Doctrine\DBAL\Driver\Statement
133 132
 	 */
134 133
 	private function getReShares() {
Please login to merge, or discard this patch.
lib/public/Files/StorageTimeoutException.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	 * StorageTimeoutException constructor.
31 31
 	 *
32 32
 	 * @param string $message
33
-	 * @param int $code
34 33
 	 * @param \Exception $previous
35 34
 	 * @since 9.0.0
36 35
 	 */
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/FederatedShareProvider.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
 	/**
323 323
 	 * store remote ID in federated reShare table
324 324
 	 *
325
-	 * @param $shareId
325
+	 * @param integer $shareId
326 326
 	 * @param $remoteId
327 327
 	 */
328 328
 	public function storeRemoteId($shareId, $remoteId) {
@@ -653,7 +653,7 @@  discard block
 block discarded – undo
653 653
 	/**
654 654
 	 * get database row of a give share
655 655
 	 *
656
-	 * @param $id
656
+	 * @param integer $id
657 657
 	 * @return array
658 658
 	 * @throws ShareNotFound
659 659
 	 */
Please login to merge, or discard this patch.
lib/public/SystemTag/ISystemTagManager.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -102,17 +102,19 @@  discard block
 block discarded – undo
102 102
 	 * with the same attributes
103 103
 	 *
104 104
 	 * @since 9.0.0
105
+	 * @return void
105 106
 	 */
106 107
 	public function updateTag($tagId, $newName, $userVisible, $userAssignable);
107 108
 
108 109
 	/**
109 110
 	 * Delete the given tags from the database and all their relationships.
110 111
 	 *
111
-	 * @param string|array $tagIds array of tag ids
112
+	 * @param string $tagIds array of tag ids
112 113
 	 *
113 114
 	 * @throws \OCP\SystemTag\TagNotFoundException if at least one tag did not exist
114 115
 	 *
115 116
 	 * @since 9.0.0
117
+	 * @return void
116 118
 	 */
117 119
 	public function deleteTags($tagIds);
118 120
 
@@ -123,7 +125,7 @@  discard block
 block discarded – undo
123 125
 	 * @param ISystemTag $tag tag to check permission for
124 126
 	 * @param IUser $user user to check permission for
125 127
 	 *
126
-	 * @return true if the user is allowed to assign/unassign the tag, false otherwise
128
+	 * @return boolean if the user is allowed to assign/unassign the tag, false otherwise
127 129
 	 *
128 130
 	 * @since 9.1.0
129 131
 	 */
@@ -133,9 +135,9 @@  discard block
 block discarded – undo
133 135
 	 * Checks whether the given user is allowed to see the tag with the given id.
134 136
 	 *
135 137
 	 * @param ISystemTag $tag tag to check permission for
136
-	 * @param IUser $user user to check permission for
138
+	 * @param IUser $userId user to check permission for
137 139
 	 *
138
-	 * @return true if the user can see the tag, false otherwise
140
+	 * @return boolean if the user can see the tag, false otherwise
139 141
 	 *
140 142
 	 * @since 9.1.0
141 143
 	 */
@@ -148,6 +150,7 @@  discard block
 block discarded – undo
148 150
 	 * @param string[] $groupIds group ids of groups that can assign/unassign the tag
149 151
 	 *
150 152
 	 * @since 9.1.0
153
+	 * @return void
151 154
 	 */
152 155
 	public function setTagGroups(ISystemTag $tag, $groupIds);
153 156
 
Please login to merge, or discard this patch.
lib/private/Files/View.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 	 * and does not take the chroot into account )
198 198
 	 *
199 199
 	 * @param string $path
200
-	 * @return \OCP\Files\Mount\IMountPoint
200
+	 * @return Mount\MountPoint|null
201 201
 	 */
202 202
 	public function getMount($path) {
203 203
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -960,7 +960,7 @@  discard block
 block discarded – undo
960 960
 
961 961
 	/**
962 962
 	 * @param string $path
963
-	 * @return bool|string
963
+	 * @return string|false
964 964
 	 * @throws \OCP\Files\InvalidPathException
965 965
 	 */
966 966
 	public function toTmpFile($path) {
@@ -1075,7 +1075,7 @@  discard block
 block discarded – undo
1075 1075
 	 * @param string $path
1076 1076
 	 * @param array $hooks (optional)
1077 1077
 	 * @param mixed $extraParam (optional)
1078
-	 * @return mixed
1078
+	 * @return string
1079 1079
 	 * @throws \Exception
1080 1080
 	 *
1081 1081
 	 * This method takes requests for basic filesystem functions (e.g. reading & writing
@@ -2083,7 +2083,7 @@  discard block
 block discarded – undo
2083 2083
 
2084 2084
 	/**
2085 2085
 	 * @param string $filename
2086
-	 * @return array
2086
+	 * @return string[]
2087 2087
 	 * @throws \OC\User\NoUserException
2088 2088
 	 * @throws NotFoundException
2089 2089
 	 */
Please login to merge, or discard this patch.
core/Controller/TokenController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 	/**
53 53
 	 * @param string $appName
54 54
 	 * @param IRequest $request
55
-	 * @param Manager $userManager
55
+	 * @param UserManager $userManager
56 56
 	 * @param DefaultTokenProvider $tokenProvider
57 57
 	 * @param ISecureRandom $secureRandom
58 58
 	 */
Please login to merge, or discard this patch.
apps/files_sharing/lib/Helper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -278,6 +278,7 @@
 block discarded – undo
278 278
 	 * get default share folder
279 279
 	 *
280 280
 	 * @param \OC\Files\View
281
+	 * @param View $view
281 282
 	 * @return string
282 283
 	 */
283 284
 	public static function getShareFolder($view = null) {
Please login to merge, or discard this patch.
lib/private/Files/Filesystem.php 1 patch
Doc Comments   +28 added lines, -2 removed lines patch added patch discarded remove patch
@@ -355,6 +355,9 @@  discard block
 block discarded – undo
355 355
 		}
356 356
 	}
357 357
 
358
+	/**
359
+	 * @param string $root
360
+	 */
358 361
 	static public function init($user, $root) {
359 362
 		if (self::$defaultInstance) {
360 363
 			return false;
@@ -494,7 +497,7 @@  discard block
 block discarded – undo
494 497
 	/**
495 498
 	 * mount an \OC\Files\Storage\Storage in our virtual filesystem
496 499
 	 *
497
-	 * @param \OC\Files\Storage\Storage|string $class
500
+	 * @param string $class
498 501
 	 * @param array $arguments
499 502
 	 * @param string $mountpoint
500 503
 	 */
@@ -626,6 +629,9 @@  discard block
 block discarded – undo
626 629
 		return self::$defaultInstance->is_dir($path);
627 630
 	}
628 631
 
632
+	/**
633
+	 * @param string $path
634
+	 */
629 635
 	static public function is_file($path) {
630 636
 		return self::$defaultInstance->is_file($path);
631 637
 	}
@@ -638,6 +644,9 @@  discard block
 block discarded – undo
638 644
 		return self::$defaultInstance->filetype($path);
639 645
 	}
640 646
 
647
+	/**
648
+	 * @param string $path
649
+	 */
641 650
 	static public function filesize($path) {
642 651
 		return self::$defaultInstance->filesize($path);
643 652
 	}
@@ -650,6 +659,9 @@  discard block
 block discarded – undo
650 659
 		return self::$defaultInstance->isCreatable($path);
651 660
 	}
652 661
 
662
+	/**
663
+	 * @param string $path
664
+	 */
653 665
 	static public function isReadable($path) {
654 666
 		return self::$defaultInstance->isReadable($path);
655 667
 	}
@@ -662,6 +674,9 @@  discard block
 block discarded – undo
662 674
 		return self::$defaultInstance->isDeletable($path);
663 675
 	}
664 676
 
677
+	/**
678
+	 * @param string $path
679
+	 */
665 680
 	static public function isSharable($path) {
666 681
 		return self::$defaultInstance->isSharable($path);
667 682
 	}
@@ -679,6 +694,7 @@  discard block
 block discarded – undo
679 694
 	}
680 695
 
681 696
 	/**
697
+	 * @param string $path
682 698
 	 * @return string
683 699
 	 */
684 700
 	static public function file_get_contents($path) {
@@ -701,6 +717,10 @@  discard block
 block discarded – undo
701 717
 		return self::$defaultInstance->copy($path1, $path2);
702 718
 	}
703 719
 
720
+	/**
721
+	 * @param string $path
722
+	 * @param string $mode
723
+	 */
704 724
 	static public function fopen($path, $mode) {
705 725
 		return self::$defaultInstance->fopen($path, $mode);
706 726
 	}
@@ -716,6 +736,9 @@  discard block
 block discarded – undo
716 736
 		return self::$defaultInstance->fromTmpFile($tmpFile, $path);
717 737
 	}
718 738
 
739
+	/**
740
+	 * @param string $path
741
+	 */
719 742
 	static public function getMimeType($path) {
720 743
 		return self::$defaultInstance->getMimeType($path);
721 744
 	}
@@ -728,6 +751,9 @@  discard block
 block discarded – undo
728 751
 		return self::$defaultInstance->free_space($path);
729 752
 	}
730 753
 
754
+	/**
755
+	 * @param string $query
756
+	 */
731 757
 	static public function search($query) {
732 758
 		return self::$defaultInstance->search($query);
733 759
 	}
@@ -836,7 +862,7 @@  discard block
 block discarded – undo
836 862
 	 * @param string $path
837 863
 	 * @param boolean $includeMountPoints whether to add mountpoint sizes,
838 864
 	 * defaults to true
839
-	 * @return \OC\Files\FileInfo|bool False if file does not exist
865
+	 * @return \OCP\Files\FileInfo|null False if file does not exist
840 866
 	 */
841 867
 	public static function getFileInfo($path, $includeMountPoints = true) {
842 868
 		return self::$defaultInstance->getFileInfo($path, $includeMountPoints);
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Backend/SMB.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
 	}
57 57
 
58 58
 	/**
59
-	 * @param StorageConfig $storage
59
+	 * @param IStorageConfig $storage
60 60
 	 * @param IUser $user
61 61
 	 */
62 62
 	public function manipulateStorageConfig(IStorageConfig &$storage, IUser $user = null) {
Please login to merge, or discard this patch.