owncloud / core

apps/files_sharing/lib/Hooks.php

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use OCP\Share\IShare;
 use Symfony\Component\EventDispatcher\GenericEvent;
 use OCA\Files_Sharing\Service\NotificationPublisher;
-use OCP\Share\Exceptions\ShareNotFound;
 
 class Hooks {
 	/**

Doc Comments +4 added lines

@@ -138,6 +138,10 @@
 		);
 	}
 
+	/**
+	 * @param IShare[] $shares
+	 * @param string $fileId
+	 */
 	private function filterSharesByFileId($shares, $fileId) {
 		return \array_filter($shares, function (IShare $share) use ($fileId) {
 			return \strval($share->getNodeId()) === \strval($fileId);

core/Command/User/SyncBackend.php

Doc Comments +1 added lines, -1 removed lines

@@ -310,7 +310,7 @@
 	 * @param string[] $removedUsers
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
-	 * @param $missingAccountsAction
+	 * @param string $missingAccountsAction
 	 */
 	private function handleRemovedUsers(array $removedUsers, InputInterface $input, OutputInterface $output, $missingAccountsAction) {
 		if (empty($removedUsers)) {

lib/private/Files/External/Service/GlobalStoragesService.php

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 namespace OC\Files\External\Service;
 
 use OC\Files\Filesystem;
-
 use OCP\Files\External\IStorageConfig;
 use OCP\Files\External\IStoragesBackendService;
 use OCP\Files\External\Service\IGlobalStoragesService;

apps/files_sharing/lib/API/Share20OCS.php

Doc Comments +3 added lines, -2 removed lines

@@ -511,7 +511,7 @@ 
 	/**
 	 * @param \OCP\Files\File|\OCP\Files\Folder $node
 	 * @param boolean $includeTags include tags in response
-	 * @param int|null $stateFilter state filter or empty for all, defaults to 0 (accepted)
+	 * @param integer $stateFilter state filter or empty for all, defaults to 0 (accepted)
 	 * @return \OC\OCS\Result
 	 */
 	private function getSharedWithMe($node = null, $includeTags, $stateFilter = 0) {
@@ -870,7 +870,7 @@ 
 	}
 
 	/**
-	 * @param $id
+	 * @param integer $id
 	 * @param $state
 	 * @return \OC\OCS\Result
 	 */
@@ -1041,6 +1041,7 @@ 
 	 * not support this we need to check all backends.
 	 *
 	 * @param string $id
+	 * @param string $recipient
 	 * @return \OCP\Share\IShare
 	 * @throws ShareNotFound
 	 */

apps/dav/lib/Connector/Sabre/AutorenamePlugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 	/**
 	 * @param RequestInterface $request
 	 * @param ResponseInterface $response
-	 * @return bool|void
+	 * @return null|false
 	 * @throws \Sabre\DAV\Exception\BadRequest
 	 * @throws \Sabre\DAV\Exception\Conflict
 	 * @throws \Sabre\DAV\Exception\NotFound

apps/files_trashbin/lib/Trashbin.php

Doc Comments +6 added lines, -2 removed lines

@@ -259,6 +259,9 @@ 
 
 	/**
 	 *
+	 * @param string $targetFilename
+	 * @param string $targetLocation
+	 * @param integer $timestamp
 	 */
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -784,7 +787,7 @@ 
 	 * if the size limit for the trash bin is reached, we delete the oldest
 	 * files in the trash bin until we meet the limit again
 	 *
-	 * @param array $files
+	 * @param \OCP\Files\FileInfo[] $files
 	 * @param string $user
 	 * @param int $availableSpace available disc space
 	 * @return int size of deleted files
@@ -818,7 +821,7 @@ 
 	/**
 	 * delete files older then max storage time
 	 *
-	 * @param array $files list of files sorted by mtime
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
 	 * @param string $user
 	 * @return integer[] size of deleted files and number of deleted files
 	 */
@@ -888,6 +891,7 @@ 
 	 *
 	 * @param string $filename name of the file which should be restored
 	 * @param int $timestamp timestamp when the file was deleted
+	 * @param string|boolean $user
 	 * @return array
 	 */
 	private static function getVersionsFromTrash($filename, $timestamp, $user) {

lib/private/Files/Storage/Common.php

Doc Comments +1 added lines, -1 removed lines

@@ -704,7 +704,7 @@
 	}
 
 	/**
-	 * @param $internalPath
+	 * @param string $internalPath
 	 * @return array
 	 */
 	protected function convertInternalPathToGlobalPath($internalPath) {

Unused Use Statements -1 removed lines

@@ -51,7 +51,6 @@
 use OCP\Files\InvalidPathException;
 use OCP\Files\ReservedWordException;
 use OCP\Files\Storage\ILockingStorage;
-use OCP\Files\Storage\IStorage;
 use OCP\Files\Storage\IVersionedStorage;
 use OCP\Lock\ILockingProvider;
 

apps/dav/lib/Connector/Sabre/Auth.php

Doc Comments +1 added lines, -1 removed lines

@@ -255,7 +255,7 @@
 	}
 
 	/**
-	 * @param $user
+	 * @param \OCP\IUser|null $user
 	 * @throws ServiceUnavailable
 	 */
 	private function checkAccountModule($user) {

apps/files_versions/lib/Storage.php

Doc Comments +3 added lines

@@ -315,6 +315,9 @@
 		}
 	}
 
+	/**
+	 * @param string $revision
+	 */
 	public static function restoreVersion($uid, $filename, $fileToRestore, $revision) {
 		if (\OC::$server->getConfig()->getSystemValue('files_versions', Storage::DEFAULTENABLED) !== true) {
 			return false;