Completed
Pull Request — master (#24661)
by Roeland
28:15
created
lib/private/Tags.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -741,11 +741,19 @@  discard block
 block discarded – undo
741 741
 	}
742 742
 
743 743
 	// case-insensitive array_search
744
+
745
+	/**
746
+	 * @param string $needle
747
+	 */
744 748
 	protected function array_searchi($needle, $haystack, $mem='getName') {
745 749
 		if(!is_array($haystack)) {
746 750
 			return false;
747 751
 		}
748 752
 		return array_search(strtolower($needle), array_map(
753
+
754
+			/**
755
+			 * @param string $tag
756
+			 */
749 757
 			function($tag) use($mem) {
750 758
 				return strtolower(call_user_func(array($tag, $mem)));
751 759
 			}, $haystack)
@@ -770,7 +778,7 @@  discard block
 block discarded – undo
770 778
 	* Get a tag by its name.
771 779
 	*
772 780
 	* @param string $name The tag name.
773
-	* @return integer|bool The tag object's offset within the $this->tags
781
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
774 782
 	*                      array or false if it doesn't exist.
775 783
 	*/
776 784
 	private function getTagByName($name) {
@@ -781,7 +789,7 @@  discard block
 block discarded – undo
781 789
 	* Get a tag by its ID.
782 790
 	*
783 791
 	* @param string $id The tag ID to look for.
784
-	* @return integer|bool The tag object's offset within the $this->tags
792
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
785 793
 	*                      array or false if it doesn't exist.
786 794
 	*/
787 795
 	private function getTagById($id) {
Please login to merge, or discard this patch.
lib/private/legacy/api.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@
 block discarded – undo
329 329
 
330 330
 	/**
331 331
 	 * http basic auth
332
-	 * @return string|false (username, or false on failure)
332
+	 * @return string (username, or false on failure)
333 333
 	 */
334 334
 	private static function loginUser() {
335 335
 		if(self::$isLoggedIn === true) {
Please login to merge, or discard this patch.
lib/private/legacy/db.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -153,7 +153,6 @@  discard block
 block discarded – undo
153 153
 	/**
154 154
 	 * saves database schema to xml file
155 155
 	 * @param string $file name of file
156
-	 * @param int $mode
157 156
 	 * @return bool
158 157
 	 *
159 158
 	 * TODO: write more documentation
@@ -197,7 +196,7 @@  discard block
 block discarded – undo
197 196
 	 * simulate the database schema update
198 197
 	 * @param string $file file to read structure from
199 198
 	 * @throws Exception
200
-	 * @return string|boolean
199
+	 * @return boolean
201 200
 	 */
202 201
 	public static function simulateUpdateDbFromStructure($file) {
203 202
 		$schemaManager = self::getMDB2SchemaManager();
Please login to merge, or discard this patch.
lib/private/legacy/eventsource.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * send a message to the client
89 89
 	 *
90 90
 	 * @param string $type
91
-	 * @param mixed $data
91
+	 * @param string $data
92 92
 	 *
93 93
 	 * @throws \BadMethodCallException
94 94
 	 * if only one parameter is given, a typeless message will be send with that parameter as data
Please login to merge, or discard this patch.
lib/private/legacy/util.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1434,7 +1434,7 @@
 block discarded – undo
1434 1434
 	 * Normalize a unicode string
1435 1435
 	 *
1436 1436
 	 * @param string $value a not normalized string
1437
-	 * @return bool|string
1437
+	 * @return string
1438 1438
 	 */
1439 1439
 	public static function normalizeUnicode($value) {
1440 1440
 		if(Normalizer::isNormalized($value)) {
Please login to merge, or discard this patch.
lib/private/Group/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@
 block discarded – undo
152 152
 
153 153
 	/**
154 154
 	 * @param string $gid
155
-	 * @return \OCP\IGroup
155
+	 * @return null|Group
156 156
 	 */
157 157
 	protected function getGroupObject($gid) {
158 158
 		$backends = array();
Please login to merge, or discard this patch.
lib/private/Installer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -476,7 +476,7 @@
 block discarded – undo
476 476
 
477 477
 	/**
478 478
 	 * Removes an app
479
-	 * @param string $name name of the application to remove
479
+	 * @param string $appId
480 480
 	 * @return boolean
481 481
 	 *
482 482
 	 *
Please login to merge, or discard this patch.
lib/private/legacy/helper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -524,7 +524,7 @@
 block discarded – undo
524 524
 	 * @param array $input The array to work on
525 525
 	 * @param int $case Either MB_CASE_UPPER or MB_CASE_LOWER (default)
526 526
 	 * @param string $encoding The encoding parameter is the character encoding. Defaults to UTF-8
527
-	 * @return array
527
+	 * @return string
528 528
 	 * @since 4.5.0
529 529
 	 */
530 530
 	public static function mb_array_change_key_case($input, $case = MB_CASE_LOWER, $encoding = 'UTF-8') {
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
 	/**
333 333
 	 * get the users email address
334 334
 	 *
335
-	 * @return string|null
335
+	 * @return string
336 336
 	 * @since 9.0.0
337 337
 	 */
338 338
 	public function getEMailAddress() {
@@ -417,6 +417,10 @@  discard block
 block discarded – undo
417 417
 		return $url;
418 418
 	}
419 419
 
420
+	/**
421
+	 * @param string $feature
422
+	 * @param string $value
423
+	 */
420 424
 	public function triggerChange($feature, $value = null) {
421 425
 		if ($this->emitter) {
422 426
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value));
Please login to merge, or discard this patch.