Completed
Pull Request — master (#24559)
by Christoph
10:08 queued 32s
created
apps/federation/appinfo/application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use OCA\Federation\Hooks;
31 31
 use OCA\Federation\Middleware\AddServerMiddleware;
32 32
 use OCA\Federation\SyncFederationAddressBooks;
33
-use OCA\Federation\SyncJob;
34 33
 use OCA\Federation\TrustedServers;
35 34
 use OCP\API;
36 35
 use OCP\App;
Please login to merge, or discard this patch.
apps/files/lib/Service/TagService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 
25 25
 namespace OCA\Files\Service;
26 26
 
27
-use OC\Files\FileInfo;
28 27
 use OCP\Files\Node;
29 28
 
30 29
 /**
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagPlugin.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -24,13 +24,11 @@
 block discarded – undo
24 24
 
25 25
 use OCP\IGroupManager;
26 26
 use OCP\IUserSession;
27
-use Sabre\DAV\Exception\NotFound;
28 27
 use Sabre\DAV\PropFind;
29 28
 use Sabre\DAV\PropPatch;
30 29
 use Sabre\DAV\Exception\BadRequest;
31 30
 use Sabre\DAV\Exception\UnsupportedMediaType;
32 31
 use Sabre\DAV\Exception\Conflict;
33
-
34 32
 use OCP\SystemTag\ISystemTag;
35 33
 use OCP\SystemTag\ISystemTagManager;
36 34
 use OCP\SystemTag\TagAlreadyExistsException;
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsByIdCollection.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -26,13 +26,11 @@
 block discarded – undo
26 26
 use Sabre\DAV\Exception\NotFound;
27 27
 use Sabre\DAV\Exception\BadRequest;
28 28
 use Sabre\DAV\ICollection;
29
-
30 29
 use OCP\SystemTag\ISystemTagManager;
31 30
 use OCP\SystemTag\ISystemTag;
32 31
 use OCP\SystemTag\TagNotFoundException;
33 32
 use OCP\IGroupManager;
34 33
 use OCP\IUserSession;
35
-use OC\User\NoUserException;
36 34
 
37 35
 class SystemTagsByIdCollection implements ICollection {
38 36
 
Please login to merge, or discard this patch.
core/Middleware/TwoFactorMiddleware.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -79,6 +79,10 @@
 block discarded – undo
79 79
 		// TODO: throw exceptions if necessary
80 80
 	}
81 81
 
82
+	/**
83
+	 * @param Controller $controller
84
+	 * @param string $methodName
85
+	 */
82 86
 	private function checkTwoFactor($controller, $methodName) {
83 87
 		// If two-factor auth is in progress disallow access to any controllers
84 88
 		// defined within "LoginController".
Please login to merge, or discard this patch.
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
  * make preview_icon available as a simple function
184 184
  * Returns the path to the preview of the image.
185 185
  * @param string $path path of file
186
- * @return link to the preview
186
+ * @return string to the preview
187 187
  *
188 188
  * For further information have a look at OC_Helper::previewIcon
189 189
  */
@@ -193,6 +193,7 @@  discard block
 block discarded – undo
193 193
 
194 194
 /**
195 195
  * @param string $path
196
+ * @param string $token
196 197
  */
197 198
 function publicPreview_icon ( $path, $token ) {
198 199
 	return OC_Helper::publicPreviewIcon( $path, $token );
Please login to merge, or discard this patch.
lib/private/Template/Base.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
 	/**
97 97
 	 * Appends a variable
98 98
 	 * @param string $key key
99
-	 * @param mixed $value value
99
+	 * @param string $value value
100 100
 	 * @return boolean|null
101 101
 	 *
102 102
 	 * This function assigns a variable in an array context. If the key already
Please login to merge, or discard this patch.
lib/private/SystemTag/SystemTagManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use OCP\SystemTag\TagAlreadyExistsException;
31 31
 use OCP\SystemTag\TagNotFoundException;
32 32
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
33
-use OCP\IUserManager;
34 33
 use OCP\IGroupManager;
35 34
 use OCP\SystemTag\ISystemTag;
36 35
 use OCP\IUser;
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/FederatedShareProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -463,7 +463,7 @@
 block discarded – undo
463 463
 	/**
464 464
 	 * get database row of a give share
465 465
 	 *
466
-	 * @param $id
466
+	 * @param integer $id
467 467
 	 * @return array
468 468
 	 * @throws ShareNotFound
469 469
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@
 block discarded – undo
25 25
 
26 26
 use OC\Share20\Share;
27 27
 use OCP\Files\IRootFolder;
28
-use OCP\IAppConfig;
29 28
 use OCP\IConfig;
30 29
 use OCP\IL10N;
31 30
 use OCP\ILogger;
Please login to merge, or discard this patch.