owncloud / core

lib/private/Share/MailNotifications.php

Doc Comments +3 added lines, -3 removed lines

@@ -189,10 +189,10 @@
 	 * inform recipient about public link share
 	 *
 	 * @param string $recipient recipient email address
-	 * @param string $filename the shared file
-	 * @param string $link the public link
 	 * @param array $options allows ['cc'] and ['bcc'] recipients
-	 * @param int $expiration expiration date (timestamp)
+	 * @param string $subject
+	 * @param boolean|string $htmlBody
+	 * @param boolean|string $textBody
 	 * @return string[] $result of failed recipients
 	 */
 	public function sendLinkShareMailFromBody($recipient, $subject, $htmlBody, $textBody, $options = []) {

lib/private/legacy/template.php

Doc Comments +1 added lines

@@ -322,6 +322,7 @@
 		* @param string $error_msg The error message to show
 		* @param string $hint An optional hint message - needs to be properly escaped
 		* @param int HTTP Status Code
+		* @param integer $httpStatusCode
 		*/
 	public static function printErrorPage($error_msg, $hint = '', $httpStatusCode = null) {
 		if ($error_msg === $hint) {

lib/private/AppFramework/Utility/ControllerMethodReflector.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
 	}
 
 	/**
-	 * @param object|string $object an object or classname
+	 * @param \OCP\AppFramework\Controller $object an object or classname
 	 * @param string $method the method which we want to inspect
 	 * @throws \ReflectionException
 	 */

lib/private/Files/Stream/Checksum.php

Doc Comments +6 added lines, -3 removed lines

@@ -61,8 +61,8 @@ 
 	}
 
 	/**
-	 * @param $source
-	 * @param $path
+	 * @param resource $source
+	 * @param string $path
 	 * @return resource
 	 */
 	public static function wrap($source, $path) {
@@ -122,6 +122,9 @@ 
 		return parent::stream_write($data);
 	}
 
+	/**
+	 * @param string $data
+	 */
 	private function updateHashingContexts($data) {
 		foreach ($this->hashingContexts as $ctx) {
 			\hash_update($ctx, $data);
@@ -195,7 +198,7 @@ 
 	}
 
 	/**
-	 * @return mixed
+	 * @return string
 	 * @return string
 	 */
 	private function getPathFromStreamContext() {

core/Command/User/ListUsers.php

Doc Comments +2 added lines

@@ -77,6 +77,8 @@
 
 	/**
 	 * If only a single attribute should be listed omit the key to make it fit in one row
+	 * @param string $key
+	 * @param boolean $useKey
 	 */
 	private function add(&$row, $key, $val, $useKey) {
 		if ($useKey) {

apps/dav/lib/Connector/Sabre/CorsPlugin.php

Doc Comments +2 added lines, -2 removed lines

@@ -91,7 +91,7 @@ 
 	 * This method should set up the required event subscriptions.
 	 *
 	 * @param \Sabre\DAV\Server $server
-	 * @return void
+	 * @return false|null
 	 */
 	public function initialize(\Sabre\DAV\Server $server) {
 		$this->server = $server;
@@ -129,7 +129,7 @@ 
 	 * @param RequestInterface $request
 	 * @param ResponseInterface $response
 	 *
-	 * @return false
+	 * @return false|null
 	 * @throws \InvalidArgumentException
 	 */
 	public function setOptionsRequestHeaders(RequestInterface $request, ResponseInterface $response) {

lib/private/Files/Mount/LocalHomeMountProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 	 *
 	 * @param IUser $user
 	 * @param IStorageFactory $loader
-	 * @return \OCP\Files\Mount\IMountPoint[]
+	 * @return MountPoint
 	 */
 	public function getHomeMountForUser(IUser $user, IStorageFactory $loader) {
 		$arguments = ['user' => $user];

lib/private/User/Database.php

Doc Comments +1 added lines, -2 removed lines

@@ -212,7 +212,6 @@ 
 
 	/**
 	 * Check if the password is correct
-	 * @param string $uid The username
 	 * @param string $password The password
 	 * @return string
 	 *
@@ -332,7 +331,7 @@ 
 	/**
 	 * counts the users in the database
 	 *
-	 * @return int|bool
+	 * @return integer
 	 */
 	public function countUsers() {
 		$query = \OC_DB::prepare('SELECT COUNT(*) FROM `*PREFIX*users`');

Unused Use Statements -1 removed lines

@@ -54,7 +54,6 @@
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\IUserBackend;
 use OCP\User\IProvidesDisplayNameBackend;
-use OCP\User\IProvidesEMailBackend;
 use OCP\User\IProvidesHomeBackend;
 use OCP\Util;
 

lib/private/User/Session.php

Doc Comments +5 added lines, -4 removed lines

@@ -303,7 +303,6 @@ 
 	/**
 	 * try to log in with the provided credentials
 	 *
-	 * @param string $uid
 	 * @param string $password
 	 * @return boolean|null
 	 * @throws LoginException
@@ -323,13 +322,12 @@ 
 	 * Checks token auth enforced
 	 * Checks 2FA enabled
 	 *
-	 * @param string $loginName
 	 * @param string $password
 	 * @param IRequest $request
 	 * @throws \InvalidArgumentException
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -999,6 +997,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IRequest $request
+	 */
 	public function verifyAuthHeaders($request) {
 		$shallLogout = false;
 		try {
@@ -1030,7 +1031,7 @@ 
 	}
 
 	/**
-	 * @param $includeBuiltIn
+	 * @param boolean $includeBuiltIn
 	 * @return \Generator | IAuthModule[]
 	 * @throws Exception
 	 */