Completed
Pull Request — master (#31967)
by Sujith
20:13 queued 30s
created
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -259,6 +259,9 @@  discard block
 block discarded – undo
259 259
 
260 260
 	/**
261 261
 	 *
262
+	 * @param string $targetFilename
263
+	 * @param string $targetLocation
264
+	 * @param integer $timestamp
262 265
 	 */
263 266
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
264 267
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -784,7 +787,7 @@  discard block
 block discarded – undo
784 787
 	 * if the size limit for the trash bin is reached, we delete the oldest
785 788
 	 * files in the trash bin until we meet the limit again
786 789
 	 *
787
-	 * @param array $files
790
+	 * @param \OCP\Files\FileInfo[] $files
788 791
 	 * @param string $user
789 792
 	 * @param int $availableSpace available disc space
790 793
 	 * @return int size of deleted files
@@ -818,7 +821,7 @@  discard block
 block discarded – undo
818 821
 	/**
819 822
 	 * delete files older then max storage time
820 823
 	 *
821
-	 * @param array $files list of files sorted by mtime
824
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
822 825
 	 * @param string $user
823 826
 	 * @return integer[] size of deleted files and number of deleted files
824 827
 	 */
@@ -888,6 +891,7 @@  discard block
 block discarded – undo
888 891
 	 *
889 892
 	 * @param string $filename name of the file which should be restored
890 893
 	 * @param int $timestamp timestamp when the file was deleted
894
+	 * @param string|boolean $user
891 895
 	 * @return array
892 896
 	 */
893 897
 	private static function getVersionsFromTrash($filename, $timestamp, $user) {
Please login to merge, or discard this patch.
lib/private/Files/Storage/Common.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -704,7 +704,7 @@
 block discarded – undo
704 704
 	}
705 705
 
706 706
 	/**
707
-	 * @param $internalPath
707
+	 * @param string $internalPath
708 708
 	 * @return array
709 709
 	 */
710 710
 	protected function convertInternalPathToGlobalPath($internalPath) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesSearchReportPlugin.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	 * This will be used in the {DAV:}supported-report-set property.
76 76
 	 *
77 77
 	 * @param string $uri
78
-	 * @return array
78
+	 * @return string[]
79 79
 	 */
80 80
 	public function getSupportedReportSet($uri) {
81 81
 		return [self::REPORT_NAME];
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 	 * @param string $reportName
88 88
 	 * @param mixed $report
89 89
 	 * @param string $uri
90
-	 * @return bool
90
+	 * @return null|false
91 91
 	 * @throws BadRequest
92 92
 	 * @throws NotImplemented
93 93
 	 * @internal param $ [] $report
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 use Sabre\DAV\Exception\NotImplemented;
29 29
 use OCA\DAV\Files\Xml\SearchRequest;
30 30
 use OCP\ISearch;
31
-use OC\Search\Result\File as FileResult;
32 31
 
33 32
 class FilesSearchReportPlugin extends ServerPlugin {
34 33
 	// namespace
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/Auth.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -255,7 +255,7 @@
 block discarded – undo
255 255
 	}
256 256
 
257 257
 	/**
258
-	 * @param $user
258
+	 * @param \OCP\IUser|null $user
259 259
 	 * @throws ServiceUnavailable
260 260
 	 */
261 261
 	private function checkAccountModule($user) {
Please login to merge, or discard this patch.
lib/private/legacy/util.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,6 @@
 block discarded – undo
59 59
 use OCP\Authentication\Exceptions\AccountCheckException;
60 60
 use OCP\Files\NoReadAccessException;
61 61
 use OCP\IConfig;
62
-use OCP\IGroupManager;
63 62
 use OCP\IUser;
64 63
 
65 64
 class OC_Util {
Please login to merge, or discard this patch.