Completed
Pull Request — master (#31967)
by Sujith
20:13 queued 30s
created
lib/private/AppFramework/Utility/ControllerMethodReflector.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 	}
44 44
 
45 45
 	/**
46
-	 * @param object|string $object an object or classname
46
+	 * @param \OCP\AppFramework\Controller $object an object or classname
47 47
 	 * @param string $method the method which we want to inspect
48 48
 	 * @throws \ReflectionException
49 49
 	 */
Please login to merge, or discard this patch.
lib/private/Files/Stream/Checksum.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
 	}
62 62
 
63 63
 	/**
64
-	 * @param $source
65
-	 * @param $path
64
+	 * @param resource $source
65
+	 * @param string $path
66 66
 	 * @return resource
67 67
 	 */
68 68
 	public static function wrap($source, $path) {
@@ -122,6 +122,9 @@  discard block
 block discarded – undo
122 122
 		return parent::stream_write($data);
123 123
 	}
124 124
 
125
+	/**
126
+	 * @param string $data
127
+	 */
125 128
 	private function updateHashingContexts($data) {
126 129
 		foreach ($this->hashingContexts as $ctx) {
127 130
 			\hash_update($ctx, $data);
@@ -195,7 +198,7 @@  discard block
 block discarded – undo
195 198
 	}
196 199
 
197 200
 	/**
198
-	 * @return mixed
201
+	 * @return string
199 202
 	 * @return string
200 203
 	 */
201 204
 	private function getPathFromStreamContext() {
Please login to merge, or discard this patch.
core/Command/User/ListUsers.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -77,6 +77,8 @@
 block discarded – undo
77 77
 
78 78
 	/**
79 79
 	 * If only a single attribute should be listed omit the key to make it fit in one row
80
+	 * @param string $key
81
+	 * @param boolean $useKey
80 82
 	 */
81 83
 	private function add(&$row, $key, $val, $useKey) {
82 84
 		if ($useKey) {
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 2 patches
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -268,6 +268,9 @@  discard block
 block discarded – undo
268 268
 		return \array_values($calendars);
269 269
 	}
270 270
 
271
+	/**
272
+	 * @param string $principalUri
273
+	 */
271 274
 	public function getUsersOwnCalendars($principalUri) {
272 275
 		$principalUri = $this->convertPrincipal($principalUri, true);
273 276
 		$fields = \array_values($this->propertyMap);
@@ -1278,7 +1281,7 @@  discard block
 block discarded – undo
1278 1281
 	 * @param string $principalUri
1279 1282
 	 * @param string $uri
1280 1283
 	 * @param array $properties
1281
-	 * @return mixed
1284
+	 * @return integer
1282 1285
 	 * @throws Forbidden
1283 1286
 	 */
1284 1287
 	public function createSubscription($principalUri, $uri, array $properties) {
@@ -1685,6 +1688,9 @@  discard block
 block discarded – undo
1685 1688
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1686 1689
 	}
1687 1690
 
1691
+	/**
1692
+	 * @param boolean $toV2
1693
+	 */
1688 1694
 	private function convertPrincipal($principalUri, $toV2 = null) {
1689 1695
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1690 1696
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use OCA\DAV\DAV\Sharing\Backend;
31 31
 use OCA\DAV\DAV\Sharing\IShareable;
32 32
 use OCP\DB\QueryBuilder\IQueryBuilder;
33
-use OCP\IConfig;
34 33
 use OCP\IDBConnection;
35 34
 use OCP\Security\ISecureRandom;
36 35
 use Sabre\CalDAV\Backend\AbstractBackend;
Please login to merge, or discard this patch.
apps/comments/lib/Dav/EntityCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
 	/**
117 117
 	 * Returns an array with all the child nodes
118 118
 	 *
119
-	 * @return \Sabre\DAV\INode[]
119
+	 * @return CommentNode[]
120 120
 	 */
121 121
 	public function getChildren() {
122 122
 		return $this->findChildren();
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ShareTypeList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
 	 * The deserialize method is called during xml parsing.
61 61
 	 *
62 62
 	 * @param Reader $reader
63
-	 * @return mixed
63
+	 * @return null|ShareTypeList
64 64
 	 */
65 65
 	public static function xmlDeserialize(Reader $reader) {
66 66
 		$shareTypes = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
 	 * the next element.
78 78
 	 *
79 79
 	 * @param Reader $reader
80
-	 * @return mixed
80
+	 * @return null|TagList
81 81
 	 */
82 82
 	public static function xmlDeserialize(Reader $reader) {
83 83
 		$tags = [];
Please login to merge, or discard this patch.
apps/dav/lib/DAV/FileCustomPropertiesBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@
 block discarded – undo
223 223
 
224 224
 	/**
225 225
 	 * @param string $path
226
-	 * @return INode|null
226
+	 * @return null|Node
227 227
 	 */
228 228
 	protected function getNodeForPath($path) {
229 229
 		$node = parent::getNodeForPath($path);
Please login to merge, or discard this patch.
apps/dav/lib/DAV/SystemPrincipalBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
 	 * Returns the list of members for a group-principal
144 144
 	 *
145 145
 	 * @param string $principal
146
-	 * @return array
146
+	 * @return string[]
147 147
 	 */
148 148
 	public function getGroupMemberSet($principal) {
149 149
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.