Completed
Pull Request — master (#32169)
by Juan Pablo
21:44
created
lib/private/Settings/SettingsManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,6 @@
 block discarded – undo
34 34
 use OCP\IGroupManager;
35 35
 use OCP\Defaults;
36 36
 use OCP\IURLGenerator;
37
-
38 37
 use OC\Settings\Panels\Personal\Profile;
39 38
 use OC\Settings\Panels\Personal\Legacy as LegacyPersonal;
40 39
 use OC\Settings\Panels\Admin\Legacy as LegacyAdmin;
Please login to merge, or discard this patch.
lib/private/legacy/app.php 1 patch
Doc Comments   -3 removed lines patch added patch discarded remove patch
@@ -807,9 +807,6 @@
 block discarded – undo
807 807
 	/**
808 808
 	 * List all apps, this is used in apps.php
809 809
 	 *
810
-	 * @param bool $onlyLocal
811
-	 * @param bool $includeUpdateInfo Should we check whether there is an update
812
-	 *                                in the app store?
813 810
 	 * @return array
814 811
 	 */
815 812
 	public static function listAllApps() {
Please login to merge, or discard this patch.
apps/dav/appinfo/Migrations/Version20170202213905.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 
29 29
 	/**
30 30
 	 * @param IDBConnection $connection
31
-	 * @return array
31
+	 * @return string[]
32 32
 	 */
33 33
 	public function sql(IDBConnection $connection) {
34 34
 		$qb = $connection->getQueryBuilder();
Please login to merge, or discard this patch.
lib/public/AppFramework/Db/Mapper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -308,6 +308,7 @@
 block discarded – undo
308 308
 	 * @param array $params the parameters of the sql query
309 309
 	 * @param int $limit the maximum number of rows
310 310
 	 * @param int $offset from which row we want to start
311
+	 * @param string $msg
311 312
 	 * @return string formatted error message string
312 313
 	 * @since 9.1.0
313 314
 	 */
Please login to merge, or discard this patch.
lib/base.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@
 block discarded – undo
329 329
 	/**
330 330
 	 * Checks if the version requires an update and shows
331 331
 	 * @param bool $showTemplate Whether an update screen should get shown
332
-	 * @return bool
332
+	 * @return null|boolean
333 333
 	 */
334 334
 	public static function checkUpgrade($showTemplate = true) {
335 335
 		if (\OCP\Util::needUpgrade()) {
Please login to merge, or discard this patch.
lib/private/User/Database.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -308,7 +308,7 @@
 block discarded – undo
308 308
 	/**
309 309
 	 * counts the users in the database
310 310
 	 *
311
-	 * @return int|bool
311
+	 * @return integer
312 312
 	 */
313 313
 	public function countUsers() {
314 314
 		$query = \OC_DB::prepare('SELECT COUNT(*) FROM `*PREFIX*users`');
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,6 @@
 block discarded – undo
53 53
 use OC\Cache\CappedMemoryCache;
54 54
 use OCP\IUserBackend;
55 55
 use OCP\User\IProvidesDisplayNameBackend;
56
-use OCP\User\IProvidesEMailBackend;
57 56
 use OCP\User\IProvidesHomeBackend;
58 57
 use OCP\Util;
59 58
 
Please login to merge, or discard this patch.
lib/private/Encryption/Util.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use OC\Files\Filesystem;
32 32
 use OC\Files\View;
33 33
 use OCP\Encryption\IEncryptionModule;
34
-use OCP\Files\Storage;
35 34
 use OCP\IConfig;
36 35
 use OCP\IUser;
37 36
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/SharesPlugin.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,6 @@
 block discarded – undo
68 68
 	/**
69 69
 	 * @param \Sabre\DAV\Tree $tree tree
70 70
 	 * @param IUserSession $userSession user session
71
-	 * @param \OCP\Files\Folder $userFolder user home folder
72 71
 	 * @param \OCP\Share\IManager $shareManager share manager
73 72
 	 */
74 73
 	public function __construct(
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	 * This will be used in the {DAV:}supported-report-set property.
153 153
 	 *
154 154
 	 * @param string $uri
155
-	 * @return array
155
+	 * @return string[]
156 156
 	 */
157 157
 	public function getSupportedReportSet($uri) {
158 158
 		return [self::REPORT_NAME];
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 	 * @param string $reportName
165 165
 	 * @param mixed $report
166 166
 	 * @param string $uri
167
-	 * @return bool
167
+	 * @return null|false
168 168
 	 * @throws BadRequest
169 169
 	 * @throws PreconditionFailed
170 170
 	 * @internal param $ [] $report
@@ -350,6 +350,7 @@  discard block
 block discarded – undo
350 350
 	 * with a leading slash but no trailing slash
351 351
 	 * @param string[] $requestedProps requested properties
352 352
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
353
+	 * @param Node[] $nodes
353 354
 	 * @return Response[]
354 355
 	 */
355 356
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {
Please login to merge, or discard this patch.