owncloud / core

apps/provisioning_api/lib/users.php

Doc Comments +1 added lines, -1 removed lines

@@ -470,7 +470,7 @@
 	/**
 	 * @param string $userId
 	 * @param array $data
-	 * @return mixed
+	 * @return string
 	 * @throws \OCP\Files\NotFoundException
 	 */
 	private static function fillStorageInfo($userId, $data) {

apps/user_ldap/lib/user/user.php

Doc Comments +1 added lines

@@ -369,6 +369,7 @@
 	 * already. If not, it will marked like this, because it is expected that
 	 * the method will be run, when false is returned.
 	 * @param string email | quota | avatar (can be extended)
+	 * @param string $feature
 	 * @return bool
 	 */
 	private function wasRefreshed($feature) {

build/integration/features/bootstrap/FeatureContext.php

Doc Comments -3 removed lines

@@ -77,7 +77,6 @@ 
 
 	/**
 	 * @Then /^users returned are$/
-	 * @param \Behat\Gherkin\Node\TableNode|null $formData
 	 */
 	public function theUsersShouldBe($usersList) {
 		if ($usersList instanceof \Behat\Gherkin\Node\TableNode) {
@@ -90,7 +89,6 @@ 
 
 	/**
 	 * @Then /^groups returned are$/
-	 * @param \Behat\Gherkin\Node\TableNode|null $formData
 	 */
 	public function theGroupsShouldBe($groupsList) {
 		if ($groupsList instanceof \Behat\Gherkin\Node\TableNode) {
@@ -225,7 +223,6 @@ 
 
 	/**
 	 * @When /^sending "([^"]*)" to "([^"]*)" with$/
-	 * @param \Behat\Gherkin\Node\TableNode|null $formData
 	 */
 	public function sendingToWith($verb, $url, $body) {
 		$fullUrl = $this->baseUrl . "v{$this->apiVersion}.php" . $url;

lib/autoloader.php

Doc Comments +3 added lines

@@ -129,6 +129,9 @@
 		return $paths;
 	}
 
+	/**
+	 * @param string $fullPath
+	 */
 	protected function isValidPath($fullPath) {
 		foreach ($this->validRoots as $root => $true) {
 			if (substr($fullPath, 0, strlen($root) + 1) === $root . '/') {

lib/private/app/appmanager.php

Doc Comments +2 added lines, -2 removed lines

@@ -89,7 +89,7 @@ 
 	/**
 	 * List all installed apps
 	 *
-	 * @return string[]
+	 * @return integer[]
 	 */
 	public function getInstalledApps() {
 		return array_keys($this->getInstalledAppsValues());
@@ -221,7 +221,7 @@ 
 	/**
 	 * Returns a list of apps that need upgrade
 	 *
-	 * @param array $version ownCloud version as array of version components
+	 * @param array $ocVersion ownCloud version as array of version components
 	 * @return array list of app info from apps that need an upgrade
 	 *
 	 * @internal

lib/private/connector/sabre/auth.php

Doc Comments +1 added lines, -1 removed lines

@@ -150,7 +150,7 @@
 
 	/**
 	 * @param \Sabre\DAV\Server $server
-	 * @param $realm
+	 * @param string $realm
 	 * @return bool
 	 */
 	private function auth(\Sabre\DAV\Server $server, $realm) {

lib/private/connector/sabre/fakelockerplugin.php

Doc Comments +2 added lines, -2 removed lines

@@ -59,7 +59,7 @@ 
 	 * Indicate that we support LOCK and UNLOCK
 	 *
 	 * @param string $path
-	 * @return array
+	 * @return string[]
 	 */
 	public function getHTTPMethods($path) {
 		return [
@@ -71,7 +71,7 @@ 
 	/**
 	 * Indicate that we support locking
 	 *
-	 * @return array
+	 * @return integer[]
 	 */
 	function getFeatures() {
 		return [2];

lib/private/connector/sabre/file.php

Doc Comments +8 added lines, -2 removed lines

@@ -213,6 +213,9 @@ 
 		return '"' . $this->info->getEtag() . '"';
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function emitPreHooks($exists, $path = null) {
 		if (is_null($path)) {
 			$path = $this->path;
@@ -238,6 +241,9 @@ 
 		return $run;
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function emitPostHooks($exists, $path = null) {
 		if (is_null($path)) {
 			$path = $this->path;
@@ -260,7 +266,7 @@ 
 	/**
 	 * Returns the data
 	 *
-	 * @return string|resource
+	 * @return resource
 	 * @throws Forbidden
 	 * @throws ServiceUnavailable
 	 */
@@ -314,7 +320,7 @@ 
 	 *
 	 * If null is returned, we'll assume application/octet-stream
 	 *
-	 * @return mixed
+	 * @return string
 	 */
 	public function getContentType() {
 		$mimeType = $this->info->getMimetype();

lib/private/connector/sabre/lockplugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 	private $tree;
 
 	/**
-	 * @param \Sabre\DAV\Tree $tree tree
+	 * @param ObjectTree $tree tree
 	 */
 	public function __construct(Tree $tree) {
 		$this->tree = $tree;

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use Sabre\DAV\ServerPlugin;
 use Sabre\DAV\Tree;
 use Sabre\HTTP\RequestInterface;
-use Sabre\HTTP\ResponseInterface;
 
 class LockPlugin extends ServerPlugin {
 	/**