Completed
Pull Request — master (#29865)
by Matthew
09:45
created
lib/private/legacy/db.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,6 @@
 block discarded – undo
150 150
 	/**
151 151
 	 * saves database schema to xml file
152 152
 	 * @param string $file name of file
153
-	 * @param int $mode
154 153
 	 * @return bool
155 154
 	 *
156 155
 	 * TODO: write more documentation
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/SMB.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -260,6 +260,9 @@  discard block
 block discarded – undo
260 260
 		return $this->leave(__FUNCTION__, $result);
261 261
 	}
262 262
 
263
+	/**
264
+	 * @param string $path
265
+	 */
263 266
 	private function removeFromCache($path) {
264 267
 		$path = trim($path, '/');
265 268
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -632,7 +635,7 @@  discard block
 block discarded – undo
632 635
 	 * if wnd.logging.enable is set to true in the config will log a leave line
633 636
 	 * with the given function, the return value or the exception
634 637
 	 *
635
-	 * @param $function
638
+	 * @param string $function
636 639
 	 * @param mixed $result an exception will be logged and then returned
637 640
 	 * @return mixed
638 641
 	 */
@@ -659,6 +662,9 @@  discard block
 block discarded – undo
659 662
 		return $result;
660 663
 	}
661 664
 
665
+	/**
666
+	 * @param string $function
667
+	 */
662 668
 	private function swallow($function, \Exception $exception) {
663 669
 		if (\OC::$server->getConfig()->getSystemValue('wnd.logging.enable', false) === true) {
664 670
 			Util::writeLog('wnd', "$function swallowing ".get_class($exception)
Please login to merge, or discard this patch.
core/Controller/OccController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -131,8 +131,8 @@
 block discarded – undo
131 131
 
132 132
 	/**
133 133
 	 * Check if command is allowed and has a valid security token
134
-	 * @param $command
135
-	 * @param $token
134
+	 * @param string $command
135
+	 * @param string $token
136 136
 	 */
137 137
 	protected function validateRequest($command, $token){
138 138
 		$allowedHosts = ['::1', '127.0.0.1', 'localhost'];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ShareTypeList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
 	 * The deserialize method is called during xml parsing.
61 61
 	 *
62 62
 	 * @param Reader $reader
63
-	 * @return mixed
63
+	 * @return null|ShareTypeList
64 64
 	 */
65 65
 	static function xmlDeserialize(Reader $reader) {
66 66
 		$shareTypes = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 	 * the next element.
80 80
 	 *
81 81
 	 * @param Reader $reader
82
-	 * @return mixed
82
+	 * @return null|TagList
83 83
 	 */
84 84
 	static function xmlDeserialize(Reader $reader) {
85 85
 		$tags = [];
Please login to merge, or discard this patch.
apps/federation/lib/Controller/OCSAuthAPIController.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -164,6 +164,10 @@
 block discarded – undo
164 164
 			'data' => ['sharedSecret' => $sharedSecret]];
165 165
 	}
166 166
 
167
+	/**
168
+	 * @param string $url
169
+	 * @param string $token
170
+	 */
167 171
 	protected function isValidToken($url, $token) {
168 172
 		$storedToken = $this->dbHandler->getToken($url);
169 173
 		return hash_equals($storedToken, $token);
Please login to merge, or discard this patch.
lib/private/AvatarManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,9 @@
 block discarded – undo
99 99
 		}
100 100
 	}
101 101
 
102
+	/**
103
+	 * @param string $userId
104
+	 */
102 105
 	private function buildAvatarPath($userId) {
103 106
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
104 107
 		return explode('/', $avatar);
Please login to merge, or discard this patch.
apps/dav/lib/Files/Xml/FilterRequest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
 	 * the next element.
46 46
 	 *
47 47
 	 * @param Reader $reader
48
-	 * @return mixed
48
+	 * @return FilterRequest
49 49
 	 */
50 50
 	static function xmlDeserialize(Reader $reader) {
51 51
 		$elems = (array)$reader->parseInnerTree([
Please login to merge, or discard this patch.
lib/private/L10N/Factory.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -278,6 +278,11 @@
 block discarded – undo
278 278
 	 */
279 279
 	// FIXME This method is only public, until \OCP\IL10N does not need it anymore,
280 280
 	// FIXME This is also the reason, why it is not in the public interface
281
+
282
+	/**
283
+	 * @param string $app
284
+	 * @param string $lang
285
+	 */
281 286
 	public function getL10nFilesForApp($app, $lang) {
282 287
 		$languageFiles = [];
283 288
 
Please login to merge, or discard this patch.