Completed
Pull Request — master (#25001)
by Joas
10:17
created
apps/dav/lib/Command/CreateAddressBook.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -22,11 +22,6 @@
 block discarded – undo
22 22
 namespace OCA\DAV\Command;
23 23
 
24 24
 use OCA\DAV\CardDAV\CardDavBackend;
25
-use OCA\DAV\Connector\Sabre\Principal;
26
-use OCP\IConfig;
27
-use OCP\IDBConnection;
28
-use OCP\IGroupManager;
29
-use OCP\ILogger;
30 25
 use OCP\IUserManager;
31 26
 use Symfony\Component\Console\Command\Command;
32 27
 use Symfony\Component\Console\Input\InputArgument;
Please login to merge, or discard this patch.
apps/dav/lib/Command/SyncSystemAddressBook.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -21,10 +21,8 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Command;
22 22
 
23 23
 use OCA\DAV\CardDAV\SyncService;
24
-use OCP\IUserManager;
25 24
 use Symfony\Component\Console\Command\Command;
26 25
 use Symfony\Component\Console\Helper\ProgressBar;
27
-use Symfony\Component\Console\Input\InputArgument;
28 26
 use Symfony\Component\Console\Input\InputInterface;
29 27
 use Symfony\Component\Console\Output\OutputInterface;
30 28
 
Please login to merge, or discard this patch.
apps/dav/lib/Comments/CommentNode.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Comments/CommentsPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Comments/EntityCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 	/**
107 107
 	 * Returns an array with all the child nodes
108 108
 	 *
109
-	 * @return \Sabre\DAV\INode[]
109
+	 * @return CommentNode[]
110 110
 	 */
111 111
 	function getChildren() {
112 112
 		return $this->findChildren();
Please login to merge, or discard this patch.
apps/dav/lib/Connector/LegacyDAVACL.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@
 block discarded – undo
59 59
 		);
60 60
 	}
61 61
 
62
+	/**
63
+	 * @param boolean $toV2
64
+	 */
62 65
 	private function convertPrincipal($principal, $toV2) {
63 66
 		list(, $name) = URLUtil::splitPath($principal);
64 67
 		if ($toV2) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ChecksumList.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Connector\Sabre;
22 22
 
23 23
 use Sabre\Xml\XmlSerializable;
24
-use Sabre\Xml\Element;
25 24
 use Sabre\Xml\Writer;
26 25
 
27 26
 /**
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/CustomPropertiesBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
 	private $cache = [];
76 76
 
77 77
 	/**
78
-	 * @param Tree $tree node tree
78
+	 * @param ObjectTree $tree node tree
79 79
 	 * @param IDBConnection $connection database connection
80 80
 	 * @param IUser $user owner of the tree and properties
81 81
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/DavAclPlugin.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -22,14 +22,11 @@
 block discarded – undo
22 22
 namespace OCA\DAV\Connector\Sabre;
23 23
 
24 24
 use Sabre\DAV\Exception\NotFound;
25
-use Sabre\DAV\IFile;
26 25
 use Sabre\DAV\INode;
27 26
 use \Sabre\DAV\PropFind;
28 27
 use \Sabre\DAV\PropPatch;
29
-use Sabre\DAVACL\Exception\NeedPrivileges;
30 28
 use \Sabre\HTTP\RequestInterface;
31 29
 use \Sabre\HTTP\ResponseInterface;
32
-use Sabre\HTTP\URLUtil;
33 30
 
34 31
 /**
35 32
  * Class DavAclPlugin is a wrapper around \Sabre\DAVACL\Plugin that returns 404
Please login to merge, or discard this patch.