owncloud / core

apps/federation/lib/Command/SyncFederationAddressBooks.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace OCA\Federation\Command;
 
-use OCA\Federation\DbHandler;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\ProgressBar;
 use Symfony\Component\Console\Input\InputInterface;

apps/federation/lib/DbHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -271,8 +271,8 @@
 	}
 
 	/**
-	 * @param $username
-	 * @param $password
+	 * @param string $username
+	 * @param string $password
 	 * @return bool
 	 */
 	public function auth($username, $password) {

apps/federation/lib/SyncFederationAddressBooks.php

Unused Use Statements -4 removed lines

@@ -3,10 +3,6 @@
 namespace OCA\Federation;
 
 use OCA\DAV\CardDAV\SyncService;
-use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\ProgressBar;
-use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Output\OutputInterface;
 
 class SyncFederationAddressBooks {
 

apps/encryption/lib/Crypto/Encryption.php

Doc Comments +1 added lines, -1 removed lines

@@ -370,7 +370,7 @@
 	 * @param string $path path to the file which should be updated
 	 * @param string $uid of the user who performs the operation
 	 * @param array $accessList who has access to the file contains the key 'users' and 'public'
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	public function update($path, $uid, array $accessList) {
 

apps/encryption/lib/KeyManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -777,7 +777,7 @@
 	/**
 	 * check if path points to a files version
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function isVersion($path) {

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 use OCA\Encryption\Crypto\Crypt;
 use OCP\Encryption\Keys\IStorage;
 use OCP\IConfig;
-use OCP\IDBConnection;
 use OCP\ILogger;
 use OCP\IUserSession;
 

apps/dav/lib/AppInfo/Application.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 use OCA\DAV\CalDAV\CalDavBackend;
 use OCA\DAV\CardDAV\CardDavBackend;
 use OCA\DAV\CardDAV\ContactsManager;
-use OCA\DAV\CardDAV\SyncJob;
 use OCA\DAV\CardDAV\SyncService;
 use OCA\DAV\Connector\Sabre\Principal;
 use OCA\DAV\DAV\GroupPrincipalBackend;

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +4 added lines, -1 removed lines

@@ -1036,7 +1036,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
 
@@ -1377,6 +1377,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

apps/dav/lib/CardDAV/CardDavBackend.php

Doc Comments +7 added lines, -2 removed lines

@@ -187,7 +187,8 @@ 
 	}
 
 	/**
-	 * @param $addressBookUri
+	 * @param string $addressBookUri
+	 * @param string $principal
 	 * @return array|null
 	 */
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -867,6 +868,7 @@ 
 	 *   * readOnly - boolean
 	 *   * summary - Optional, a description for the share
 	 *
+	 * @param integer $addressBookId
 	 * @return array
 	 */
 	public function getShares($addressBookId) {
@@ -966,7 +968,7 @@ 
 
 	/**
 	 * For shared address books the sharee is set in the ACL of the address book
-	 * @param $addressBookId
+	 * @param integer $addressBookId
 	 * @param $acl
 	 * @return array
 	 */
@@ -974,6 +976,9 @@ 
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

apps/dav/lib/CardDAV/SyncService.php

Doc Comments +1 added lines, -1 removed lines

@@ -227,7 +227,7 @@
 	}
 
 	/**
-	 * @return array|null
+	 * @return string
 	 */
 	public function getLocalSystemAddressBook() {
 		if (is_null($this->localSystemAddressBook)) {