Completed
Pull Request — master (#25001)
by Joas
10:17
created
apps/federatedfilesharing/lib/FederatedShareProvider.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
 	/**
323 323
 	 * store remote ID in federated reShare table
324 324
 	 *
325
-	 * @param $shareId
325
+	 * @param integer $shareId
326 326
 	 * @param $remoteId
327 327
 	 */
328 328
 	public function storeRemoteId($shareId, $remoteId) {
@@ -653,7 +653,7 @@  discard block
 block discarded – undo
653 653
 	/**
654 654
 	 * get database row of a give share
655 655
 	 *
656
-	 * @param $id
656
+	 * @param integer $id
657 657
 	 * @return array
658 658
 	 * @throws ShareNotFound
659 659
 	 */
Please login to merge, or discard this patch.
lib/public/Migration/IOutput.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,26 +24,30 @@
 block discarded – undo
24 24
 
25 25
 	/**
26 26
 	 * @param string $message
27
+	 * @return void
27 28
 	 */
28 29
 	public function info($message);
29 30
 
30 31
 	/**
31 32
 	 * @param string $message
33
+	 * @return void
32 34
 	 */
33 35
 	public function warning($message);
34 36
 
35 37
 	/**
36 38
 	 * @param int $max
39
+	 * @return void
37 40
 	 */
38 41
 	public function startProgress($max = 0);
39 42
 
40 43
 	/**
41 44
 	 * @param int $step
45
+	 * @return void
42 46
 	 */
43 47
 	public function advance($step = 1);
44 48
 
45 49
 	/**
46
-	 * @param int $max
50
+	 * @return void
47 51
 	 */
48 52
 	public function finishProgress();
49 53
 
Please login to merge, or discard this patch.
lib/public/Files.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,6 +45,7 @@  discard block
 block discarded – undo
45 45
 class Files {
46 46
 	/**
47 47
 	 * Recusive deletion of folders
48
+	 * @param string $dir
48 49
 	 * @return bool
49 50
 	 * @since 5.0.0
50 51
 	 */
@@ -66,7 +67,7 @@  discard block
 block discarded – undo
66 67
 	/**
67 68
 	 * Search for files by mimetype
68 69
 	 * @param string $mimetype
69
-	 * @return array
70
+	 * @return \OC\Files\FileInfo[]
70 71
 	 * @since 6.0.0
71 72
 	 */
72 73
 	static public function searchByMime( $mimetype ) {
Please login to merge, or discard this patch.
lib/public/Util.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -524,7 +524,7 @@
 block discarded – undo
524 524
 	 * @param array $input The array to work on
525 525
 	 * @param int $case Either MB_CASE_UPPER or MB_CASE_LOWER (default)
526 526
 	 * @param string $encoding The encoding parameter is the character encoding. Defaults to UTF-8
527
-	 * @return array
527
+	 * @return string
528 528
 	 * @since 4.5.0
529 529
 	 */
530 530
 	public static function mb_array_change_key_case($input, $case = MB_CASE_LOWER, $encoding = 'UTF-8') {
Please login to merge, or discard this patch.
lib/public/Template.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,8 +100,8 @@
 block discarded – undo
100 100
 /**
101 101
  * Return the relative date in relation to today. Returns something like "last hour" or "two month ago"
102 102
  * @param int $timestamp unix timestamp
103
- * @param boolean $dateOnly
104
- * @return \OC_L10N_String human readable interpretation of the timestamp
103
+ * @param integer $dateOnly
104
+ * @return string human readable interpretation of the timestamp
105 105
  *
106 106
  * @deprecated 8.0.0 Use \OCP\Template::relative_modified_date() instead
107 107
  */
Please login to merge, or discard this patch.
core/Controller/LostController.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,6 +145,7 @@  discard block
 block discarded – undo
145 145
 	/**
146 146
 	 * @param string $userId
147 147
 	 * @param string $userId
148
+	 * @param string $token
148 149
 	 * @throws \Exception
149 150
 	 */
150 151
 	private function checkPasswordResetToken($token, $userId) {
@@ -166,7 +167,7 @@  discard block
 block discarded – undo
166 167
 	}
167 168
 
168 169
 	/**
169
-	 * @param $message
170
+	 * @param string $message
170 171
 	 * @param array $additional
171 172
 	 * @return array
172 173
 	 */
Please login to merge, or discard this patch.
lib/public/SystemTag/ISystemTagManager.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -102,17 +102,19 @@  discard block
 block discarded – undo
102 102
 	 * with the same attributes
103 103
 	 *
104 104
 	 * @since 9.0.0
105
+	 * @return void
105 106
 	 */
106 107
 	public function updateTag($tagId, $newName, $userVisible, $userAssignable);
107 108
 
108 109
 	/**
109 110
 	 * Delete the given tags from the database and all their relationships.
110 111
 	 *
111
-	 * @param string|array $tagIds array of tag ids
112
+	 * @param string $tagIds array of tag ids
112 113
 	 *
113 114
 	 * @throws \OCP\SystemTag\TagNotFoundException if at least one tag did not exist
114 115
 	 *
115 116
 	 * @since 9.0.0
117
+	 * @return void
116 118
 	 */
117 119
 	public function deleteTags($tagIds);
118 120
 
@@ -123,7 +125,7 @@  discard block
 block discarded – undo
123 125
 	 * @param ISystemTag $tag tag to check permission for
124 126
 	 * @param IUser $user user to check permission for
125 127
 	 *
126
-	 * @return true if the user is allowed to assign/unassign the tag, false otherwise
128
+	 * @return boolean if the user is allowed to assign/unassign the tag, false otherwise
127 129
 	 *
128 130
 	 * @since 9.1.0
129 131
 	 */
@@ -133,9 +135,9 @@  discard block
 block discarded – undo
133 135
 	 * Checks whether the given user is allowed to see the tag with the given id.
134 136
 	 *
135 137
 	 * @param ISystemTag $tag tag to check permission for
136
-	 * @param IUser $user user to check permission for
138
+	 * @param IUser $userId user to check permission for
137 139
 	 *
138
-	 * @return true if the user can see the tag, false otherwise
140
+	 * @return boolean if the user can see the tag, false otherwise
139 141
 	 *
140 142
 	 * @since 9.1.0
141 143
 	 */
@@ -148,6 +150,7 @@  discard block
 block discarded – undo
148 150
 	 * @param string[] $groupIds group ids of groups that can assign/unassign the tag
149 151
 	 *
150 152
 	 * @since 9.1.0
153
+	 * @return void
151 154
 	 */
152 155
 	public function setTagGroups(ISystemTag $tag, $groupIds);
153 156
 
Please login to merge, or discard this patch.
lib/private/User/Session.php 1 patch
Doc Comments   +8 added lines, -2 removed lines patch added patch discarded remove patch
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
 	 *
291 291
 	 * @param string $uid
292 292
 	 * @param string $password
293
-	 * @return boolean|null
293
+	 * @return boolean
294 294
 	 * @throws LoginException
295 295
 	 */
296 296
 	public function login($uid, $password) {
@@ -362,6 +362,9 @@  discard block
 block discarded – undo
362 362
 		return $this->config->getSystemValue('token_auth_enforced', true);
363 363
 	}
364 364
 
365
+	/**
366
+	 * @param string $username
367
+	 */
365 368
 	private function isTwoFactorEnforced($username) {
366 369
 		\OCP\Util::emitHook(
367 370
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -376,7 +379,7 @@  discard block
 block discarded – undo
376 379
 	/**
377 380
 	 * Check if the given 'password' is actually a device token
378 381
 	 *
379
-	 * @param type $password
382
+	 * @param string $password
380 383
 	 * @return boolean
381 384
 	 */
382 385
 	public function isTokenPassword($password) {
@@ -426,6 +429,9 @@  discard block
 block discarded – undo
426 429
 		return false;
427 430
 	}
428 431
 
432
+	/**
433
+	 * @param string $uid
434
+	 */
429 435
 	private function loginWithToken($uid) {
430 436
 		// TODO: $this->manager->emit('\OC\User', 'preTokenLogin', array($uid));
431 437
 		$user = $this->manager->get($uid);
Please login to merge, or discard this patch.
lib/private/Files/View.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 	 * and does not take the chroot into account )
198 198
 	 *
199 199
 	 * @param string $path
200
-	 * @return \OCP\Files\Mount\IMountPoint
200
+	 * @return Mount\MountPoint|null
201 201
 	 */
202 202
 	public function getMount($path) {
203 203
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -960,7 +960,7 @@  discard block
 block discarded – undo
960 960
 
961 961
 	/**
962 962
 	 * @param string $path
963
-	 * @return bool|string
963
+	 * @return string|false
964 964
 	 * @throws \OCP\Files\InvalidPathException
965 965
 	 */
966 966
 	public function toTmpFile($path) {
@@ -1075,7 +1075,7 @@  discard block
 block discarded – undo
1075 1075
 	 * @param string $path
1076 1076
 	 * @param array $hooks (optional)
1077 1077
 	 * @param mixed $extraParam (optional)
1078
-	 * @return mixed
1078
+	 * @return string
1079 1079
 	 * @throws \Exception
1080 1080
 	 *
1081 1081
 	 * This method takes requests for basic filesystem functions (e.g. reading & writing
@@ -2083,7 +2083,7 @@  discard block
 block discarded – undo
2083 2083
 
2084 2084
 	/**
2085 2085
 	 * @param string $filename
2086
-	 * @return array
2086
+	 * @return string[]
2087 2087
 	 * @throws \OC\User\NoUserException
2088 2088
 	 * @throws NotFoundException
2089 2089
 	 */
Please login to merge, or discard this patch.