Completed
Pull Request — master (#25001)
by Joas
10:17
created
apps/dav/lib/Upload/AssemblyStream.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
 	/**
102 102
 	 * @param string $data
103
-	 * @return int
103
+	 * @return boolean
104 104
 	 */
105 105
 	public function stream_write($data) {
106 106
 		return false;
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	}
207 207
 
208 208
 	/**
209
-	 * @param $pos
209
+	 * @param integer $pos
210 210
 	 * @return IFile | null
211 211
 	 */
212 212
 	private function getNodeForPosition($pos) {
Please login to merge, or discard this patch.
apps/files_trashbin/lib/BackgroundJob/ExpireTrash.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  */
21 21
 
22 22
 use OC\Share\MailNotifications;
23
-use OCP\IConfig;
24 23
 use OCP\IL10N;
25 24
 use OCP\IUser;
26 25
 use OCP\Mail\IMailer;
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Storage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -777,7 +777,7 @@
 block discarded – undo
777 777
 	/**
778 778
 	 * check if path points to a files version
779 779
 	 *
780
-	 * @param $path
780
+	 * @param string $path
781 781
 	 * @return bool
782 782
 	 */
783 783
 	protected function isVersion($path) {
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
 	 * if the size limit for the trash bin is reached, we delete the oldest
656 656
 	 * files in the trash bin until we meet the limit again
657 657
 	 *
658
-	 * @param array $files
658
+	 * @param \OCP\Files\FileInfo[] $files
659 659
 	 * @param string $user
660 660
 	 * @param int $availableSpace available disc space
661 661
 	 * @return int size of deleted files
@@ -683,7 +683,7 @@  discard block
 block discarded – undo
683 683
 	/**
684 684
 	 * delete files older then max storage time
685 685
 	 *
686
-	 * @param array $files list of files sorted by mtime
686
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
687 687
 	 * @param string $user
688 688
 	 * @return integer[] size of deleted files and number of deleted files
689 689
 	 */
Please login to merge, or discard this patch.
apps/files/lib/Service/TagService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 
25 25
 namespace OCA\Files\Service;
26 26
 
27
-use OC\Files\FileInfo;
28 27
 use OCP\Files\Node;
29 28
 
30 29
 /**
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagPlugin.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -24,13 +24,11 @@
 block discarded – undo
24 24
 
25 25
 use OCP\IGroupManager;
26 26
 use OCP\IUserSession;
27
-use Sabre\DAV\Exception\NotFound;
28 27
 use Sabre\DAV\PropFind;
29 28
 use Sabre\DAV\PropPatch;
30 29
 use Sabre\DAV\Exception\BadRequest;
31 30
 use Sabre\DAV\Exception\UnsupportedMediaType;
32 31
 use Sabre\DAV\Exception\Conflict;
33
-
34 32
 use OCP\SystemTag\ISystemTag;
35 33
 use OCP\SystemTag\ISystemTagManager;
36 34
 use OCP\SystemTag\TagAlreadyExistsException;
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsByIdCollection.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -26,13 +26,11 @@
 block discarded – undo
26 26
 use Sabre\DAV\Exception\NotFound;
27 27
 use Sabre\DAV\Exception\BadRequest;
28 28
 use Sabre\DAV\ICollection;
29
-
30 29
 use OCP\SystemTag\ISystemTagManager;
31 30
 use OCP\SystemTag\ISystemTag;
32 31
 use OCP\SystemTag\TagNotFoundException;
33 32
 use OCP\IGroupManager;
34 33
 use OCP\IUserSession;
35
-use OC\User\NoUserException;
36 34
 
37 35
 class SystemTagsByIdCollection implements ICollection {
38 36
 
Please login to merge, or discard this patch.
core/Middleware/TwoFactorMiddleware.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -79,6 +79,10 @@
 block discarded – undo
79 79
 		// TODO: throw exceptions if necessary
80 80
 	}
81 81
 
82
+	/**
83
+	 * @param Controller $controller
84
+	 * @param string $methodName
85
+	 */
82 86
 	private function checkTwoFactor($controller, $methodName) {
83 87
 		// If two-factor auth is in progress disallow access to any controllers
84 88
 		// defined within "LoginController".
Please login to merge, or discard this patch.
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
  * make preview_icon available as a simple function
184 184
  * Returns the path to the preview of the image.
185 185
  * @param string $path path of file
186
- * @return link to the preview
186
+ * @return string to the preview
187 187
  *
188 188
  * For further information have a look at OC_Helper::previewIcon
189 189
  */
@@ -193,6 +193,7 @@  discard block
 block discarded – undo
193 193
 
194 194
 /**
195 195
  * @param string $path
196
+ * @param string $token
196 197
  */
197 198
 function publicPreview_icon ( $path, $token ) {
198 199
 	return OC_Helper::publicPreviewIcon( $path, $token );
Please login to merge, or discard this patch.