Completed
Pull Request — master (#28256)
by Philipp
21:36 queued 02:19
created
lib/private/Console/TimestampFormatter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
 	 * Checks if output formatter has style with specified name.
72 72
 	 *
73 73
 	 * @param string $name
74
-	 * @return bool
74
+	 * @return boolean|null
75 75
 	 */
76 76
 	public function hasStyle($name) {
77 77
 		$this->formatter->hasStyle($name);
Please login to merge, or discard this patch.
lib/private/DB/Adapter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 
44 44
 	/**
45 45
 	 * @param string $table name
46
-	 * @return int id of last insert statement
46
+	 * @return string id of last insert statement
47 47
 	 */
48 48
 	public function lastInsertId($table) {
49 49
 		return $this->conn->realLastInsertId($table);
Please login to merge, or discard this patch.
lib/private/DB/Connection.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@
 block discarded – undo
173 173
 	 * If an SQLLogger is configured, the execution is logged.
174 174
 	 *
175 175
 	 * @param string                                      $query  The SQL query to execute.
176
-	 * @param array                                       $params The parameters to bind to the query, if any.
176
+	 * @param string[]                                       $params The parameters to bind to the query, if any.
177 177
 	 * @param array                                       $types  The types the previous parameters are in.
178 178
 	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
179 179
 	 *
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,6 @@
 block discarded – undo
40 40
 use OCP\DB\QueryBuilder\IQueryBuilder;
41 41
 use OCP\IDBConnection;
42 42
 use OCP\PreConditionNotMetException;
43
-use OCP\Util;
44 43
 
45 44
 class Connection extends \Doctrine\DBAL\Connection implements IDBConnection {
46 45
 	/**
Please login to merge, or discard this patch.
lib/private/legacy/db/statementwrapper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -44,6 +44,7 @@
 block discarded – undo
44 44
 
45 45
 	/**
46 46
 	 * @param boolean $isManipulation
47
+	 * @param Doctrine\DBAL\Driver\Statement $statement
47 48
 	 */
48 49
 	public function __construct($statement, $isManipulation) {
49 50
 		$this->statement = $statement;
Please login to merge, or discard this patch.
lib/private/Mail/Message.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	/**
110 110
 	 * Returns the Reply-To address of this message
111 111
 	 *
112
-	 * @return array
112
+	 * @return string
113 113
 	 */
114 114
 	public function getReplyTo() {
115 115
 		return $this->swiftMessage->getReplyTo();
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 	/**
163 163
 	 * Set the BCC recipients of this message.
164 164
 	 *
165
-	 * @param array $recipients Example: array('[email protected]', '[email protected]' => 'A name')
165
+	 * @param string[] $recipients Example: array('[email protected]', '[email protected]' => 'A name')
166 166
 	 * @return $this
167 167
 	 */
168 168
 	public function setBcc(array $recipients) {
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/RequestHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -566,7 +566,7 @@
 block discarded – undo
566 566
 	/**
567 567
 	 * update permissions in database
568 568
 	 *
569
-	 * @param IShare $share
569
+	 * @param Share\IShare $share
570 570
 	 * @param int $permissions
571 571
 	 */
572 572
 	protected function updatePermissionsInDatabase(IShare $share, $permissions) {
Please login to merge, or discard this patch.
lib/private/legacy/db.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,6 @@
 block discarded – undo
150 150
 	/**
151 151
 	 * saves database schema to xml file
152 152
 	 * @param string $file name of file
153
-	 * @param int $mode
154 153
 	 * @return bool
155 154
 	 *
156 155
 	 * TODO: write more documentation
Please login to merge, or discard this patch.
lib/private/Files/Config/LazyStorageMountInfo.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -21,10 +21,7 @@
 block discarded – undo
21 21
 
22 22
 namespace OC\Files\Config;
23 23
 
24
-use OC\Files\Filesystem;
25
-use OCP\Files\Config\ICachedMountInfo;
26 24
 use OCP\Files\Mount\IMountPoint;
27
-use OCP\Files\Node;
28 25
 use OCP\IUser;
29 26
 
30 27
 class LazyStorageMountInfo extends CachedMountInfo {
Please login to merge, or discard this patch.
lib/private/App/CodeChecker/NodeVisitor.php 1 patch
Doc Comments   +15 added lines patch added patch discarded remove patch
@@ -241,6 +241,9 @@  discard block
 block discarded – undo
241 241
 		}
242 242
 	}
243 243
 
244
+	/**
245
+	 * @param string $name
246
+	 */
244 247
 	private function checkBlackList($name, $errorCode, Node $node) {
245 248
 		$lowerName = strtolower($name);
246 249
 
@@ -254,6 +257,9 @@  discard block
 block discarded – undo
254 257
 		}
255 258
 	}
256 259
 
260
+	/**
261
+	 * @param string $constantName
262
+	 */
257 263
 	private function checkBlackListConstant($class, $constantName, Node $node) {
258 264
 		$name = $class . '::' . $constantName;
259 265
 		$lowerName = strtolower($name);
@@ -268,6 +274,9 @@  discard block
 block discarded – undo
268 274
 		}
269 275
 	}
270 276
 
277
+	/**
278
+	 * @param string $class
279
+	 */
271 280
 	private function checkBlackListFunction($class, $functionName, Node $node) {
272 281
 		$name = $class . '::' . $functionName;
273 282
 		$lowerName = strtolower($name);
@@ -282,6 +291,9 @@  discard block
 block discarded – undo
282 291
 		}
283 292
 	}
284 293
 
294
+	/**
295
+	 * @param string $class
296
+	 */
285 297
 	private function checkBlackListMethod($class, $functionName, Node $node) {
286 298
 		$name = $class . '::' . $functionName;
287 299
 		$lowerName = strtolower($name);
@@ -296,6 +308,9 @@  discard block
 block discarded – undo
296 308
 		}
297 309
 	}
298 310
 
311
+	/**
312
+	 * @param string $name
313
+	 */
299 314
 	private function buildReason($name, $errorCode) {
300 315
 		if (isset($this->errorMessages[$errorCode])) {
301 316
 			$desc = $this->list->getDescription($errorCode, $name);
Please login to merge, or discard this patch.