owncloud / core

apps/files_trashbin/lib/Trashbin.php

Doc Comments +2 added lines, -2 removed lines

@@ -655,7 +655,7 @@ 
 	 * if the size limit for the trash bin is reached, we delete the oldest
 	 * files in the trash bin until we meet the limit again
 	 *
-	 * @param array $files
+	 * @param \OCP\Files\FileInfo[] $files
 	 * @param string $user
 	 * @param int $availableSpace available disc space
 	 * @return int size of deleted files
@@ -683,7 +683,7 @@ 
 	/**
 	 * delete files older then max storage time
 	 *
-	 * @param array $files list of files sorted by mtime
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
 	 * @param string $user
 	 * @return integer[] size of deleted files and number of deleted files
 	 */

apps/files/lib/Service/TagService.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 
 namespace OCA\Files\Service;
 
-use OC\Files\FileInfo;
 use OCP\Files\Node;
 
 /**

apps/dav/lib/SystemTag/SystemTagPlugin.php

Unused Use Statements -2 removed lines

@@ -24,13 +24,11 @@
 
 use OCP\IGroupManager;
 use OCP\IUserSession;
-use Sabre\DAV\Exception\NotFound;
 use Sabre\DAV\PropFind;
 use Sabre\DAV\PropPatch;
 use Sabre\DAV\Exception\BadRequest;
 use Sabre\DAV\Exception\UnsupportedMediaType;
 use Sabre\DAV\Exception\Conflict;
-
 use OCP\SystemTag\ISystemTag;
 use OCP\SystemTag\ISystemTagManager;
 use OCP\SystemTag\TagAlreadyExistsException;

apps/dav/lib/SystemTag/SystemTagsByIdCollection.php

Unused Use Statements -2 removed lines

@@ -26,13 +26,11 @@
 use Sabre\DAV\Exception\NotFound;
 use Sabre\DAV\Exception\BadRequest;
 use Sabre\DAV\ICollection;
-
 use OCP\SystemTag\ISystemTagManager;
 use OCP\SystemTag\ISystemTag;
 use OCP\SystemTag\TagNotFoundException;
 use OCP\IGroupManager;
 use OCP\IUserSession;
-use OC\User\NoUserException;
 
 class SystemTagsByIdCollection implements ICollection {
 

core/Middleware/TwoFactorMiddleware.php

Doc Comments +4 added lines

@@ -79,6 +79,10 @@
 		// TODO: throw exceptions if necessary
 	}
 
+	/**
+	 * @param Controller $controller
+	 * @param string $methodName
+	 */
 	private function checkTwoFactor($controller, $methodName) {
 		// If two-factor auth is in progress disallow access to any controllers
 		// defined within "LoginController".

lib/private/legacy/template/functions.php

Doc Comments +2 added lines, -1 removed lines

@@ -183,7 +183,7 @@ 
  * make preview_icon available as a simple function
  * Returns the path to the preview of the image.
  * @param string $path path of file
- * @return link to the preview
+ * @return string to the preview
  *
  * For further information have a look at OC_Helper::previewIcon
  */
@@ -193,6 +193,7 @@ 
 
 /**
  * @param string $path
+ * @param string $token
  */
 function publicPreview_icon ( $path, $token ) {
 	return OC_Helper::publicPreviewIcon( $path, $token );

lib/private/Template/Base.php

Doc Comments +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
 	/**
 	 * Appends a variable
 	 * @param string $key key
-	 * @param mixed $value value
+	 * @param string $value value
 	 * @return boolean|null
 	 *
 	 * This function assigns a variable in an array context. If the key already

lib/private/DB/QueryBuilder/QueryBuilder.php

Doc Comments +4 added lines, -4 removed lines

@@ -306,7 +306,7 @@ 
 	 *         ->leftJoin('u', 'phonenumbers', 'p', 'u.id = p.user_id');
 	 * </code>
 	 *
-	 * @param mixed $select The selection expressions.
+	 * @param string $select The selection expressions.
 	 *
 	 * @return \OCP\DB\QueryBuilder\IQueryBuilder This QueryBuilder instance.
 	 */
@@ -330,7 +330,7 @@ 
 	 *         ->leftJoin('u', 'phonenumbers', 'p', 'u.id = p.user_id');
 	 * </code>
 	 *
-	 * @param mixed $select The selection expressions.
+	 * @param QueryFunction $select The selection expressions.
 	 * @param string $alias The column alias used in the constructed query.
 	 *
 	 * @return \OCP\DB\QueryBuilder\IQueryBuilder This QueryBuilder instance.
@@ -652,7 +652,7 @@ 
 	 *         ->where($or);
 	 * </code>
 	 *
-	 * @param mixed $predicates The restriction predicates.
+	 * @param CompositeExpression $predicates The restriction predicates.
 	 *
 	 * @return \OCP\DB\QueryBuilder\IQueryBuilder This QueryBuilder instance.
 	 */
@@ -1034,7 +1034,7 @@ 
 	 *
 	 * @param string $name
 	 *
-	 * @return IParameter
+	 * @return string
 	 */
 	public function createParameter($name) {
 		return new Parameter(':' . $name);

apps/files_external/lib/Command/Backends.php

Unused Use Statements -6 removed lines

@@ -22,18 +22,12 @@
 namespace OCA\Files_External\Command;
 
 use OC\Core\Command\Base;
-use OCA\Files_External\Lib\Auth\AuthMechanism;
 use OCA\Files_External\Lib\Backend\Backend;
 use OCA\Files_External\Lib\DefinitionParameter;
 use OCA\Files_External\Service\BackendService;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
-use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Input\Input;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Backends extends Base {