owncloud / core

lib/private/db/connection.php

Doc Comments +2 added lines, -2 removed lines

@@ -160,7 +160,7 @@ 
 	 * columns or sequences.
 	 *
 	 * @param string $seqName Name of the sequence object from which the ID should be returned.
-	 * @return string A string representation of the last inserted ID.
+	 * @return integer A string representation of the last inserted ID.
 	 */
 	public function lastInsertId($seqName = null)
 	{
@@ -180,7 +180,7 @@ 
 	 *
 	 * @param string $table The table name (will replace *PREFIX* with the actual prefix)
 	 * @param array $input data that should be inserted into the table  (column name => value)
-	 * @param array|null $compare List of values that should be checked for "if not exists"
+	 * @param string[] $compare List of values that should be checked for "if not exists"
 	 *				If this is null or an empty array, all keys of $input will be compared
 	 *				Please note: text fields (clob) must not be used in the compare array
 	 * @return int number of inserted rows

lib/private/encryption/manager.php

Unused Use Statements -3 removed lines

@@ -26,13 +26,10 @@
 namespace OC\Encryption;
 
 use OC\Files\Filesystem;
-use OC\Files\Storage\Shared;
 use OC\Files\Storage\Wrapper\Encryption;
 use OC\Files\View;
-use OC\Search\Provider\File;
 use OCP\Encryption\IEncryptionModule;
 use OCP\Encryption\IManager;
-use OCP\Files\Mount\IMountPoint;
 use OCP\IConfig;
 use OCP\IL10N;
 use OCP\ILogger;

lib/private/files/mapper.php

Doc Comments +7 added lines

@@ -153,6 +153,9 @@ 
 		return $result['physic_path'];
 	}
 
+	/**
+	 * @param string|false $physicalPath
+	 */
 	private function resolvePhysicalPath($physicalPath) {
 		$physicalPath = $this->resolveRelativePath($physicalPath);
 		$sql = \OC_DB::prepare('SELECT * FROM `*PREFIX*file_map` WHERE `physic_path_hash` = ?');
@@ -210,6 +213,10 @@ 
 		return $physicalPath;
 	}
 
+	/**
+	 * @param string|false $logicPath
+	 * @param string|false $physicalPath
+	 */
 	private function insert($logicPath, $physicalPath) {
 		$sql = 'INSERT INTO `*PREFIX*file_map` (`logic_path`, `physic_path`, `logic_path_hash`, `physic_path_hash`)
 				VALUES (?, ?, ?, ?)';

lib/private/files/storage/wrapper/encryption.php

Doc Comments +1 added lines, -1 removed lines

@@ -192,7 +192,7 @@
 	 *
 	 * @param string $path
 	 * @param string $data
-	 * @return bool
+	 * @return integer
 	 */
 	public function file_put_contents($path, $data) {
 		// file put content will always be translated to a stream write

lib/private/files/view.php

Doc Comments +6 added lines, -3 removed lines

@@ -185,7 +185,7 @@ 
 	 * and does not take the chroot into account )
 	 *
 	 * @param string $path
-	 * @return \OCP\Files\Mount\IMountPoint
+	 * @return Mount\MountPoint|null
 	 */
 	public function getMount($path) {
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -426,7 +426,7 @@ 
 
 	/**
 	 * @param string $path
-	 * @return bool|mixed
+	 * @return string|boolean
 	 */
 	public function file_exists($path) {
 		if ($path == '/') {
@@ -856,7 +856,7 @@ 
 
 	/**
 	 * @param string $path
-	 * @return bool|string
+	 * @return string|false
 	 * @throws \OCP\Files\InvalidPathException
 	 */
 	public function toTmpFile($path) {
@@ -1574,6 +1574,9 @@ 
 		return null;
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function assertPathLength($path) {
 		$maxLen = min(PHP_MAXPATHLEN, 4000);
 		// Check for the string length - performed using isset() instead of strlen()

lib/private/preview.php

Doc Comments +10 added lines, -10 removed lines

@@ -197,7 +197,7 @@ 
 	/**
 	 * returns the max width set in ownCloud's config
 	 *
-	 * @return string
+	 * @return integer
 	 */
 	public function getConfigMaxX() {
 		return $this->configMaxWidth;
@@ -206,7 +206,7 @@ 
 	/**
 	 * returns the max height set in ownCloud's config
 	 *
-	 * @return string
+	 * @return integer
 	 */
 	public function getConfigMaxY() {
 		return $this->configMaxHeight;
@@ -509,7 +509,7 @@ 
 	/**
 	 * Determines the size of the preview we should be looking for in the cache
 	 *
-	 * @return int[]
+	 * @return integer[]
 	 */
 	private function simulatePreviewDimensions() {
 		$askedWidth = $this->getMaxX();
@@ -531,7 +531,7 @@ 
 	 * @param int $askedWidth
 	 * @param int $askedHeight
 	 *
-	 * @return \int[]
+	 * @return integer[]
 	 */
 	private function applyAspectRatio($askedWidth, $askedHeight) {
 		$originalRatio = $this->maxPreviewWidth / $this->maxPreviewHeight;
@@ -557,7 +557,7 @@ 
 	 * @param int $askedWidth
 	 * @param int $askedHeight
 	 *
-	 * @return \int[]
+	 * @return integer[]
 	 */
 	private function fixSize($askedWidth, $askedHeight) {
 		if ($this->scalingUp) {
@@ -844,9 +844,9 @@ 
 	 * @param int $askedWidth
 	 * @param int $askedHeight
 	 * @param int $previewWidth
-	 * @param null $previewHeight
+	 * @param integer $previewHeight
 	 *
-	 * @return int[]
+	 * @return double[]
 	 */
 	private function scale($image, $askedWidth, $askedHeight, $previewWidth, $previewHeight) {
 		$scalingUp = $this->getScalingUp();
@@ -894,7 +894,7 @@ 
 	 * @param int $askedWidth
 	 * @param int $askedHeight
 	 * @param int $previewWidth
-	 * @param null $previewHeight
+	 * @param double $previewHeight
 	 */
 	private function crop($image, $askedWidth, $askedHeight, $previewWidth, $previewHeight = null) {
 		$cropX = floor(abs($askedWidth - $previewWidth) * 0.5);
@@ -913,7 +913,7 @@ 
 	 * @param int $askedWidth
 	 * @param int $askedHeight
 	 * @param int $previewWidth
-	 * @param null $previewHeight
+	 * @param double $previewHeight
 	 */
 	private function cropAndFill($image, $askedWidth, $askedHeight, $previewWidth, $previewHeight) {
 		if ($previewWidth > $askedWidth) {
@@ -1138,7 +1138,7 @@ 
 	 * @param int $maxDim
 	 * @param string $dimName
 	 *
-	 * @return mixed
+	 * @return integer
 	 */
 	private function limitMaxDim($dim, $maxDim, $dimName) {
 		if (!is_null($maxDim)) {

lib/private/repair.php

Doc Comments +2 added lines

@@ -144,6 +144,8 @@
 	 * {@inheritDoc}
 	 *
 	 * Re-declared as public to allow invocation from within the closure above in php 5.3
+	 * @param string $scope
+	 * @param string $method
 	 */
 	public function emit($scope, $method, array $arguments = array()) {
 		parent::emit($scope, $method, $arguments);

lib/private/streamer.php

Doc Comments -1 removed lines

@@ -105,7 +105,6 @@
 	/**
 	 * Add an empty directory entry to the archive.
 	 *
-	 * @param string $directoryPath  Directory Path and name to be added to the archive.
 	 * @return bool $success
 	 */
 	public function addEmptyDir($dirName){

lib/private/template.php

Doc Comments +1 added lines, -1 removed lines

@@ -136,7 +136,7 @@
 	 * Returns the list of members for a group-principal
 	 *
 	 * @param string $principal
-	 * @return array
+	 * @return string[]
 	 */
 	function getGroupMemberSet($principal) {
 		// TODO: for now the group principal has only one member, the user itself