owncloud / core

apps/files_external/lib/config.php

Doc Comments +3 added lines, -2 removed lines

@@ -85,7 +85,7 @@ 
 	 * If the configuration parameter is optional, add a '&' to the beginning of the value
 	 * If the configuration parameter is hidden, add a '#' to the beginning of the value
 	 *
-	 * @return array
+	 * @return string
 	 */
 	public static function getBackends() {
 		$sortFunc = function ($a, $b) {
@@ -484,6 +484,7 @@ 
 	 *
 	 * @param string $class backend class name
 	 * @param array $options backend configuration options
+	 * @param boolean $isPersonal
 	 * @return int see self::STATUS_*
 	 */
 	public static function getBackendStatus($class, $options, $isPersonal) {
@@ -789,7 +790,7 @@ 
 	 * @param OC_L10N $l
 	 * @param string $module
 	 * @param string $backend
-	 * @return string
+	 * @return OC_L10N_String
 	 */
 	private static function getSingleDependencyMessage(OC_L10N $l, $module, $backend) {
 		switch (strtolower($module)) {

apps/files_external/lib/storageconfig.php

Doc Comments +2 added lines, -2 removed lines

@@ -174,7 +174,7 @@ 
 	}
 
 	/**
-	 * @param string $option
+	 * @param string $key
 	 * @return mixed
 	 */
 	public function getBackendOption($key) {
@@ -185,8 +185,8 @@ 
 	}
 
 	/**
-	 * @param string $option
 	 * @param mixed $value
+	 * @param string $key
 	 */
 	public function setBackendOption($key, $value) {
 		$this->backendOptions[$key] = $value;

apps/files_sharing/tests/controller/externalsharecontroller.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 
 namespace OCA\Files_Sharing\Controllers;
 
-use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\Http\JSONResponse;
 use OCP\Http\Client\IClientService;
 use OCP\IRequest;

apps/files_trashbin/lib/trashbin.php

Doc Comments +6 added lines, -5 removed lines

@@ -407,7 +407,7 @@ 
 	 * @param string $uniqueFilename new file name to restore the file without overwriting existing files
 	 * @param string $location location if file
 	 * @param int $timestamp deletion time
-	 * @return bool
+	 * @return false|null
 	 */
 	private static function restoreVersions(\OC\Files\View $view, $file, $filename, $uniqueFilename, $location, $timestamp) {
 
@@ -497,9 +497,10 @@ 
 
 	/**
 	 * @param \OC\Files\View $view
-	 * @param $file
-	 * @param $filename
-	 * @param $timestamp
+	 * @param string $file
+	 * @param string $filename
+	 * @param integer|null $timestamp
+	 * @param string $user
 	 * @return int
 	 */
 	private static function deleteVersions(\OC\Files\View $view, $file, $filename, $timestamp, $user) {
@@ -686,7 +687,7 @@ 
 	 * @param string $user
 	 * @param int $limit files older then limit should be deleted
 	 * @param int $retention_obligation max age of file in days
-	 * @return array size of deleted files and number of deleted files
+	 * @return integer[] size of deleted files and number of deleted files
 	 */
 	protected static function deleteExpiredFiles($files, $user, $limit, $retention_obligation) {
 		$size = 0;

lib/private/api.php

Doc Comments +2 added lines, -2 removed lines

@@ -155,7 +155,7 @@ 
 	/**
 	 * merge the returned result objects into one response
 	 * @param array $responses
-	 * @return array|\OC_OCS_Result
+	 * @return OC_OCS_Result
 	 */
 	public static function mergeResponses($responses) {
 		// Sort into shipped and third-party
@@ -293,7 +293,7 @@ 
 
 	/**
 	 * http basic auth
-	 * @return string|false (username, or false on failure)
+	 * @return string (username, or false on failure)
 	 */
 	private static function loginUser() {
 		if(self::$isLoggedIn === true) {

lib/private/app/appmanager.php

Doc Comments +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
 	/**
 	 * List all installed apps
 	 *
-	 * @return string[]
+	 * @return integer[]
 	 */
 	public function getInstalledApps() {
 		return array_keys($this->getInstalledAppsValues());

lib/private/app/codecheckvisitor.php

Doc Comments +3 added lines

@@ -28,6 +28,9 @@
 
 class CodeCheckVisitor extends NodeVisitorAbstract {
 
+	/**
+	 * @param string[] $blackListedClassNames
+	 */
 	public function __construct($blackListedClassNames) {
 		$this->blackListedClassNames = array_map('strtolower', $blackListedClassNames);
 	}

lib/private/appframework/middleware/security/corsmiddleware.php

Doc Comments +2 added lines, -2 removed lines

@@ -68,7 +68,7 @@ 
 	 * This is being run in normal order before the controller is being
 	 * called which allows several modifications and checks
 	 *
-	 * @param Controller $controller the controller that is being called
+	 * @param CORSMiddlewareTest $controller the controller that is being called
 	 * @param string $methodName the name of the method that will be called on
 	 *                           the controller
 	 * @since 6.0.0
@@ -92,7 +92,7 @@ 
 	 * This is being run after a successful controllermethod call and allows
 	 * the manipulation of a Response object. The middleware is run in reverse order
 	 *
-	 * @param Controller $controller the controller that is being called
+	 * @param CORSMiddlewareTest $controller the controller that is being called
 	 * @param string $methodName the name of the method that will be called on
 	 *                           the controller
 	 * @param Response $response the generated response from the controller

lib/private/backgroundjob/joblist.php

Doc Comments +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
 	}
 
 	/**
-	 * @param Job|string $job
+	 * @param \Test\BackgroundJob\TestJob $job
 	 * @param mixed $argument
 	 */
 	public function add($job, $argument = null) {
@@ -68,7 +68,7 @@ 
 	}
 
 	/**
-	 * @param Job|string $job
+	 * @param Job $job
 	 * @param mixed $argument
 	 */
 	public function remove($job, $argument = null) {