Completed
Pull Request — master (#30412)
by Tom
09:24
created
lib/private/Files/Storage/Wrapper/Encryption.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -672,7 +672,7 @@  discard block
 block discarded – undo
672 672
 	 * Set the flag to true, so that the file would be
673 673
 	 * in the decrypted state.
674 674
 	 *
675
-	 * @param $isDisabled bool
675
+	 * @param boolean $isDisabled bool
676 676
 	 */
677 677
 	public static function setDisableWriteEncryption($isDisabled) {
678 678
 		self::$disableWriteEncryption = $isDisabled;
@@ -929,7 +929,7 @@  discard block
 block discarded – undo
929 929
 	/**
930 930
 	 * return header size of given file
931 931
 	 *
932
-	 * @param string|resource $path
932
+	 * @param string $path
933 933
 	 * @return int
934 934
 	 */
935 935
 	protected function getHeaderSize($path) {
@@ -980,7 +980,7 @@  discard block
 block discarded – undo
980 980
 	/**
981 981
 	 * read header from file
982 982
 	 *
983
-	 * @param string|resource $path
983
+	 * @param string $path
984 984
 	 * @return array
985 985
 	 */
986 986
 	protected function getHeader($path) {
@@ -1076,7 +1076,7 @@  discard block
 block discarded – undo
1076 1076
 	/**
1077 1077
 	 * check if path points to a files version
1078 1078
 	 *
1079
-	 * @param $path
1079
+	 * @param string $path
1080 1080
 	 * @return bool
1081 1081
 	 */
1082 1082
 	protected function isVersion($path) {
Please login to merge, or discard this patch.
lib/private/AllConfig.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -449,7 +449,7 @@
 block discarded – undo
449 449
 	 * In some environments the system config file is readonly. Find out if this
450 450
 	 * is the case.
451 451
 	 *
452
-	 * @return boolean
452
+	 * @return false|string
453 453
 	 * @since 10.0.3
454 454
 	 */
455 455
 	public function isSystemConfigReadOnly() {
Please login to merge, or discard this patch.
lib/private/Files/Storage/Common.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -699,7 +699,7 @@
 block discarded – undo
699 699
 	}
700 700
 
701 701
 	/**
702
-	 * @param $internalPath
702
+	 * @param string $internalPath
703 703
 	 * @return array
704 704
 	 */
705 705
 	private function convertInternalPathToGlobalPath($internalPath) {
Please login to merge, or discard this patch.
apps/files_versions/lib/Storage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -310,6 +310,9 @@
 block discarded – undo
310 310
 	}
311 311
 
312 312
 
313
+	/**
314
+	 * @param string $revision
315
+	 */
313 316
 	public static function restoreVersion($uid, $filename, $fileToRestore, $revision) {
314 317
 		if(\OCP\Config::getSystemValue('files_versions', Storage::DEFAULTENABLED) !== true) {
315 318
 			return false;
Please login to merge, or discard this patch.
lib/private/User/Manager.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -432,6 +432,9 @@
 block discarded – undo
432 432
 		}, $accounts);
433 433
 	}
434 434
 
435
+	/**
436
+	 * @param string $backendClass
437
+	 */
435 438
 	public function getBackend($backendClass) {
436 439
 		if (isset($this->backends[$backendClass])) {
437 440
 			return $this->backends[$backendClass];
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -39,9 +39,6 @@
 block discarded – undo
39 39
 use OCP\IUser;
40 40
 use OCP\IUserManager;
41 41
 use OCP\IConfig;
42
-use OCP\User\IProvidesExtendedSearchBackend;
43
-use OCP\User\IProvidesEMailBackend;
44
-use OCP\User\IProvidesQuotaBackend;
45 42
 use OCP\UserInterface;
46 43
 use Symfony\Component\EventDispatcher\GenericEvent;
47 44
 
Please login to merge, or discard this patch.
lib/private/User/User.php 2 patches
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	 *
79 79
 	 * @param Account $account
80 80
 	 * @param AccountMapper $mapper
81
-	 * @param null $emitter
81
+	 * @param Manager $emitter
82 82
 	 * @param IConfig|null $config
83 83
 	 * @param null $urlGenerator
84 84
 	 * @param EventDispatcher|null $eventDispatcher
@@ -452,6 +452,10 @@  discard block
 block discarded – undo
452 452
 		return $url;
453 453
 	}
454 454
 
455
+	/**
456
+	 * @param string $feature
457
+	 * @param string $value
458
+	 */
455 459
 	public function triggerChange($feature, $value = null) {
456 460
 		if ($this->emitter && in_array($feature, $this->account->getUpdatedFields())) {
457 461
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,6 @@
 block discarded – undo
41 41
 use OCP\IConfig;
42 42
 use OCP\IUserBackend;
43 43
 use OCP\User\IChangePasswordBackend;
44
-use OCP\UserInterface;
45 44
 use Symfony\Component\EventDispatcher\EventDispatcher;
46 45
 use Symfony\Component\EventDispatcher\GenericEvent;
47 46
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -257,6 +257,9 @@  discard block
 block discarded – undo
257 257
 			'file', 'create');
258 258
 	}
259 259
 
260
+	/**
261
+	 * @param string $path
262
+	 */
260 263
 	private function getPartFileBasePath($path) {
261 264
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
262 265
 		if ($partFileInStorage) {
@@ -626,7 +629,7 @@  discard block
 block discarded – undo
626 629
 	/**
627 630
 	 * Set $algo to get a specific checksum, leave null to get all checksums
628 631
 	 * (space seperated)
629
-	 * @param null $algo
632
+	 * @param string $algo
630 633
 	 * @return string
631 634
 	 */
632 635
 	public function getChecksum($algo = null) {
@@ -649,6 +652,9 @@  discard block
 block discarded – undo
649 652
 		return '';
650 653
 	}
651 654
 
655
+	/**
656
+	 * @param string $string
657
+	 */
652 658
 	protected function header($string) {
653 659
 		\header($string);
654 660
 	}
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/CorsPlugin.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 	 * This method should set up the required event subscriptions.
63 63
 	 *
64 64
 	 * @param \Sabre\DAV\Server $server
65
-	 * @return void
65
+	 * @return false|null
66 66
 	 */
67 67
 	public function initialize(\Sabre\DAV\Server $server) {
68 68
 		$this->server = $server;
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	 * @param RequestInterface $request
97 97
 	 * @param ResponseInterface $response
98 98
 	 *
99
-	 * @return false
99
+	 * @return false|null
100 100
 	 */
101 101
 	public function setOptionsRequestHeaders(RequestInterface $request, ResponseInterface $response) {
102 102
 		$authorization = $request->getHeader('Authorization');
Please login to merge, or discard this patch.
lib/private/legacy/response.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 	 * @param string $domain
276 276
 	 * @param Sabre\HTTP\ResponseInterface $response
277 277
 	 * @param \OCP\IConfig $config
278
-	 * @param Array $headers
278
+	 * @param string[] $headers
279 279
 	 *
280 280
 	 * Format of $headers:
281 281
 	 * Array [
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
 	 * This function adds the CORS headers for all domains
315 315
 	 *
316 316
 	 * @param Sabre\HTTP\ResponseInterface $response
317
-	 * @param Array $headers
317
+	 * @param string[] $headers
318 318
 	 *
319 319
 	 * Format of $headers:
320 320
 	 * Array [
Please login to merge, or discard this patch.