Completed
Pull Request — master (#27468)
by Martin
09:41
created
lib/private/Settings/SettingsManager.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -39,7 +39,6 @@  discard block
 block discarded – undo
39 39
 use OCP\IGroupManager;
40 40
 use OCP\Defaults;
41 41
 use OCP\IURLGenerator;
42
-
43 42
 use OC\Settings\Panels\Personal\Profile;
44 43
 use OC\Settings\Panels\Personal\Legacy as LegacyPersonal;
45 44
 use OC\Settings\Panels\Admin\Legacy as LegacyAdmin;
@@ -54,7 +53,6 @@  discard block
 block discarded – undo
54 53
 use OC\Settings\Panels\Admin\Mail;
55 54
 use OC\Settings\Panels\Admin\Logging;
56 55
 use OC\Settings\Panels\Admin\SecurityWarning;
57
-use OC\Settings\Panels\Admin\Updater;
58 56
 use OC\Settings\Panels\Admin\Tips;
59 57
 use OC\Settings\Panels\Admin\Status;
60 58
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use Sabre\DAV\ServerPlugin;
31 31
 use Sabre\DAV\Tree;
32 32
 use Sabre\DAV\Xml\Element\Response;
33
-use Sabre\DAV\Xml\Response\MultiStatus;
34 33
 use Sabre\DAV\PropFind;
35 34
 use OCP\SystemTag\ISystemTagObjectMapper;
36 35
 use OCP\IUserSession;
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	 * This will be used in the {DAV:}supported-report-set property.
153 153
 	 *
154 154
 	 * @param string $uri
155
-	 * @return array
155
+	 * @return string[]
156 156
 	 */
157 157
 	public function getSupportedReportSet($uri) {
158 158
 		return [self::REPORT_NAME];
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 	 * @param string $reportName
165 165
 	 * @param mixed $report
166 166
 	 * @param string $uri
167
-	 * @return bool
167
+	 * @return null|false
168 168
 	 * @throws BadRequest
169 169
 	 * @throws PreconditionFailed
170 170
 	 * @internal param $ [] $report
@@ -350,6 +350,7 @@  discard block
 block discarded – undo
350 350
 	 * with a leading slash but no trailing slash
351 351
 	 * @param string[] $requestedProps requested properties
352 352
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
353
+	 * @param Node[] $nodes
353 354
 	 * @return Response[]
354 355
 	 */
355 356
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {
Please login to merge, or discard this patch.
lib/private/Console/Application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,6 @@
 block discarded – undo
37 37
 use Symfony\Component\Console\Input\InputInterface;
38 38
 use Symfony\Component\Console\Input\InputOption;
39 39
 use Symfony\Component\Console\Output\OutputInterface;
40
-use Symfony\Component\Console\Output\ConsoleOutputInterface;
41 40
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
42 41
 
43 42
 class Application {
Please login to merge, or discard this patch.
lib/private/Encryption/Util.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use OC\Files\Filesystem;
32 32
 use OC\Files\View;
33 33
 use OCP\Encryption\IEncryptionModule;
34
-use OCP\Files\Storage;
35 34
 use OCP\IConfig;
36 35
 use OCP\IUser;
37 36
 
Please login to merge, or discard this patch.
lib/private/Files/Stream/Checksum.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
 
65 65
 
66 66
 	/**
67
-	 * @param $source
68
-	 * @param $path
67
+	 * @param resource $source
68
+	 * @param string $path
69 69
 	 * @return resource
70 70
 	 */
71 71
 	public static function wrap($source, $path) {
@@ -126,6 +126,9 @@  discard block
 block discarded – undo
126 126
 		return parent::stream_write($data);
127 127
 	}
128 128
 
129
+	/**
130
+	 * @param string $data
131
+	 */
129 132
 	private function updateHashingContexts($data) {
130 133
 		foreach ($this->hashingContexts as $ctx) {
131 134
 			hash_update($ctx, $data);
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/SharesPlugin.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,6 @@
 block discarded – undo
68 68
 	/**
69 69
 	 * @param \Sabre\DAV\Tree $tree tree
70 70
 	 * @param IUserSession $userSession user session
71
-	 * @param \OCP\Files\Folder $userFolder user home folder
72 71
 	 * @param \OCP\Share\IManager $shareManager share manager
73 72
 	 */
74 73
 	public function __construct(
Please login to merge, or discard this patch.
apps/files_sharing/lib/Controller/ShareesController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
 	 * split user and remote from federated cloud id
359 359
 	 *
360 360
 	 * @param string $address federated share address
361
-	 * @return array [user, remoteURL]
361
+	 * @return string[] [user, remoteURL]
362 362
 	 * @throws \Exception
363 363
 	 */
364 364
 	public function splitUserRemote($address) {
@@ -567,7 +567,7 @@  discard block
 block discarded – undo
567 567
 	 * trusted domain entries
568 568
 	 *
569 569
 	 * @param string $target target
570
-	 * @return true if one match was found, false otherwise
570
+	 * @return boolean if one match was found, false otherwise
571 571
 	 */
572 572
 	protected function isInstanceDomain($target) {
573 573
 		if (strpos($target, '/') !== false) {
Please login to merge, or discard this patch.
lib/private/DB/Migrator.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -235,6 +235,10 @@
 block discarded – undo
235 235
 		return '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
236 236
 	}
237 237
 
238
+	/**
239
+	 * @param integer $step
240
+	 * @param integer $max
241
+	 */
238 242
 	protected function emit($sql, $step, $max) {
239 243
 		if ($this->noEmit) {
240 244
 			return;
Please login to merge, or discard this patch.
lib/private/DB/OracleMigrator.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,6 @@
 block discarded – undo
36 36
 	 * the column instance and copying over all properties.
37 37
 	 *
38 38
 	 * @param Column $column old column
39
-	 * @param string $newName new name
40 39
 	 * @return Column new column instance with new name
41 40
 	 */
42 41
 	protected function quoteColumn($column) {
Please login to merge, or discard this patch.