Completed
Pull Request — master (#27468)
by Martin
09:41
created
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -213,6 +213,10 @@  discard block
 block discarded – undo
213 213
 
214 214
 	/**
215 215
 	 *
216
+	 * @param string $user
217
+	 * @param string $targetFilename
218
+	 * @param string $targetLocation
219
+	 * @param integer $timestamp
216 220
 	 */
217 221
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
218 222
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -756,7 +760,7 @@  discard block
 block discarded – undo
756 760
 	 * if the size limit for the trash bin is reached, we delete the oldest
757 761
 	 * files in the trash bin until we meet the limit again
758 762
 	 *
759
-	 * @param array $files
763
+	 * @param \OCP\Files\FileInfo[] $files
760 764
 	 * @param string $user
761 765
 	 * @param int $availableSpace available disc space
762 766
 	 * @return int size of deleted files
@@ -784,7 +788,7 @@  discard block
 block discarded – undo
784 788
 	/**
785 789
 	 * delete files older then max storage time
786 790
 	 *
787
-	 * @param array $files list of files sorted by mtime
791
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
788 792
 	 * @param string $user
789 793
 	 * @return integer[] size of deleted files and number of deleted files
790 794
 	 */
Please login to merge, or discard this patch.
lib/private/App/AppManager.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 	/**
121 121
 	 * List all installed apps
122 122
 	 *
123
-	 * @return string[]
123
+	 * @return integer[]
124 124
 	 */
125 125
 	public function getInstalledApps() {
126 126
 		return array_keys($this->getInstalledAppsValues());
@@ -347,6 +347,9 @@  discard block
 block discarded – undo
347 347
 		return in_array($appId, $this->shippedApps);
348 348
 	}
349 349
 
350
+	/**
351
+	 * @param string $appId
352
+	 */
350 353
 	private function isAlwaysEnabled($appId) {
351 354
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
352 355
 		return in_array($appId, $alwaysEnabled);
@@ -374,7 +377,7 @@  discard block
 block discarded – undo
374 377
 
375 378
 	/**
376 379
 	 * @param string $package
377
-	 * @return mixed
380
+	 * @return integer
378 381
 	 * @since 10.0
379 382
 	 */
380 383
 	public function installApp($package) {
@@ -386,7 +389,7 @@  discard block
 block discarded – undo
386 389
 
387 390
 	/**
388 391
 	 * @param string $package
389
-	 * @return mixed
392
+	 * @return boolean
390 393
 	 * @since 10.0
391 394
 	 */
392 395
 	public function updateApp($package) {
Please login to merge, or discard this patch.
lib/private/User/Manager.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -395,7 +395,6 @@
 block discarded – undo
395 395
 
396 396
 	/**
397 397
 	 * @param \Closure $callback
398
-	 * @param string $search
399 398
 	 * @since 10.0
400 399
 	 */
401 400
 	public function callForSeenUsers (\Closure $callback) {
Please login to merge, or discard this patch.
lib/public/IUserManager.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,6 +45,7 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @param \OCP\UserInterface $backend
47 47
 	 * @since 8.0.0
48
+	 * @return void
48 49
 	 */
49 50
 	public function registerBackend($backend);
50 51
 
@@ -60,12 +61,14 @@  discard block
 block discarded – undo
60 61
 	 *
61 62
 	 * @param \OCP\UserInterface $backend
62 63
 	 * @since 8.0.0
64
+	 * @return void
63 65
 	 */
64 66
 	public function removeBackend($backend);
65 67
 
66 68
 	/**
67 69
 	 * remove all user backends
68 70
 	 * @since 8.0.0
71
+	 * @return void
69 72
 	 */
70 73
 	public function clearBackends() ;
71 74
 
@@ -131,7 +134,7 @@  discard block
 block discarded – undo
131 134
 	/**
132 135
 	 * returns how many users per backend exist (if supported by backend)
133 136
 	 *
134
-	 * @return array an array of backend class as key and count number as value
137
+	 * @return integer an array of backend class as key and count number as value
135 138
 	 * @since 8.0.0
136 139
 	 */
137 140
 	public function countUsers();
@@ -140,6 +143,7 @@  discard block
 block discarded – undo
140 143
 	 * @param \Closure $callback
141 144
 	 * @param string $search
142 145
 	 * @since 9.0.0
146
+	 * @return void
143 147
 	 */
144 148
 	public function callForAllUsers (\Closure $callback, $search = '');
145 149
 
@@ -153,8 +157,8 @@  discard block
 block discarded – undo
153 157
 
154 158
 	/**
155 159
 	 * @param \Closure $callback
156
-	 * @param string $search
157 160
 	 * @since 10.0
161
+	 * @return void
158 162
 	 */
159 163
 	public function callForSeenUsers (\Closure $callback);
160 164
 
Please login to merge, or discard this patch.
lib/private/legacy/app.php 1 patch
Doc Comments   -3 removed lines patch added patch discarded remove patch
@@ -807,9 +807,6 @@
 block discarded – undo
807 807
 	/**
808 808
 	 * List all apps, this is used in apps.php
809 809
 	 *
810
-	 * @param bool $onlyLocal
811
-	 * @param bool $includeUpdateInfo Should we check whether there is an update
812
-	 *                                in the app store?
813 810
 	 * @return array
814 811
 	 */
815 812
 	public static function listAllApps() {
Please login to merge, or discard this patch.
lib/private/AppFramework/Http/Request.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@
 block discarded – undo
448 448
 
449 449
 	/**
450 450
 	 * Checks if the CSRF check was correct
451
-	 * @return bool true if CSRF check passed
451
+	 * @return boolean|null true if CSRF check passed
452 452
 	 */
453 453
 	public function passesCSRFCheck() {
454 454
 		if($this->csrfTokenManager === null) {
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Publishing/Xml/Publisher.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  */
21 21
 namespace OCA\DAV\CalDAV\Publishing\Xml;
22 22
 
23
-use OCA\DAV\CalDAV\Publishing\PublishPlugin as Plugin;
24 23
 use Sabre\Xml\Writer;
25 24
 use Sabre\Xml\XmlSerializable;
26 25
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -236,6 +236,9 @@  discard block
 block discarded – undo
236 236
 		return '"' . $this->info->getEtag() . '"';
237 237
 	}
238 238
 
239
+	/**
240
+	 * @param string $path
241
+	 */
239 242
 	private function getPartFileBasePath($path) {
240 243
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
241 244
 		if ($partFileInStorage) {
@@ -598,7 +601,7 @@  discard block
 block discarded – undo
598 601
 	/**
599 602
 	 * Set $algo to get a specific checksum, leave null to get all checksums
600 603
 	 * (space seperated)
601
-	 * @param null $algo
604
+	 * @param string $algo
602 605
 	 * @return string
603 606
 	 */
604 607
 	public function getChecksum($algo = null) {
Please login to merge, or discard this patch.
apps/dav/appinfo/Migrations/Version20170202213905.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 
29 29
 	/**
30 30
 	 * @param IDBConnection $connection
31
-	 * @return array
31
+	 * @return string[]
32 32
 	 */
33 33
 	public function sql(IDBConnection $connection) {
34 34
 		$qb = $connection->getQueryBuilder();
Please login to merge, or discard this patch.