Completed
Pull Request — master (#25100)
by Roeland
09:57
created
apps/user_ldap/lib/Command/SetConfig.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -73,8 +73,6 @@
 block discarded – undo
73 73
 	/**
74 74
 	 * save the configuration value as provided
75 75
 	 * @param string $configID
76
-	 * @param string $configKey
77
-	 * @param string $configValue
78 76
 	 */
79 77
 	protected function setValue($configID, $key, $value) {
80 78
 		$configHolder = new Configuration($configID);
Please login to merge, or discard this patch.
apps/user_ldap/lib/Jobs/UpdateGroups.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 	}
69 69
 
70 70
 	/**
71
-	 * @return int
71
+	 * @return string
72 72
 	 */
73 73
 	static private function getRefreshInterval() {
74 74
 		//defaults to every hour
Please login to merge, or discard this patch.
apps/user_ldap/lib/Wizard.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -864,7 +864,7 @@  discard block
 block discarded – undo
864 864
 	 * @param integer $filterType int, for which use case the filter shall be created
865 865
 	 * can be any of self::LFILTER_USER_LIST, self::LFILTER_LOGIN or
866 866
 	 * self::LFILTER_GROUP_LIST
867
-	 * @return string|false string with the filter on success, false otherwise
867
+	 * @return string string with the filter on success, false otherwise
868 868
 	 * @throws \Exception
869 869
 	 */
870 870
 	private function composeLdapFilter($filterType) {
@@ -1107,7 +1107,7 @@  discard block
 block discarded – undo
1107 1107
 	}
1108 1108
 
1109 1109
 	/**
1110
-	 * @param array $reqs
1110
+	 * @param string[] $reqs
1111 1111
 	 * @return bool
1112 1112
 	 */
1113 1113
 	private function checkRequirements($reqs) {
Please login to merge, or discard this patch.
lib/private/DB/QueryBuilder/QueryBuilder.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 	 *         ->leftJoin('u', 'phonenumbers', 'p', 'u.id = p.user_id');
307 307
 	 * </code>
308 308
 	 *
309
-	 * @param mixed $select The selection expressions.
309
+	 * @param string $select The selection expressions.
310 310
 	 *
311 311
 	 * @return \OCP\DB\QueryBuilder\IQueryBuilder This QueryBuilder instance.
312 312
 	 */
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
330 330
 	 *         ->leftJoin('u', 'phonenumbers', 'p', 'u.id = p.user_id');
331 331
 	 * </code>
332 332
 	 *
333
-	 * @param mixed $select The selection expressions.
333
+	 * @param QueryFunction $select The selection expressions.
334 334
 	 * @param string $alias The column alias used in the constructed query.
335 335
 	 *
336 336
 	 * @return \OCP\DB\QueryBuilder\IQueryBuilder This QueryBuilder instance.
@@ -652,7 +652,7 @@  discard block
 block discarded – undo
652 652
 	 *         ->where($or);
653 653
 	 * </code>
654 654
 	 *
655
-	 * @param mixed $predicates The restriction predicates.
655
+	 * @param CompositeExpression $predicates The restriction predicates.
656 656
 	 *
657 657
 	 * @return \OCP\DB\QueryBuilder\IQueryBuilder This QueryBuilder instance.
658 658
 	 */
@@ -1034,7 +1034,7 @@  discard block
 block discarded – undo
1034 1034
 	 *
1035 1035
 	 * @param string $name
1036 1036
 	 *
1037
-	 * @return IParameter
1037
+	 * @return string
1038 1038
 	 */
1039 1039
 	public function createParameter($name) {
1040 1040
 		return new Parameter(':' . $name);
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Backends.php 1 patch
Unused Use Statements   -6 removed lines patch added patch discarded remove patch
@@ -22,18 +22,12 @@
 block discarded – undo
22 22
 namespace OCA\Files_External\Command;
23 23
 
24 24
 use OC\Core\Command\Base;
25
-use OCA\Files_External\Lib\Auth\AuthMechanism;
26 25
 use OCA\Files_External\Lib\Backend\Backend;
27 26
 use OCA\Files_External\Lib\DefinitionParameter;
28 27
 use OCA\Files_External\Service\BackendService;
29 28
 use Symfony\Component\Console\Command\Command;
30
-use Symfony\Component\Console\Helper\Table;
31
-use Symfony\Component\Console\Helper\TableHelper;
32
-use Symfony\Component\Console\Input\ArrayInput;
33 29
 use Symfony\Component\Console\Input\InputArgument;
34 30
 use Symfony\Component\Console\Input\InputInterface;
35
-use Symfony\Component\Console\Input\InputOption;
36
-use Symfony\Component\Console\Input\Input;
37 31
 use Symfony\Component\Console\Output\OutputInterface;
38 32
 
39 33
 class Backends extends Base {
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Config.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -26,11 +26,8 @@
 block discarded – undo
26 26
 use OCA\Files_external\NotFoundException;
27 27
 use OCA\Files_external\Service\GlobalStoragesService;
28 28
 use Symfony\Component\Console\Command\Command;
29
-use Symfony\Component\Console\Helper\Table;
30
-use Symfony\Component\Console\Helper\TableHelper;
31 29
 use Symfony\Component\Console\Input\InputArgument;
32 30
 use Symfony\Component\Console\Input\InputInterface;
33
-use Symfony\Component\Console\Input\InputOption;
34 31
 use Symfony\Component\Console\Output\OutputInterface;
35 32
 
36 33
 class Config extends Base {
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/AmazonS3.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/Dropbox.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/SFTP.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.