Completed
Pull Request — master (#27214)
by Martin
54:56
created
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 	 * the next element.
80 80
 	 *
81 81
 	 * @param Reader $reader
82
-	 * @return mixed
82
+	 * @return null|TagList
83 83
 	 */
84 84
 	static function xmlDeserialize(Reader $reader) {
85 85
 		$tags = [];
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/AddressBookImpl.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	 * @param AddressBook $addressBook
52 52
 	 * @param array $addressBookInfo
53 53
 	 * @param CardDavBackend $backend
54
-	 * @param IUrlGenerator $urlGenerator
54
+	 * @param IURLGenerator $urlGenerator
55 55
 	 */
56 56
 	public function __construct(
57 57
 			AddressBook $addressBook,
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	}
135 135
 
136 136
 	/**
137
-	 * @return mixed
137
+	 * @return integer
138 138
 	 * @since 5.0.0
139 139
 	 */
140 140
 	public function getPermissions() {
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 	 * read vCard data into a vCard object
173 173
 	 *
174 174
 	 * @param string $cardData
175
-	 * @return VCard
175
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
176 176
 	 */
177 177
 	protected function readCard($cardData) {
178 178
 		return  Reader::read($cardData);
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +8 added lines, -3 removed lines patch added patch discarded remove patch
@@ -189,7 +189,8 @@  discard block
 block discarded – undo
189 189
 	}
190 190
 
191 191
 	/**
192
-	 * @param $addressBookUri
192
+	 * @param string $addressBookUri
193
+	 * @param string $principal
193 194
 	 * @return array|null
194 195
 	 */
195 196
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -871,6 +872,7 @@  discard block
 block discarded – undo
871 872
 	 *   * readOnly - boolean
872 873
 	 *   * summary - Optional, a description for the share
873 874
 	 *
875
+	 * @param integer $addressBookId
874 876
 	 * @return array
875 877
 	 */
876 878
 	public function getShares($addressBookId) {
@@ -924,7 +926,7 @@  discard block
 block discarded – undo
924 926
 	 * read vCard data into a vCard object
925 927
 	 *
926 928
 	 * @param string $cardData
927
-	 * @return VCard
929
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
928 930
 	 */
929 931
 	protected function readCard($cardData) {
930 932
 		return  Reader::read($cardData);
@@ -970,7 +972,7 @@  discard block
 block discarded – undo
970 972
 
971 973
 	/**
972 974
 	 * For shared address books the sharee is set in the ACL of the address book
973
-	 * @param $addressBookId
975
+	 * @param integer $addressBookId
974 976
 	 * @param $acl
975 977
 	 * @return array
976 978
 	 */
@@ -978,6 +980,9 @@  discard block
 block discarded – undo
978 980
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
979 981
 	}
980 982
 
983
+	/**
984
+	 * @param boolean $toV2
985
+	 */
981 986
 	private function convertPrincipal($principalUri, $toV2) {
982 987
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
983 988
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
apps/files_sharing/lib/Controller/ShareesController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -327,7 +327,7 @@
 block discarded – undo
327 327
 	 * split user and remote from federated cloud id
328 328
 	 *
329 329
 	 * @param string $address federated share address
330
-	 * @return array [user, remoteURL]
330
+	 * @return string[] [user, remoteURL]
331 331
 	 * @throws \Exception
332 332
 	 */
333 333
 	public function splitUserRemote($address) {
Please login to merge, or discard this patch.
apps/federation/lib/Controller/OCSAuthAPIController.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -164,6 +164,10 @@
 block discarded – undo
164 164
 			'data' => ['sharedSecret' => $sharedSecret]];
165 165
 	}
166 166
 
167
+	/**
168
+	 * @param string $url
169
+	 * @param string $token
170
+	 */
167 171
 	protected function isValidToken($url, $token) {
168 172
 		$storedToken = $this->dbHandler->getToken($url);
169 173
 		return hash_equals($storedToken, $token);
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -262,6 +262,9 @@  discard block
 block discarded – undo
262 262
 		return array_values($calendars);
263 263
 	}
264 264
 
265
+	/**
266
+	 * @param string $principalUri
267
+	 */
265 268
 	public function getUsersOwnCalendars($principalUri) {
266 269
 		$principalUri = $this->convertPrincipal($principalUri, true);
267 270
 		$fields = array_values($this->propertyMap);
@@ -1254,7 +1257,7 @@  discard block
 block discarded – undo
1254 1257
 	 * @param string $principalUri
1255 1258
 	 * @param string $uri
1256 1259
 	 * @param array $properties
1257
-	 * @return mixed
1260
+	 * @return integer
1258 1261
 	 */
1259 1262
 	function createSubscription($principalUri, $uri, array $properties) {
1260 1263
 
@@ -1657,6 +1660,9 @@  discard block
 block discarded – undo
1657 1660
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1658 1661
 	}
1659 1662
 
1663
+	/**
1664
+	 * @param boolean $toV2
1665
+	 */
1660 1666
 	private function convertPrincipal($principalUri, $toV2) {
1661 1667
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1662 1668
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
lib/private/AvatarManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,9 @@
 block discarded – undo
99 99
 		}
100 100
 	}
101 101
 
102
+	/**
103
+	 * @param string $userId
104
+	 */
102 105
 	private function buildAvatarPath($userId) {
103 106
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
104 107
 		return explode('/', $avatar);
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/ImageExportPlugin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -136,6 +136,9 @@
 block discarded – undo
136 136
 		return false;
137 137
 	}
138 138
 
139
+	/**
140
+	 * @param string $cardData
141
+	 */
139 142
 	private function readCard($cardData) {
140 143
 		return Reader::read($cardData);
141 144
 	}
Please login to merge, or discard this patch.
lib/private/L10N/Factory.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -278,6 +278,11 @@
 block discarded – undo
278 278
 	 */
279 279
 	// FIXME This method is only public, until \OCP\IL10N does not need it anymore,
280 280
 	// FIXME This is also the reason, why it is not in the public interface
281
+
282
+	/**
283
+	 * @param string $app
284
+	 * @param string $lang
285
+	 */
281 286
 	public function getL10nFilesForApp($app, $lang) {
282 287
 		$languageFiles = [];
283 288
 
Please login to merge, or discard this patch.