Completed
Pull Request — master (#26705)
by Philipp
09:04
created
apps/files_external/lib/Command/Backends.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -27,13 +27,8 @@
 block discarded – undo
27 27
 use OCA\Files_External\Lib\DefinitionParameter;
28 28
 use OCA\Files_External\Service\BackendService;
29 29
 use Symfony\Component\Console\Command\Command;
30
-use Symfony\Component\Console\Helper\Table;
31
-use Symfony\Component\Console\Helper\TableHelper;
32
-use Symfony\Component\Console\Input\ArrayInput;
33 30
 use Symfony\Component\Console\Input\InputArgument;
34 31
 use Symfony\Component\Console\Input\InputInterface;
35
-use Symfony\Component\Console\Input\InputOption;
36
-use Symfony\Component\Console\Input\Input;
37 32
 use Symfony\Component\Console\Output\OutputInterface;
38 33
 
39 34
 class Backends extends Base {
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Publishing/Xml/Publisher.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace OCA\DAV\CalDAV\Publishing\Xml;
4 4
 
5
-use OCA\DAV\CalDAV\Publishing\PublishPlugin as Plugin;
6 5
 use Sabre\Xml\Writer;
7 6
 use Sabre\Xml\XmlSerializable;
8 7
 
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Import.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@
 block discarded – undo
25 25
 use OC\Core\Command\Base;
26 26
 use OC\User\NoUserException;
27 27
 use OCA\Files_External\Lib\StorageConfig;
28
-use OCP\Files\External\IStorageConfig;
29 28
 use OCA\Files_External\Service\BackendService;
30 29
 use OCA\Files_External\Service\GlobalStoragesService;
31 30
 use OCA\Files_External\Service\ImportLegacyStoragesService;
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Backend/SMB.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
 	}
57 57
 
58 58
 	/**
59
-	 * @param StorageConfig $storage
59
+	 * @param IStorageConfig $storage
60 60
 	 * @param IUser $user
61 61
 	 */
62 62
 	public function manipulateStorageConfig(IStorageConfig &$storage, IUser $user = null) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
apps/dav/lib/DAV/PublicAuth.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	private $publicURLs;
31 31
 
32 32
 	/**
33
-	 * @param string[] $publicURLs
34 33
 	 */
35 34
 	public function __construct() {
36 35
 		$this->publicURLs = [
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Backend/AmazonS3.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -22,11 +22,9 @@
 block discarded – undo
22 22
 namespace OCA\Files_External\Lib\Backend;
23 23
 
24 24
 use OCP\IL10N;
25
-use OCP\Files\External\Auth\AuthMechanism;
26 25
 use OCP\Files\External\Backend\Backend;
27 26
 use OCP\Files\External\DefinitionParameter;
28 27
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
29
-
30 28
 use OCA\Files_External\Lib\Auth\AmazonS3\AccessKey;
31 29
 
32 30
 class AmazonS3 extends Backend {
Please login to merge, or discard this patch.
lib/private/Files/External/StoragesBackendService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
lib/private/Repair/RepairUnmergedShares.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@
 block discarded – undo
207 207
 	 * @param array $groupSharesById
208 208
 	 * @param array $subShares
209 209
 	 *
210
-	 * @return true if the share is valid, false if it needs repair
210
+	 * @return boolean if the share is valid, false if it needs repair
211 211
 	 */
212 212
 	private function isThisShareValid($groupSharesById, $subShares) {
213 213
 		$foundTargets = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/QuotaPlugin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -111,6 +111,9 @@
 block discarded – undo
111 111
 		return true;
112 112
 	}
113 113
 
114
+	/**
115
+	 * @param string[] $info
116
+	 */
114 117
 	public function getFileChunking($info) {
115 118
 		// FIXME: need a factory for better mocking support
116 119
 		return new \OC_FileChunking($info);
Please login to merge, or discard this patch.